From bfd230fd78ef7867eec75e6b21715f51e72e7a23 Mon Sep 17 00:00:00 2001 From: Matt Mastracci Date: Mon, 11 Sep 2023 17:12:33 -0600 Subject: [PATCH] chore: update inner #\![allow] to #[allow] (#20463) Functions should generally be annotated with `#[allow]` blocks rather than using inner `#![allow]` annotations. --- cli/tools/repl/mod.rs | 2 +- ext/web/message_port.rs | 2 +- runtime/ops/process.rs | 2 +- runtime/web_worker.rs | 2 +- 4 files changed, 4 insertions(+), 4 deletions(-) diff --git a/cli/tools/repl/mod.rs b/cli/tools/repl/mod.rs index 05c822e114..fb0891fa62 100644 --- a/cli/tools/repl/mod.rs +++ b/cli/tools/repl/mod.rs @@ -27,12 +27,12 @@ use editor::ReplEditor; use session::EvaluationOutput; use session::ReplSession; +#[allow(clippy::await_holding_refcell_ref)] async fn read_line_and_poll( repl_session: &mut ReplSession, message_handler: &mut RustylineSyncMessageHandler, editor: ReplEditor, ) -> Result { - #![allow(clippy::await_holding_refcell_ref)] let mut line_fut = spawn_blocking(move || editor.readline()); let mut poll_worker = true; let notifications_rc = repl_session.notifications.clone(); diff --git a/ext/web/message_port.rs b/ext/web/message_port.rs index 47ebdabf70..73214ab8e9 100644 --- a/ext/web/message_port.rs +++ b/ext/web/message_port.rs @@ -51,11 +51,11 @@ impl MessagePort { Ok(()) } + #[allow(clippy::await_holding_refcell_ref)] // TODO(ry) remove! pub async fn recv( &self, state: Rc>, ) -> Result, AnyError> { - #![allow(clippy::await_holding_refcell_ref)] // TODO(ry) remove! let mut rx = self .rx .try_borrow_mut() diff --git a/runtime/ops/process.rs b/runtime/ops/process.rs index acfd0dc5c5..cef4f77f88 100644 --- a/runtime/ops/process.rs +++ b/runtime/ops/process.rs @@ -336,11 +336,11 @@ fn op_spawn_child( // TODO(bartlomieju): op2 doesn't support clippy allows #[op] +#[allow(clippy::await_holding_refcell_ref)] async fn op_spawn_wait( state: Rc>, rid: ResourceId, ) -> Result { - #![allow(clippy::await_holding_refcell_ref)] let resource = state .borrow_mut() .resource_table diff --git a/runtime/web_worker.rs b/runtime/web_worker.rs index 17bbb41eaa..6fcc7aa9ce 100644 --- a/runtime/web_worker.rs +++ b/runtime/web_worker.rs @@ -236,10 +236,10 @@ pub struct WebWorkerHandle { impl WebWorkerHandle { /// Get the WorkerEvent with lock /// Return error if more than one listener tries to get event + #[allow(clippy::await_holding_refcell_ref)] // TODO(ry) remove! pub async fn get_control_event( &self, ) -> Result, AnyError> { - #![allow(clippy::await_holding_refcell_ref)] // TODO(ry) remove! let mut receiver = self.receiver.borrow_mut(); Ok(receiver.next().await) }