foster/denoland-deno
1
0
Fork 0
mirror of https://github.com/denoland/deno.git synced 2024-11-21 15:04:11 -05:00
Code Issues Packages 1 Wiki Activity

fix: update node process version to latest node LTS (#22709)

Browse source 
<!--
Before submitting a PR, please read
https://docs.deno.com/runtime/manual/references/contributing

1. Give the PR a descriptive title.

  Examples of good title:
    - fix(std/http): Fix race condition in server
    - docs(console): Update docstrings
    - feat(doc): Handle nested reexports

  Examples of bad title:
    - fix #7123
    - update docs
    - fix bugs

2. Ensure there is a related issue and it is referenced in the PR text.
3. Ensure there are tests that cover the changes.
4. Ensure `cargo test` passes.
5. Ensure `./tools/format.js` passes without changing files.
6. Ensure `./tools/lint.js` passes.
7. Open as a draft PR if your work is still in progress. The CI won't
run
   all steps, but you can add '[ci]' to a commit message to force it to.
8. If you would like to run the benchmarks on the CI, add the 'ci-bench'
label.
-->
The issue seems to be already fixed since we upped to a newer 18.x
version string in [another
PR](https://github.com/denoland/deno/pull/20366). Updating to latest
node LTS version can't hurt though.

Fixes https://github.com/denoland/deno/issues/21515
This commit is contained in:
Marvin Hagemeister 2024-03-05 17:02:08 +01:00 committed by GitHub
parent 72d34a79ac
commit c38f59f657
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
1 changed files with 2 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

4
ext/node/polyfills/_process/process.ts
View file

@ -96,7 +96,7 @@ export const env: InstanceType<ObjectConstructor> & Record<string, string> =
* it pointed to Deno version, but that led to incompability * it pointed to Deno version, but that led to incompability
* with some packages. * with some packages.
*/ */
export const version = "v18.18.0"; export const version = "v20.11.1";
/** /**
* https://nodejs.org/api/process.html#process_process_versions * https://nodejs.org/api/process.html#process_process_versions
@ -107,7 +107,7 @@ export const version = "v18.18.0";
* with some packages. Value of `v8` field is still taken from `Deno.version`. * with some packages. Value of `v8` field is still taken from `Deno.version`.
*/ */
export const versions = { export const versions = {
node: "18.17.1", node: "20.11.1",
uv: "1.43.0", uv: "1.43.0",
zlib: "1.2.11", zlib: "1.2.11",
brotli: "1.0.9", brotli: "1.0.9",