mirror of
https://github.com/denoland/deno.git
synced 2024-12-23 07:44:48 -05:00
fix(check): ignore noImplicitOverrides in remote modules (#25854)
This commit is contained in:
parent
a4f59c7761
commit
c4f7b2ac00
4 changed files with 18 additions and 1 deletions
|
@ -140,7 +140,9 @@ impl Diagnostic {
|
|||
pub fn include_when_remote(&self) -> bool {
|
||||
/// TS6133: value is declared but its value is never read (noUnusedParameters and noUnusedLocals)
|
||||
const TS6133: u64 = 6133;
|
||||
self.code != TS6133
|
||||
/// TS4114: This member must have an 'override' modifier because it overrides a member in the base class 'X'.
|
||||
const TS4114: u64 = 4114;
|
||||
!matches!(self.code, TS6133 | TS4114)
|
||||
}
|
||||
|
||||
fn fmt_category_and_code(&self, f: &mut fmt::Formatter) -> fmt::Result {
|
||||
|
|
4
tests/specs/check/remote_missing_override/__test__.jsonc
Normal file
4
tests/specs/check/remote_missing_override/__test__.jsonc
Normal file
|
@ -0,0 +1,4 @@
|
|||
{
|
||||
"args": "check --all main.ts",
|
||||
"output": "Download [WILDLINE]\nCheck [WILDLINE]\n"
|
||||
}
|
1
tests/specs/check/remote_missing_override/main.ts
Normal file
1
tests/specs/check/remote_missing_override/main.ts
Normal file
|
@ -0,0 +1 @@
|
|||
import "http://localhost:4545/check/missing_override.ts";
|
10
tests/testdata/check/missing_override.ts
vendored
Normal file
10
tests/testdata/check/missing_override.ts
vendored
Normal file
|
@ -0,0 +1,10 @@
|
|||
export class Base {
|
||||
method() {
|
||||
}
|
||||
}
|
||||
|
||||
export class Derived extends Base {
|
||||
// missing override keyword
|
||||
method() {
|
||||
}
|
||||
}
|
Loading…
Reference in a new issue