1
0
Fork 0
mirror of https://github.com/denoland/deno.git synced 2024-11-24 15:19:26 -05:00

fix(check): ignore noImplicitOverrides in remote modules (#25854)

This commit is contained in:
David Sherret 2024-09-24 20:49:44 -04:00 committed by GitHub
parent a4f59c7761
commit c4f7b2ac00
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
4 changed files with 18 additions and 1 deletions

View file

@ -140,7 +140,9 @@ impl Diagnostic {
pub fn include_when_remote(&self) -> bool {
/// TS6133: value is declared but its value is never read (noUnusedParameters and noUnusedLocals)
const TS6133: u64 = 6133;
self.code != TS6133
/// TS4114: This member must have an 'override' modifier because it overrides a member in the base class 'X'.
const TS4114: u64 = 4114;
!matches!(self.code, TS6133 | TS4114)
}
fn fmt_category_and_code(&self, f: &mut fmt::Formatter) -> fmt::Result {

View file

@ -0,0 +1,4 @@
{
"args": "check --all main.ts",
"output": "Download [WILDLINE]\nCheck [WILDLINE]\n"
}

View file

@ -0,0 +1 @@
import "http://localhost:4545/check/missing_override.ts";

View file

@ -0,0 +1,10 @@
export class Base {
method() {
}
}
export class Derived extends Base {
// missing override keyword
method() {
}
}