foster/denoland-deno
1
0
Fork 0
mirror of https://github.com/denoland/deno.git synced 2024-11-24 15:19:26 -05:00
Code Issues Packages 1 Wiki Activity

BREAKING: remove --trace-ops (#25344)

Browse source 
Towards #22079
This commit is contained in:
Asher Gomez 2024-09-03 02:26:05 +10:00 committed by GitHub
parent 3015f16fbf
commit c62829fc03
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
3 changed files with 2 additions and 25 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

23
cli/args/flags.rs
View file

@ -2784,14 +2784,6 @@ Directory arguments are expanded to all contained files matching the glob
.action(ArgAction::SetTrue)
.help_heading(TEST_HEADING),
)
.arg(
Arg::new("trace-ops")
.long("trace-ops")
.help("Deprecated alias for --trace-leaks")
.hide(true)
.action(ArgAction::SetTrue)
.help_heading(TEST_HEADING),
)
.arg(
Arg::new("trace-leaks")
.long("trace-leaks")
@ -4662,20 +4654,7 @@ fn test_parse(flags: &mut Flags, matches: &mut ArgMatches) {
};
let no_run = matches.get_flag("no-run");
let trace_leaks =
matches.get_flag("trace-ops") || matches.get_flag("trace-leaks");
#[allow(clippy::print_stderr)]
if trace_leaks && matches.get_flag("trace-ops") {
// We can't change this to use the log crate because its not configured
// yet at this point since the flags haven't been parsed. This flag is
// deprecated though so it's not worth changing the code to use the log
// crate here and this is only done for testing anyway.
eprintln!(
"⚠️ {}",
crate::colors::yellow("The `--trace-ops` flag is deprecated and will be removed in Deno 2.0.\nUse the `--trace-leaks` flag instead."),
);
}
let trace_leaks = matches.get_flag("trace-leaks");
let doc = matches.get_flag("doc");
#[allow(clippy::print_stderr)]
let allow_none = matches.get_flag("permit-no-files")

2
tests/integration/test_tests.rs
View file

@ -251,7 +251,7 @@ itest!(allow_none {
});
itest!(ops_sanitizer_unstable {
args: "test --trace-ops test/sanitizer/ops_sanitizer_unstable.ts",
args: "test --trace-leaks test/sanitizer/ops_sanitizer_unstable.ts",
exit_code: 1,
output: "test/sanitizer/ops_sanitizer_unstable.out",
});

2
tests/testdata/test/sanitizer/ops_sanitizer_unstable.out vendored
View file

@ -1,5 +1,3 @@
⚠️ The `--trace-ops` flag is deprecated and will be removed in Deno 2.0.
Use the `--trace-leaks` flag instead.
Check [WILDCARD]/ops_sanitizer_unstable.ts
running 2 tests from [WILDCARD]/ops_sanitizer_unstable.ts
no-op ... ok ([WILDCARD])