foster/denoland-deno
1
0
Fork 0
mirror of https://github.com/denoland/deno.git synced 2024-12-24 08:09:08 -05:00
Code Issues Packages 1 Wiki Activity

fix(ext/kv): throw error if already closed (#21459)

Browse source 
If KV is closed and tries to listen queue should throw an error

closes #20991
This commit is contained in:
Raashid Anwar 2023-12-05 23:46:47 +05:30 committed by GitHub
parent 4a9f429501
commit cac17267fb
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
3 changed files with 20 additions and 0 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

1
cli/tests/integration/js_unit_tests.rs
View file

@ -48,6 +48,7 @@ util::unit_test_factory!(
jupyter_test,
kv_test,
kv_queue_test_no_db_close,
kv_queue_test,
kv_queue_undelivered_test,
link_test,
make_temp_test,

13
cli/tests/unit/kv_queue_test.ts Normal file
View file

@ -0,0 +1,13 @@
// Copyright 2018-2023 the Deno authors. All rights reserved. MIT license.
import { assertEquals, assertFalse } from "./test_util.ts";
Deno.test({}, async function queueTestDbClose() {
const db: Deno.Kv = await Deno.openKv(":memory:");
db.close();
try {
await db.listenQueue(() => {});
assertFalse(false);
} catch (e) {
assertEquals(e.message, "already closed");
}
});

6
ext/kv/01_db.ts
View file

@ -64,6 +64,7 @@ const kvSymbol = Symbol("KvRid");
class Kv {
#rid: number;
#isClosed: boolean;
constructor(rid: number = undefined, symbol: symbol = undefined) {
if (kvSymbol !== symbol) {
@ -72,6 +73,7 @@ class Kv {
);
}
this.#rid = rid;
this.#isClosed = false;
}
atomic() {
@ -251,6 +253,9 @@ class Kv {
async listenQueue(
handler: (message: unknown) => Promise<void> | void,
): Promise<void> {
if (this.#isClosed) {
throw new Error("already closed");
}
const finishMessageOps = new Map<number, Promise<void>>();
while (true) {
// Wait for the next message.
@ -366,6 +371,7 @@ class Kv {
close() {
core.close(this.#rid);
this.#isClosed = true;
}
[SymbolDispose]() {