From cadeaae045d2489fe125286b8c2c641c6d973c3f Mon Sep 17 00:00:00 2001
From: Leo Kettmeir <crowlkats@toaxl.com>
Date: Tue, 24 Jan 2023 15:03:46 +0100
Subject: [PATCH] feat(runtime/command): make stdin default to inherit for
 spawn() (#17334)

Closes #17230
---
 cli/tests/unit/command_test.ts     | 18 ++++++++++++++++++
 cli/tsc/dts/lib.deno.unstable.d.ts |  7 ++++---
 runtime/js/40_spawn.js             |  1 +
 3 files changed, 23 insertions(+), 3 deletions(-)

diff --git a/cli/tests/unit/command_test.ts b/cli/tests/unit/command_test.ts
index e7f9405354..b9fa8295b5 100644
--- a/cli/tests/unit/command_test.ts
+++ b/cli/tests/unit/command_test.ts
@@ -83,6 +83,24 @@ Deno.test(
   },
 );
 
+Deno.test(
+  { permissions: { run: true, read: true } },
+  async function commandStdinPiped() {
+    const command = new Deno.Command(Deno.execPath(), {
+      args: ["info"],
+      stdout: "null",
+      stderr: "null",
+    });
+    const child = command.spawn();
+
+    assertThrows(() => child.stdin, TypeError, "stdin is not piped");
+    assertThrows(() => child.stdout, TypeError, "stdout is not piped");
+    assertThrows(() => child.stderr, TypeError, "stderr is not piped");
+
+    await child.status;
+  },
+);
+
 Deno.test(
   { permissions: { run: true, read: true } },
   async function commandStdoutPiped() {
diff --git a/cli/tsc/dts/lib.deno.unstable.d.ts b/cli/tsc/dts/lib.deno.unstable.d.ts
index 7ca089108d..12186c0b3e 100644
--- a/cli/tsc/dts/lib.deno.unstable.d.ts
+++ b/cli/tsc/dts/lib.deno.unstable.d.ts
@@ -95,9 +95,9 @@ declare namespace Deno {
   type NativeVoidType = "void";
 
   /** **UNSTABLE**: New API, yet to be vetted.
-   * 
+   *
    * The native struct type for interfacing with foreign functions.
-   * 
+   *
    */
   type NativeStructType = { readonly struct: readonly NativeType[] };
 
@@ -1640,7 +1640,8 @@ declare namespace Deno {
 
     /** How `stdin` of the spawned process should be handled.
      *
-     * Defaults to `"null"`. */
+     * Defaults to `"inherit"` for `output` & `outputSync`,
+     * and `"inherit"` for `spawn`. */
     stdin?: "piped" | "inherit" | "null";
     /** How `stdout` of the spawned process should be handled.
      *
diff --git a/runtime/js/40_spawn.js b/runtime/js/40_spawn.js
index 9c1d96a28f..ecbab52ad9 100644
--- a/runtime/js/40_spawn.js
+++ b/runtime/js/40_spawn.js
@@ -315,6 +315,7 @@
           ...(this.#options ?? {}),
           stdout: this.#options?.stdout ?? "inherit",
           stderr: this.#options?.stderr ?? "inherit",
+          stdin: this.#options?.stdin ?? "inherit",
         };
         return spawnChild(this.#command, options);
       }