foster/denoland-deno
0
0
Fork 0
mirror of https://github.com/denoland/deno.git synced 2024-10-29 08:58:01 -04:00
Code Issues Wiki Activity

fix(ext/node): fix node:stream.Writable (#21297)

Browse source 
This change applies the same fix as
https://github.com/nodejs/node/pull/46818, and the original example
given in #20456 works as expected.

closes #20456
This commit is contained in:
Yoshiya Hinosawa 2023-11-23 09:57:05 +09:00 committed by Bartek Iwańczuk
parent ffa7cf54d8
commit d0574f788c
No known key found for this signature in database
GPG key ID: 0C6BCDDC3B3AD750
2 changed files with 40 additions and 3 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

37
cli/tests/unit_node/stream_test.ts
View file

@ -1,8 +1,9 @@
// Copyright 2018-2023 the Deno authors. All rights reserved. MIT license.
import { assert } from "../../../test_util/std/testing/asserts.ts";
import { assert, fail } from "../../../test_util/std/testing/asserts.ts";
import { fromFileUrl, relative } from "../../../test_util/std/path/mod.ts";
import { pipeline } from "node:stream/promises";
import { Writable } from "node:stream";
import { createReadStream, createWriteStream } from "node:fs";
Deno.test("stream/promises pipeline", async () => {
@ -23,3 +24,37 @@ Deno.test("stream/promises pipeline", async () => {
// pass
}
});
// TODO(kt3k): Remove this test case when the node compat test suite is
// updated to version 18.16.0 or above.
// The last case in parallel/test-stream2-transform.js covers this case.
// See https://github.com/nodejs/node/pull/46818
Deno.test("stream.Writable does not change the order of items", async () => {
async function test() {
const chunks: Uint8Array[] = [];
const writable = new Writable({
construct(cb) {
setTimeout(cb, 10);
},
write(chunk, _, cb) {
chunks.push(chunk);
cb();
},
});
for (const i of Array(20).keys()) {
writable.write(Uint8Array.from([i]));
await new Promise((resolve) => setTimeout(resolve, 1));
}
if (chunks[0][0] !== 0) {
// The first chunk is swapped with the later chunk.
fail("The first chunk is swapped");
}
}
for (const _ of Array(10)) {
// Run it multiple times to avoid flaky false negative.
await test();
}
});

6
ext/node/polyfills/_stream.mjs
View file

@ -1669,9 +1669,11 @@ var require_destroy = __commonJS({
}
}
try {
stream._construct(onConstruct);
stream._construct((err) => {
nextTick(onConstruct, err);
});
} catch (err) {
onConstruct(err);
nextTick(onConstruct, err);
}
}
function emitConstructNT(stream) {