foster/denoland-deno
1
0
Fork 0
mirror of https://github.com/denoland/deno.git synced 2024-11-29 16:30:56 -05:00
Code Issues Packages 1 Wiki Activity

perf: disable snapshot compression (#18061)

Browse source 
This commit disables snapshot compression for the CLI snapshot.]

Decompressing the snapshot on startup takes ~2.5ms.
This commit is contained in:
Bartek Iwańczuk 2023-03-07 08:57:58 -04:00 committed by GitHub
parent fe368b72c1
commit d12b039e1a
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
4 changed files with 7 additions and 75 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

9
cli/build.rs
View file

@ -380,14 +380,7 @@ fn create_cli_snapshot(snapshot_path: PathBuf) {
startup_snapshot: Some(deno_runtime::js::deno_isolate_init()), startup_snapshot: Some(deno_runtime::js::deno_isolate_init()),
extensions, extensions,
extensions_with_js, extensions_with_js,
compression_cb: Some(Box::new(|vec, snapshot_slice| { compression_cb: None,
lzzzz::lz4_hc::compress_to_vec(
snapshot_slice,
vec,
lzzzz::lz4_hc::CLEVEL_MAX,
)
.expect("snapshot compression failed");
})),
snapshot_module_load_cb: None, snapshot_module_load_cb: None,
}) })
} }

29
cli/js.rs
View file

@ -1,37 +1,12 @@
// Copyright 2018-2023 the Deno authors. All rights reserved. MIT license. // Copyright 2018-2023 the Deno authors. All rights reserved. MIT license.
use deno_core::Snapshot; use deno_core::Snapshot;
use log::debug;
use once_cell::sync::Lazy;
pub static CLI_SNAPSHOT: Lazy<Box<[u8]>> = Lazy::new( static CLI_SNAPSHOT: &[u8] =
#[allow(clippy::uninit_vec)]
#[cold]
#[inline(never)]
|| {
static COMPRESSED_CLI_SNAPSHOT: &[u8] =
include_bytes!(concat!(env!("OUT_DIR"), "/CLI_SNAPSHOT.bin")); include_bytes!(concat!(env!("OUT_DIR"), "/CLI_SNAPSHOT.bin"));
let size =
u32::from_le_bytes(COMPRESSED_CLI_SNAPSHOT[0..4].try_into().unwrap())
as usize;
let mut vec = Vec::with_capacity(size);
// SAFETY: vec is allocated with exact snapshot size (+ alignment)
// SAFETY: non zeroed bytes are overwritten with decompressed snapshot
unsafe {
vec.set_len(size);
}
lzzzz::lz4::decompress(&COMPRESSED_CLI_SNAPSHOT[4..], &mut vec).unwrap();
vec.into_boxed_slice()
},
);
pub fn deno_isolate_init() -> Snapshot { pub fn deno_isolate_init() -> Snapshot {
debug!("Deno isolate init with snapshots."); Snapshot::Static(CLI_SNAPSHOT)
Snapshot::Static(&CLI_SNAPSHOT)
} }
#[cfg(test)] #[cfg(test)]

9
runtime/build.rs
View file

@ -294,14 +294,7 @@ mod startup_snapshot {
startup_snapshot: None, startup_snapshot: None,
extensions: vec![], extensions: vec![],
extensions_with_js, extensions_with_js,
compression_cb: Some(Box::new(|vec, snapshot_slice| { compression_cb: None,
lzzzz::lz4_hc::compress_to_vec(
snapshot_slice,
vec,
lzzzz::lz4_hc::CLEVEL_MAX,
)
.expect("snapshot compression failed");
})),
snapshot_module_load_cb: Some(Box::new(transpile_ts_for_snapshotting)), snapshot_module_load_cb: Some(Box::new(transpile_ts_for_snapshotting)),
}); });
} }

33
runtime/js.rs
View file

@ -1,43 +1,14 @@
// Copyright 2018-2023 the Deno authors. All rights reserved. MIT license. // Copyright 2018-2023 the Deno authors. All rights reserved. MIT license.
#[cfg(not(feature = "dont_create_runtime_snapshot"))] #[cfg(not(feature = "dont_create_runtime_snapshot"))]
use deno_core::Snapshot; use deno_core::Snapshot;
#[cfg(not(feature = "dont_create_runtime_snapshot"))]
use log::debug;
#[cfg(not(feature = "dont_create_runtime_snapshot"))]
use once_cell::sync::Lazy;
#[cfg(not(feature = "dont_create_runtime_snapshot"))] #[cfg(not(feature = "dont_create_runtime_snapshot"))]
static COMPRESSED_RUNTIME_SNAPSHOT: &[u8] = static RUNTIME_SNAPSHOT: &[u8] =
include_bytes!(concat!(env!("OUT_DIR"), "/RUNTIME_SNAPSHOT.bin")); include_bytes!(concat!(env!("OUT_DIR"), "/RUNTIME_SNAPSHOT.bin"));
#[cfg(not(feature = "dont_create_runtime_snapshot"))]
pub static RUNTIME_SNAPSHOT: Lazy<Box<[u8]>> = Lazy::new(
#[allow(clippy::uninit_vec)]
#[cold]
#[inline(never)]
|| {
let size =
u32::from_le_bytes(COMPRESSED_RUNTIME_SNAPSHOT[0..4].try_into().unwrap())
as usize;
let mut vec = Vec::with_capacity(size);
// SAFETY: vec is allocated with exact snapshot size (+ alignment)
// SAFETY: non zeroed bytes are overwritten with decompressed snapshot
unsafe {
vec.set_len(size);
}
lzzzz::lz4::decompress(&COMPRESSED_RUNTIME_SNAPSHOT[4..], &mut vec)
.unwrap();
vec.into_boxed_slice()
},
);
#[cfg(not(feature = "dont_create_runtime_snapshot"))] #[cfg(not(feature = "dont_create_runtime_snapshot"))]
pub fn deno_isolate_init() -> Snapshot { pub fn deno_isolate_init() -> Snapshot {
debug!("Deno isolate init with snapshots."); Snapshot::Static(RUNTIME_SNAPSHOT)
Snapshot::Static(&RUNTIME_SNAPSHOT)
} }
#[cfg(not(feature = "include_js_files_for_snapshotting"))] #[cfg(not(feature = "include_js_files_for_snapshotting"))]