From d2c80aa26f30cfc3d614ff313a8dfe4c2c534cd1 Mon Sep 17 00:00:00 2001
From: evan <github@evan.lol>
Date: Sat, 23 Apr 2022 15:39:56 +0300
Subject: [PATCH] fix(bench): eliminate sanitizeExit overhead (#14361)

---
 runtime/js/40_testing.js | 80 ++++++++++++----------------------------
 1 file changed, 23 insertions(+), 57 deletions(-)

diff --git a/runtime/js/40_testing.js b/runtime/js/40_testing.js
index 7a5162e7ff..b176e7b2d4 100644
--- a/runtime/js/40_testing.js
+++ b/runtime/js/40_testing.js
@@ -438,27 +438,6 @@
     };
   }
 
-  function assertExitSync(fn, isTest) {
-    return function exitSanitizer(...params) {
-      setExitHandler((exitCode) => {
-        assert(
-          false,
-          `${
-            isTest ? "Test case" : "Bench"
-          } attempted to exit with exit code: ${exitCode}`,
-        );
-      });
-
-      try {
-        fn(...new SafeArrayIterator(params));
-      } catch (err) {
-        throw err;
-      } finally {
-        setExitHandler(null);
-      }
-    };
-  }
-
   function assertTestStepScopes(fn) {
     /** @param step {TestStep} */
     return async function testStepSanitizer(step) {
@@ -535,18 +514,18 @@
     };
   }
 
+  function pledgePermissions(permissions) {
+    return core.opSync(
+      "op_pledge_test_permissions",
+      serializePermissions(permissions),
+    );
+  }
+
+  function restorePermissions(token) {
+    core.opSync("op_restore_test_permissions", token);
+  }
+
   function withPermissions(fn, permissions) {
-    function pledgePermissions(permissions) {
-      return core.opSync(
-        "op_pledge_test_permissions",
-        serializePermissions(permissions),
-      );
-    }
-
-    function restorePermissions(token) {
-      core.opSync("op_restore_test_permissions", token);
-    }
-
     return async function applyPermissions(...params) {
       const token = pledgePermissions(permissions);
 
@@ -749,11 +728,6 @@
     const AsyncFunction = (async () => {}).constructor;
     benchDef.async = AsyncFunction === benchDef.fn.constructor;
 
-    benchDef.fn = wrapBenchFnWithSanitizers(
-      benchDef.fn,
-      benchDef,
-    );
-
     ArrayPrototypePush(benches, benchDef);
   }
 
@@ -989,10 +963,16 @@
 
     try {
       if (bench.permissions) {
-        token = core.opSync(
-          "op_pledge_test_permissions",
-          serializePermissions(bench.permissions),
-        );
+        token = pledgePermissions(bench.permissions);
+      }
+
+      if (bench.sanitizeExit) {
+        setExitHandler((exitCode) => {
+          assert(
+            false,
+            `Bench attempted to exit with exit code: ${exitCode}`,
+          );
+        });
       }
 
       const benchTimeInMs = 500;
@@ -1003,7 +983,8 @@
     } catch (error) {
       return { failed: { ...bench, error: formatError(error) } };
     } finally {
-      if (token !== null) core.opSync("op_restore_test_permissions", token);
+      if (bench.sanitizeExit) setExitHandler(null);
+      if (token !== null) restorePermissions(token);
     }
   }
 
@@ -1543,21 +1524,6 @@
     return testFn;
   }
 
-  /**
-   * @template T {Function}
-   * @param fn {T}
-   * @param opts {{
-   *   sanitizeExit: boolean,
-   * }}
-   * @returns {T}
-   */
-  function wrapBenchFnWithSanitizers(fn, opts) {
-    if (opts.sanitizeExit) {
-      fn = opts.async ? assertExit(fn, false) : assertExitSync(fn, false);
-    }
-    return fn;
-  }
-
   /**
    * @template T
    * @param value {T | undefined}