foster/denoland-deno
1
0
Fork 0
mirror of https://github.com/denoland/deno.git synced 2024-12-21 23:04:45 -05:00
Code Issues Packages 1 Wiki Activity

chore(core): Parallelize all WPT tests and reduce timeouts for expected failures (#19061)

Browse source 
This speeds up WPT tests in two ways:

1. The `WebCryptoAPI` tests are slow, so create a parallel bucket for
each individual test instead of one for all the `WebCryptoAPI` tests.
2. If a test is expected to fail, use a shorter timeout (1 minute rather
than 4).
This commit is contained in:
Matt Mastracci 2023-05-10 21:35:42 +02:00 committed by GitHub
parent eb374e8cd3
commit d55e07f627
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
1 changed files with 20 additions and 5 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

25
tools/wpt.ts
View file

@ -145,6 +145,18 @@ interface TestToRun {
expectation: boolean | string[];
}
function getTestTimeout(test: TestToRun) {
if (Deno.env.get("CI")) {
// Don't give expected failures the full time
if (test.expectation === false) {
return { long: 60_000, default: 10_000 };
}
return { long: 4 * 60_000, default: 4 * 60_000 };
}
return { long: 60_000, default: 10_000 };
}
async function run() {
const startTime = new Date().getTime();
assert(Array.isArray(rest), "filter must be array");
@ -154,11 +166,11 @@ async function run() {
expectation,
);
assertAllExpectationsHaveTests(expectation, tests, rest);
console.log(`Going to run ${tests.length} test files.`);
const cores = navigator.hardwareConcurrency;
console.log(`Going to run ${tests.length} test files on ${cores} cores.`);
const results = await runWithTestUtil(false, async () => {
const results: { test: TestToRun; result: TestResult }[] = [];
const cores = navigator.hardwareConcurrency;
const inParallel = !(cores === 1 || tests.length === 1);
// ideally we would parallelize all tests, but we ran into some flakiness
// on the CI, so here we're partitioning based on the start of the test path
@ -174,9 +186,7 @@ async function run() {
test.options,
inParallel ? () => {} : createReportTestCase(test.expectation),
inspectBrk,
Deno.env.get("CI")
? { long: 4 * 60_000, default: 4 * 60_000 }
: { long: 60_000, default: 10_000 },
getTestTimeout(test),
);
results.push({ test, result });
if (inParallel) {
@ -755,6 +765,11 @@ function discoverTestsToRun(
function partitionTests(tests: TestToRun[]): TestToRun[][] {
const testsByKey: { [key: string]: TestToRun[] } = {};
for (const test of tests) {
// Run all WebCryptoAPI tests in parallel
if (test.path.includes("/WebCryptoAPI")) {
testsByKey[test.path] = [test];
continue;
}
// Paths looks like: /fetch/corb/img-html-correctly-labeled.sub-ref.html
const key = test.path.split("/")[1];
if (!(key in testsByKey)) {