foster/denoland-deno
1
0
Fork 0
mirror of https://github.com/denoland/deno.git synced 2024-12-22 07:14:47 -05:00
Code Issues Packages 1 Wiki Activity

perf(ext/web): fast path for ws events (#18905)

Browse source 
- Do not use `ReflectHas` in `isNode`.
- Avoid copying handler array when handlers.length == 1
- Avoid searching for path target when path.length == 1

```
Linux divy-2 5.19.0-1022-gcp #24~22.04.1-Ubuntu SMP Sun Apr 23 09:51:08 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
32GiB System memory
Intel(R) Xeon(R) CPU @ 3.10GHz

# main + https://github.com/denoland/deno/pull/18904
Msg/sec: 89326.750000
Msg/sec: 90320.000000
Msg/sec: 89576.250000

# this patch
Msg/sec: 97250.000000
Msg/sec: 97125.500000
Msg/sec: 97964.500000
```
This commit is contained in:
Divy Srivastava 2023-05-01 10:39:30 +05:30 committed by GitHub
parent 9a9473533e
commit d856bfd336
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
3 changed files with 18 additions and 15 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

4
cli/tests/testdata/run/event_listener_error_immediate_exit.ts.out vendored
View file

@ -3,8 +3,4 @@ error: Uncaught Error: bar
throw new Error("bar"); throw new Error("bar");
^ ^
at [WILDCARD]/event_listener_error_immediate_exit.ts:4:9[WILDCARD] at [WILDCARD]/event_listener_error_immediate_exit.ts:4:9[WILDCARD]
at innerInvokeEventListeners (ext:deno_web/02_event.js:785:7)
at invokeEventListeners (ext:deno_web/02_event.js:825:5)
at dispatch (ext:deno_web/02_event.js:694:9)
at dispatchEvent (ext:deno_web/02_event.js:1086:12)
at [WILDCARD]/event_listener_error_immediate_exit.ts:11:1 at [WILDCARD]/event_listener_error_immediate_exit.ts:11:1

6
cli/tests/testdata/run/event_listener_error_immediate_exit_worker.ts.out vendored
View file

@ -2,11 +2,7 @@
error: Uncaught (in worker "") Error: bar error: Uncaught (in worker "") Error: bar
throw new Error("bar"); throw new Error("bar");
^ ^
at [WILDCARD]/event_listener_error_immediate_exit.ts:4:9 at [WILDCARD]/event_listener_error_immediate_exit.ts:4:9[WILDCARD]
at innerInvokeEventListeners (ext:deno_web/02_event.js:785:7)
at invokeEventListeners (ext:deno_web/02_event.js:825:5)
at dispatch (ext:deno_web/02_event.js:694:9)
at dispatchEvent (ext:deno_web/02_event.js:1086:12)
at [WILDCARD]/event_listener_error_immediate_exit.ts:11:1 at [WILDCARD]/event_listener_error_immediate_exit.ts:11:1
error: Uncaught (in promise) Error: Unhandled error in child worker. error: Uncaught (in promise) Error: Unhandled error in child worker.
at [WILDCARD] at [WILDCARD]

23
ext/web/02_event.js
View file

@ -482,7 +482,7 @@ function getRoot(eventTarget) {
function isNode( function isNode(
eventTarget, eventTarget,
) { ) {
return Boolean(eventTarget && ReflectHas(eventTarget, "nodeType")); return eventTarget?.nodeType !== undefined;
} }
// https://dom.spec.whatwg.org/#concept-shadow-including-inclusive-ancestor // https://dom.spec.whatwg.org/#concept-shadow-including-inclusive-ancestor
@ -734,8 +734,12 @@ function innerInvokeEventListeners(
return found; return found;
} }
let handlers = targetListeners[type];
// Copy event listeners before iterating since the list can be modified during the iteration. // Copy event listeners before iterating since the list can be modified during the iteration.
const handlers = ArrayPrototypeSlice(targetListeners[type]); if (handlers.length > 1) {
handlers = ArrayPrototypeSlice(targetListeners[type]);
}
for (let i = 0; i < handlers.length; i++) { for (let i = 0; i < handlers.length; i++) {
const listener = handlers[i]; const listener = handlers[i];
@ -804,12 +808,19 @@ function innerInvokeEventListeners(
* Ref: https://dom.spec.whatwg.org/#concept-event-listener-invoke */ * Ref: https://dom.spec.whatwg.org/#concept-event-listener-invoke */
function invokeEventListeners(tuple, eventImpl) { function invokeEventListeners(tuple, eventImpl) {
const path = getPath(eventImpl); const path = getPath(eventImpl);
const tupleIndex = ArrayPrototypeIndexOf(path, tuple); if (path.length === 1) {
for (let i = tupleIndex; i >= 0; i--) { const t = path[0];
const t = path[i];
if (t.target) { if (t.target) {
setTarget(eventImpl, t.target); setTarget(eventImpl, t.target);
break; }
} else {
const tupleIndex = ArrayPrototypeIndexOf(path, tuple);
for (let i = tupleIndex; i >= 0; i--) {
const t = path[i];
if (t.target) {
setTarget(eventImpl, t.target);
break;
}
} }
} }