foster/denoland-deno
1
0
Fork 0
mirror of https://github.com/denoland/deno.git synced 2024-11-24 15:19:26 -05:00
Code Issues Packages 1 Wiki Activity

chore: disable flaky Node compat test (#20832)

Browse source
This commit is contained in:
Bartek Iwańczuk 2023-10-09 10:57:32 +02:00 committed by GitHub
parent ae81065c75
commit d868bae90a
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
1 changed files with 16 additions and 14 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

30
cli/tests/node_compat/test/internet/test-dns.js
View file

@ -172,24 +172,26 @@ TEST(async function test_resolveMx(done) {
checkWrap(req);
});
TEST(function test_resolveMx_failure(done) {
dnsPromises.resolveMx(addresses.NOT_FOUND)
.then(common.mustNotCall())
.catch(common.mustCall((err) => {
assert.strictEqual(err.code, 'ENOTFOUND');
}));
// TODO(bartlomieju): this test became very flaky on CI, returning `UNKNOWN`
// instead of `ENOTFOUND`.
// TEST(function test_resolveMx_failure(done) {
// dnsPromises.resolveMx(addresses.NOT_FOUND)
// .then(common.mustNotCall())
// .catch(common.mustCall((err) => {
// assert.strictEqual(err.code, 'ENOTFOUND');
// }));
const req = dns.resolveMx(addresses.NOT_FOUND, function(err, result) {
assert.ok(err instanceof Error);
assert.strictEqual(err.code, 'ENOTFOUND');
// const req = dns.resolveMx(addresses.NOT_FOUND, function(err, result) {
// assert.ok(err instanceof Error);
// assert.strictEqual(err.code, 'ENOTFOUND');
assert.strictEqual(result, undefined);
// assert.strictEqual(result, undefined);
done();
});
// done();
// });
checkWrap(req);
});
// checkWrap(req);
// });
TEST(async function test_resolveNs(done) {
function validateResult(result) {