From dcc75d5685ddb1ad3c1b97721cbc24bf6fa56c76 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Bartek=20Iwa=C5=84czuk?= Date: Fri, 15 Nov 2024 00:19:12 +0000 Subject: [PATCH] chore: remove some unused tests (#26878) --- tests/integration/run_tests.rs | 31 ---------- .../run/warn_on_deprecated_api/main.js | 34 ----------- .../run/warn_on_deprecated_api/main.out | 15 ----- .../warn_on_deprecated_api/main.verbose.out | 60 ------------------- .../main_disabled_env.out | 15 ----- .../main_disabled_flag.out | 14 ----- .../run/warn_on_deprecated_api/mod.ts | 11 ---- tools/lint.js | 2 +- 8 files changed, 1 insertion(+), 181 deletions(-) delete mode 100644 tests/testdata/run/warn_on_deprecated_api/main.js delete mode 100644 tests/testdata/run/warn_on_deprecated_api/main.out delete mode 100644 tests/testdata/run/warn_on_deprecated_api/main.verbose.out delete mode 100644 tests/testdata/run/warn_on_deprecated_api/main_disabled_env.out delete mode 100644 tests/testdata/run/warn_on_deprecated_api/main_disabled_flag.out delete mode 100644 tests/testdata/run/warn_on_deprecated_api/mod.ts diff --git a/tests/integration/run_tests.rs b/tests/integration/run_tests.rs index e29ecc486c..549b88bac4 100644 --- a/tests/integration/run_tests.rs +++ b/tests/integration/run_tests.rs @@ -2899,37 +2899,6 @@ console.log(returnsHi());"#, .assert_exit_code(1); } -// TODO(bartlomieju): temporary disabled -// itest!(warn_on_deprecated_api { -// args: "run -A run/warn_on_deprecated_api/main.js", -// output: "run/warn_on_deprecated_api/main.out", -// http_server: true, -// exit_code: 0, -// }); - -// itest!(warn_on_deprecated_api_verbose { -// args: "run -A run/warn_on_deprecated_api/main.js", -// output: "run/warn_on_deprecated_api/main.verbose.out", -// envs: vec![("DENO_VERBOSE_WARNINGS".to_string(), "1".to_string())], -// http_server: true, -// exit_code: 0, -// }); - -// itest!(warn_on_deprecated_api_with_flag { -// args: "run -A --quiet run/warn_on_deprecated_api/main.js", -// output: "run/warn_on_deprecated_api/main_disabled_flag.out", -// http_server: true, -// exit_code: 0, -// }); - -// itest!(warn_on_deprecated_api_with_env_var { -// args: "run -A run/warn_on_deprecated_api/main.js", -// envs: vec![("DENO_NO_DEPRECATION_WARNINGS".to_string(), "1".to_string())], -// output: "run/warn_on_deprecated_api/main_disabled_env.out", -// http_server: true, -// exit_code: 0, -// }); - #[test] fn deno_json_imports_expand() { let test_context = TestContextBuilder::for_npm().use_temp_cwd().build(); diff --git a/tests/testdata/run/warn_on_deprecated_api/main.js b/tests/testdata/run/warn_on_deprecated_api/main.js deleted file mode 100644 index 8811df78de..0000000000 --- a/tests/testdata/run/warn_on_deprecated_api/main.js +++ /dev/null @@ -1,34 +0,0 @@ -import { runEcho as runEcho2 } from "http://localhost:4545/run/warn_on_deprecated_api/mod.ts"; - -// @ts-ignore `Deno.run()` was soft-removed in Deno 2. -const p = Deno.run({ - cmd: [ - Deno.execPath(), - "eval", - "console.log('hello world')", - ], -}); -await p.status(); -p.close(); - -async function runEcho() { - // @ts-ignore `Deno.run()` was soft-removed in Deno 2. - const p = Deno.run({ - cmd: [ - Deno.execPath(), - "eval", - "console.log('hello world')", - ], - }); - await p.status(); - p.close(); -} - -await runEcho(); -await runEcho(); - -for (let i = 0; i < 10; i++) { - await runEcho(); -} - -await runEcho2(); diff --git a/tests/testdata/run/warn_on_deprecated_api/main.out b/tests/testdata/run/warn_on_deprecated_api/main.out deleted file mode 100644 index ef85a6f99b..0000000000 --- a/tests/testdata/run/warn_on_deprecated_api/main.out +++ /dev/null @@ -1,15 +0,0 @@ -Download http://localhost:4545/run/warn_on_deprecated_api/mod.ts -hello world -hello world -hello world -hello world -hello world -hello world -hello world -hello world -hello world -hello world -hello world -hello world -hello world -hello world diff --git a/tests/testdata/run/warn_on_deprecated_api/main.verbose.out b/tests/testdata/run/warn_on_deprecated_api/main.verbose.out deleted file mode 100644 index e17562eef3..0000000000 --- a/tests/testdata/run/warn_on_deprecated_api/main.verbose.out +++ /dev/null @@ -1,60 +0,0 @@ -Download http://localhost:4545/run/warn_on_deprecated_api/mod.ts - -See the Deno 1 to 2 Migration Guide for more information at https://docs.deno.com/runtime/manual/advanced/migrate_deprecations - -Stack trace: - at [WILDCARD]warn_on_deprecated_api/main.js:3:16 - -hint: Use "Deno.Command()" API instead. - -hello world - -See the Deno 1 to 2 Migration Guide for more information at https://docs.deno.com/runtime/manual/advanced/migrate_deprecations - -Stack trace: - at runEcho ([WILDCARD]warn_on_deprecated_api/main.js:14:18) - at [WILDCARD]warn_on_deprecated_api/main.js:25:7 - -hint: Use "Deno.Command()" API instead. - -hello world - -See the Deno 1 to 2 Migration Guide for more information at https://docs.deno.com/runtime/manual/advanced/migrate_deprecations - -Stack trace: - at runEcho ([WILDCARD]warn_on_deprecated_api/main.js:14:18) - at [WILDCARD]warn_on_deprecated_api/main.js:26:7 - -hint: Use "Deno.Command()" API instead. - -hello world - -See the Deno 1 to 2 Migration Guide for more information at https://docs.deno.com/runtime/manual/advanced/migrate_deprecations - -Stack trace: - at runEcho ([WILDCARD]warn_on_deprecated_api/main.js:14:18) - at [WILDCARD]warn_on_deprecated_api/main.js:29:9 - -hint: Use "Deno.Command()" API instead. - -hello world -hello world -hello world -hello world -hello world -hello world -hello world -hello world -hello world -hello world - -See the Deno 1 to 2 Migration Guide for more information at https://docs.deno.com/runtime/manual/advanced/migrate_deprecations - -Stack trace: - at runEcho (http://localhost:4545/run/warn_on_deprecated_api/mod.ts:2:18) - at [WILDCARD]warn_on_deprecated_api/main.js:32:7 - -hint: Use "Deno.Command()" API instead. -hint: It appears this API is used by a remote dependency. Try upgrading to the latest version of that dependency. - -hello world diff --git a/tests/testdata/run/warn_on_deprecated_api/main_disabled_env.out b/tests/testdata/run/warn_on_deprecated_api/main_disabled_env.out deleted file mode 100644 index ef85a6f99b..0000000000 --- a/tests/testdata/run/warn_on_deprecated_api/main_disabled_env.out +++ /dev/null @@ -1,15 +0,0 @@ -Download http://localhost:4545/run/warn_on_deprecated_api/mod.ts -hello world -hello world -hello world -hello world -hello world -hello world -hello world -hello world -hello world -hello world -hello world -hello world -hello world -hello world diff --git a/tests/testdata/run/warn_on_deprecated_api/main_disabled_flag.out b/tests/testdata/run/warn_on_deprecated_api/main_disabled_flag.out deleted file mode 100644 index ce3755d166..0000000000 --- a/tests/testdata/run/warn_on_deprecated_api/main_disabled_flag.out +++ /dev/null @@ -1,14 +0,0 @@ -hello world -hello world -hello world -hello world -hello world -hello world -hello world -hello world -hello world -hello world -hello world -hello world -hello world -hello world diff --git a/tests/testdata/run/warn_on_deprecated_api/mod.ts b/tests/testdata/run/warn_on_deprecated_api/mod.ts deleted file mode 100644 index f74632b2cd..0000000000 --- a/tests/testdata/run/warn_on_deprecated_api/mod.ts +++ /dev/null @@ -1,11 +0,0 @@ -export async function runEcho() { - const p = Deno.run({ - cmd: [ - Deno.execPath(), - "eval", - "console.log('hello world')", - ], - }); - await p.status(); - p.close(); -} diff --git a/tools/lint.js b/tools/lint.js index cc595c2b13..21064a05bf 100755 --- a/tools/lint.js +++ b/tools/lint.js @@ -219,7 +219,7 @@ async function ensureNoNewITests() { "pm_tests.rs": 0, "publish_tests.rs": 0, "repl_tests.rs": 0, - "run_tests.rs": 24, + "run_tests.rs": 20, "shared_library_tests.rs": 0, "task_tests.rs": 2, "test_tests.rs": 0,