foster/denoland-deno
1
0
Fork 0
mirror of https://github.com/denoland/deno.git synced 2025-01-11 00:21:05 -05:00
Code Issues Packages 1 Wiki Activity

fix(ext/node): Support env option in worker_thread (#23462)

Browse source 
Fixes https://github.com/denoland/deno/issues/23455
This commit is contained in:
Divy Srivastava 2024-04-20 09:18:10 +05:30 committed by GitHub
parent 9425dce6db
commit e0554ac4a2
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
2 changed files with 32 additions and 0 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

6
ext/node/polyfills/worker_threads.ts
View file

@ -27,6 +27,7 @@ import * as webidl from "ext:deno_webidl/00_webidl.js";
import { notImplemented } from "ext:deno_node/_utils.ts";
import { EventEmitter } from "node:events";
import { BroadcastChannel } from "ext:deno_broadcast_channel/01_broadcast_channel.js";
import process from "node:process";
const { ObjectPrototypeIsPrototypeOf } = primordials;
const {
@ -128,6 +129,7 @@ class NodeWorker extends EventEmitter {
const serializedWorkerMetadata = serializeJsMessageData({
workerData: options?.workerData,
environmentData: environmentData,
env: options?.env,
}, options?.transferList ?? []);
const id = op_create_worker(
{
@ -348,6 +350,10 @@ internals.__initWorkerThreads = (
const { 0: metadata, 1: _ } = maybeWorkerMetadata;
workerData = metadata.workerData;
environmentData = metadata.environmentData;
const env = metadata.env;
if (env) {
process.env = env;
}
}
defaultExport.workerData = workerData;
defaultExport.parentPort = parentPort;

26
tests/unit_node/worker_threads_test.ts
View file

@ -460,3 +460,29 @@ Deno.test("[node/worker_threads] receiveMessageOnPort works if there's pending r
port5.close();
port6.close();
});
Deno.test({
name: "[node/worker_threads] Worker env",
async fn() {
const deferred = Promise.withResolvers<void>();
const worker = new workerThreads.Worker(
`
import { parentPort } from "node:worker_threads";
import process from "node:process";
parentPort.postMessage(process.env.TEST_ENV);
`,
{
eval: true,
env: { TEST_ENV: "test" },
},
);
worker.on("message", (data) => {
assertEquals(data, "test");
deferred.resolve();
});
await deferred.promise;
await worker.terminate();
},
});