foster/denoland-deno
1
0
Fork 0
mirror of https://github.com/denoland/deno.git synced 2024-12-25 00:29:09 -05:00
Code Issues Packages 1 Wiki Activity

test(runtime): support Windows in resolve_from_cwd_absolute (#18379)

Browse source 
`current_dir().unwrap()` joined with a Path is equivalent to the
implementation in `resolve_from_cwd()`. Manually tested on Ubuntu 22.04
and Windows 11.

Signed-off-by: Elijah Conners <business@elijahpepe.com>
This commit is contained in:
Elijah 2023-04-12 16:45:53 -07:00 committed by GitHub
parent 659d1dd7f8
commit e2853a955c
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
2 changed files with 8 additions and 8 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

8
cli/util/fs.rs
View file

@ -672,12 +672,12 @@ mod tests {
} }
} }
// TODO: Get a good expected value here for Windows.
#[cfg(not(windows))]
#[test] #[test]
fn resolve_from_cwd_absolute() { fn resolve_from_cwd_absolute() {
let expected = Path::new("/a"); let expected = Path::new("a");
assert_eq!(resolve_from_cwd(expected).unwrap(), expected); let cwd = current_dir().unwrap();
let absolute_expected = cwd.join(expected);
assert_eq!(resolve_from_cwd(expected).unwrap(), absolute_expected);
} }
#[test] #[test]

8
runtime/fs_util.rs
View file

@ -72,11 +72,11 @@ mod tests {
} }
} }
// TODO: Get a good expected value here for Windows.
#[cfg(not(windows))]
#[test] #[test]
fn resolve_from_cwd_absolute() { fn resolve_from_cwd_absolute() {
let expected = Path::new("/a"); let expected = Path::new("a");
assert_eq!(resolve_from_cwd(expected).unwrap(), expected); let cwd = current_dir().unwrap();
let absolute_expected = cwd.join(expected);
assert_eq!(resolve_from_cwd(expected).unwrap(), absolute_expected);
} }
} }