foster/denoland-deno
1
0
Fork 0
mirror of https://github.com/denoland/deno.git synced 2024-11-22 15:06:54 -05:00
Code Issues Packages 1 Wiki Activity

fix(node/buffer): make slice be the same as subarray (#19481)

Browse source
This commit is contained in:
Leo Kettmeir 2023-06-13 21:26:28 +02:00 committed by Bartek Iwańczuk
parent e4920f4a28
commit e2aee58c89
No known key found for this signature in database
GPG key ID: 0C6BCDDC3B3AD750
3 changed files with 14 additions and 25 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

1
cli/tests/integration/node_unit_tests.rs
View file

@ -47,6 +47,7 @@ util::unit_test_factory!(
_fs_watch_test = _fs / _fs_watch_test,
_fs_write_test = _fs / _fs_write_test,
async_hooks_test,
buffer_test,
child_process_test,
crypto_cipher_test = crypto / crypto_cipher_test,
crypto_hash_test = crypto / crypto_hash_test,

12
cli/tests/unit_node/buffer_test.ts Normal file
View file

@ -0,0 +1,12 @@
// Copyright 2018-2023 the Deno authors. All rights reserved. MIT license.
import { Buffer } from "node:buffer";
import { assertEquals } from "../../../test_util/std/testing/asserts.ts";
Deno.test({
name: "[node/buffer] slice with infinity returns empty buffer",
fn() {
const buf = Buffer.from([1, 2, 3, 4, 5]);
assertEquals(buf.slice(Infinity).length, 0);
},
});

26
ext/node/polyfills/internal/buffer.mjs
View file

@ -860,31 +860,7 @@ function _hexSlice(buf, start, end) {
}
Buffer.prototype.slice = function slice(start, end) {
const len = this.length;
start = ~~start;
end = end === void 0 ? len : ~~end;
if (start < 0) {
start += len;
if (start < 0) {
start = 0;
}
} else if (start > len) {
start = len;
}
if (end < 0) {
end += len;
if (end < 0) {
end = 0;
}
} else if (end > len) {
end = len;
}
if (end < start) {
end = start;
}
const newBuf = this.subarray(start, end);
Object.setPrototypeOf(newBuf, Buffer.prototype);
return newBuf;
return this.subarray(start, end);
};
Buffer.prototype.readUintLE = Buffer.prototype.readUIntLE = function readUIntLE(