fix(ext/node): allow absolute path in createRequire (#16853)

Co-authored-by: David Sherret <dsherret@gmail.com>

cli/tests/npm_tests.rs

@@ -1516,7 +1516,7 @@ mod npm {
   });
 
   itest!(create_require {
-    args: "run --reload npm/create_require/main.ts",
+    args: "run --reload --allow-read npm/create_require/main.ts",
     output: "npm/create_require/main.out",
     exit_code: 0,
     envs: env_vars_for_npm_tests(),

cli/tests/testdata/npm/create_require/main.out

@@ -1,6 +1,12 @@
 [WILDCARD]
 function
 function
+function
+function
+function
+function
 The argument 'filename' must be a file URL object, file URL string, or absolute path string. Received https://example.com/
 The argument 'filename' must be a file URL object, file URL string, or absolute path string. Received https://example.com/
 The argument 'filename' must be a file URL object, file URL string, or absolute path string. Received 1
+The argument 'filename' must be a file URL object, file URL string, or absolute path string. Received foo
+The argument 'filename' must be a file URL object, file URL string, or absolute path string. Received ./foo

cli/tests/testdata/npm/registry/@denotest/create-require/1.0.0/index.js

@@ -2,6 +2,10 @@ import { createRequire } from "module";
 
 console.log(typeof createRequire(import.meta.url));
 console.log(typeof createRequire(new URL(import.meta.url)));
+console.log(typeof createRequire("/"));
+console.log(typeof createRequire("/foo"));
+console.log(typeof createRequire("/foo/"));
+console.log(typeof createRequire("c:\\foo"));
 try {
   createRequire("https://example.com/");
 } catch (e) {
@@ -17,3 +21,13 @@ try {
 } catch (e) {
   console.log(e.message);
 }
+try {
+  createRequire("foo");
+} catch (e) {
+  console.log(e.message);
+}
+try {
+  createRequire("./foo");
+} catch (e) {
+  console.log(e.message);
+}

ext/node/02_require.js

@@ -826,6 +826,17 @@
     return require;
   }
 
+  // Matches to:
+  // - /foo/...
+  // - \foo\...
+  // - C:/foo/...
+  // - C:\foo\...
+  const RE_START_OF_ABS_PATH = /^([/\\]|[a-zA-Z]:[/\\])/;
+
+  function isAbsolute(filenameOrUrl) {
+    return RE_START_OF_ABS_PATH.test(filenameOrUrl);
+  }
+
   function createRequire(filenameOrUrl) {
     let fileUrlStr;
     if (filenameOrUrl instanceof URL) {
@@ -836,7 +847,7 @@
       }
       fileUrlStr = filenameOrUrl.toString();
     } else if (typeof filenameOrUrl === "string") {
-      if (!filenameOrUrl.startsWith("file:")) {
+      if (!filenameOrUrl.startsWith("file:") && !isAbsolute(filenameOrUrl)) {
         throw new Error(
           `The argument 'filename' must be a file URL object, file URL string, or absolute path string. Received ${filenameOrUrl}`,
         );

ext/node/lib.rs

@@ -245,7 +245,10 @@ where
 fn op_require_proxy_path(filename: String) -> String {
   // Allow a directory to be passed as the filename
   let trailing_slash = if cfg!(windows) {
-    filename.ends_with('\\')
+    // Node also counts a trailing forward slash as a
+    // directory for node on Windows, but not backslashes
+    // on non-Windows platforms
+    filename.ends_with('\\') || filename.ends_with('/')
   } else {
     filename.ends_with('/')
   };