foster/denoland-deno
1
0
Fork 0
mirror of https://github.com/denoland/deno.git synced 2024-12-31 03:29:10 -05:00
Code Issues Packages 1 Wiki Activity

fix(test): don't swallow sanitizer errors with permissions (#18550)

Browse source 
Missing `return` from #18246.
This commit is contained in:
Nayeem Rahman 2023-04-01 21:20:16 +01:00 committed by GitHub
parent 0210c1cadf
commit e5588d2f1e
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
3 changed files with 9 additions and 4 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
cli/js/40_testing.js
View file

@ -481,7 +481,7 @@ function withPermissions(fn, permissions) {
const token = pledgePermissions(permissions); const token = pledgePermissions(permissions);
try { try {
await fn(...new SafeArrayIterator(params)); return await fn(...new SafeArrayIterator(params));
} finally { } finally {
restorePermissions(token); restorePermissions(token);
} }

2
cli/tests/testdata/test/ops_sanitizer_unstable.out vendored
View file

@ -10,7 +10,7 @@ error: Leaking async ops:
- 1 async operation to sleep for a duration was started in this test, but never completed. This is often caused by not cancelling a `setTimeout` or `setInterval` call. The operation was started here: - 1 async operation to sleep for a duration was started in this test, but never completed. This is often caused by not cancelling a `setTimeout` or `setInterval` call. The operation was started here:
at [WILDCARD] at [WILDCARD]
at setInterval ([WILDCARD]) at setInterval ([WILDCARD])
at [WILDCARD]/testdata/test/ops_sanitizer_unstable.ts:3:3 at fn ([WILDCARD]/testdata/test/ops_sanitizer_unstable.ts:7:5)
at [WILDCARD] at [WILDCARD]
FAILURES FAILURES

9
cli/tests/testdata/test/ops_sanitizer_unstable.ts vendored
View file

@ -1,4 +1,9 @@
Deno.test("no-op", function () {}); Deno.test("no-op", function () {});
Deno.test("leak interval", function () { Deno.test({
setInterval(function () {}, 100000); name: "leak interval",
// regression test for sanitizer errors being swallowed with permissions.
permissions: {},
fn() {
setInterval(function () {}, 100000);
},
}); });