foster/denoland-deno
1
0
Fork 0
mirror of https://github.com/denoland/deno.git synced 2025-01-03 04:48:52 -05:00
Code Issues Packages 1 Wiki Activity

enable error-on-warning (#10410)

Browse source 
Only on linux and osx. Fixes one warning.
This commit is contained in:
Ryan Dahl 2021-04-28 15:10:44 -04:00 committed by GitHub
parent f60373e0d1
commit e63c533154
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
2 changed files with 7 additions and 3 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

8
.github/workflows/ci.yml vendored
View file

@ -48,8 +48,6 @@ jobs:
env: env:
RUST_BACKTRACE: full RUST_BACKTRACE: full
CARGO_TERM_COLOR: always CARGO_TERM_COLOR: always
# TODO(ry) Enable error on warning after fixing https://github.com/denoland/deno/issues/10378
# RUSTFLAGS: -D warnings
steps: steps:
- name: Configure git - name: Configure git
@ -93,6 +91,12 @@ jobs:
curl -fsSL https://deno.land/x/install/install.sh | sh -s v1.7.2 curl -fsSL https://deno.land/x/install/install.sh | sh -s v1.7.2
echo "$HOME/.deno/bin" >> $GITHUB_PATH echo "$HOME/.deno/bin" >> $GITHUB_PATH
# TODO(ry) Enable on all OSes https://github.com/denoland/deno/issues/10378
- name: Error on Warning
if: |
!startsWith(matrix.os, 'windows')
run: echo "RUSTFLAGS=-D warnings" >> $GITHUB_ENV
- name: Install Deno (Windows) - name: Install Deno (Windows)
if: startsWith(matrix.os, 'windows') if: startsWith(matrix.os, 'windows')
run: |- run: |-

2
core/runtime.rs
View file

@ -403,7 +403,7 @@ impl JsRuntime {
for e in extensions.iter_mut() { for e in extensions.iter_mut() {
e.init_state(&mut op_state.borrow_mut())?; e.init_state(&mut op_state.borrow_mut())?;
// Register each op after middlewaring it // Register each op after middlewaring it
let mut ops = e.init_ops().unwrap_or_default(); let ops = e.init_ops().unwrap_or_default();
for (name, opfn) in ops { for (name, opfn) in ops {
self.register_op(name, macroware(name, opfn)); self.register_op(name, macroware(name, opfn));
} }