foster/denoland-deno
1
0
Fork 0
mirror of https://github.com/denoland/deno.git synced 2024-12-22 07:14:47 -05:00
Code Issues Packages 1 Wiki Activity

fix(task): output encoding issues on windows (#16794)

Browse source 
Closes #16792
This commit is contained in:
David Sherret 2022-11-24 19:37:02 -05:00 committed by GitHub
parent 72dd7ad807
commit e6a9588b43
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
6 changed files with 17 additions and 4 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

4
Cargo.lock generated
View file

@ -1226,9 +1226,9 @@ dependencies = [
[[package]] [[package]]
name = "deno_task_shell" name = "deno_task_shell"
version = "0.7.2" version = "0.7.3"
source = "registry+https://github.com/rust-lang/crates.io-index" source = "registry+https://github.com/rust-lang/crates.io-index"
checksum = "e8ad1e1002ecf8bafcb9b968bf19856ba4fe0e6c0c73b3404565bb29b15aae2c" checksum = "a071a6407ade5107091a2481a502e7e6a9a96c5a631c71748058c5a28928fcd3"
dependencies = [ dependencies = [
"anyhow", "anyhow",
"futures", "futures",

2
cli/Cargo.toml
View file

@ -48,7 +48,7 @@ deno_emit = "0.11.0"
deno_graph = "0.38.0" deno_graph = "0.38.0"
deno_lint = { version = "0.35.0", features = ["docs"] } deno_lint = { version = "0.35.0", features = ["docs"] }
deno_runtime.workspace = true deno_runtime.workspace = true
deno_task_shell = "0.7.2" deno_task_shell = "0.7.3"
napi_sym.workspace = true napi_sym.workspace = true
atty.workspace = true atty.workspace = true

8
cli/tests/integration/task_tests.rs
View file

@ -50,6 +50,14 @@ itest!(task_non_existent {
exit_code: 1, exit_code: 1,
}); });
#[test]
fn task_emoji() {
// this bug only appears when using a pty/tty
let args = "task --config task/deno.json echo_emoji";
use test_util::PtyData::*;
test_util::test_pty2(args, vec![Output("Task echo_emoji echo 🔥\r\n🔥")]);
}
itest!(task_boolean_logic { itest!(task_boolean_logic {
args: "task -q --config task/deno.json boolean_logic", args: "task -q --config task/deno.json boolean_logic",
output: "task/task_boolean_logic.out", output: "task/task_boolean_logic.out",

3
cli/tests/testdata/task/deno.json vendored
View file

@ -7,6 +7,7 @@
"piped": "echo 12345 | (deno eval 'const b = new Uint8Array(1);Deno.stdin.readSync(b);console.log(b)' && deno eval 'const b = new Uint8Array(1);Deno.stdin.readSync(b);console.log(b)')", "piped": "echo 12345 | (deno eval 'const b = new Uint8Array(1);Deno.stdin.readSync(b);console.log(b)' && deno eval 'const b = new Uint8Array(1);Deno.stdin.readSync(b);console.log(b)')",
"exit_code_5": "echo $(echo 10 ; exit 2) && exit 5", "exit_code_5": "echo $(echo 10 ; exit 2) && exit 5",
"echo_cwd": "echo $(pwd)", "echo_cwd": "echo $(pwd)",
"echo_init_cwd": "echo $INIT_CWD" "echo_init_cwd": "echo $INIT_CWD",
"echo_emoji": "echo 🔥"
} }
} }

2
cli/tests/testdata/task/task_no_args.out vendored
View file

@ -7,6 +7,8 @@ Available tasks:
echo 1 echo 1
- echo_cwd - echo_cwd
echo $(pwd) echo $(pwd)
- echo_emoji
echo 🔥
- echo_init_cwd - echo_init_cwd
echo $INIT_CWD echo $INIT_CWD
- exit_code_5 - exit_code_5

2
cli/tests/testdata/task/task_non_existent.out vendored
View file

@ -8,6 +8,8 @@ Available tasks:
echo 1 echo 1
- echo_cwd - echo_cwd
echo $(pwd) echo $(pwd)
- echo_emoji
echo 🔥
- echo_init_cwd - echo_init_cwd
echo $INIT_CWD echo $INIT_CWD
- exit_code_5 - exit_code_5