foster/denoland-deno
1
0
Fork 0
mirror of https://github.com/denoland/deno.git synced 2024-12-22 07:14:47 -05:00
Code Issues Packages 1 Wiki Activity

perf(ext/http): cache abort signal error (#23548)

Browse source 
Fixes a perf regression introduced in
eed2598e6c
([flamegraph](https://profiler.firefox.com/public/83whz7mrfkshk5q6hd6hjmrmw8tgmw67s96m4p0/flame-graph/?globalTrackOrder=0&hiddenLocalTracksByPid=12691-0we&symbolServer=http%3A%2F%2F127.0.0.1%3A3000%2F316cvciry38ippl9i74fmcxrd5q9asfrr28xp02&thread=0&v=10))

this patch:
```
Summary:
  Success rate: 100.00%
  Total:        10.0007 secs
  Slowest:      0.0145 secs
  Fastest:      0.0001 secs
  Average:      0.0006 secs
  Requests/sec: 80341.4816

  Total data:   9.19 MiB
  Size/request: 12
  Size/sec:     941.44 KiB
```

main:
```
Summary:
  Success rate: 100.00%
  Total:        10.0007 secs
  Slowest:      0.0068 secs
  Fastest:      0.0002 secs
  Average:      0.0009 secs
  Requests/sec: 56560.0551

  Total data:   6.47 MiB
  Size/request: 12
  Size/sec:     662.75 KiB
```
This commit is contained in:
Divy Srivastava 2024-04-25 12:50:01 +05:30 committed by GitHub
parent 115dedde22
commit e98862deb2
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
1 changed files with 9 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

10
ext/http/00_serve.ts
View file

@ -126,6 +126,8 @@ function addTrailers(resp, headerList) {
op_http_set_response_trailers(inner.external, headerList);
}
let signalAbortError;
class InnerRequest {
#external;
#context;
@ -156,9 +158,15 @@ class InnerRequest {
);
}
}
if (!signalAbortError) {
signalAbortError = new DOMException(
"The request has been cancelled.",
"AbortError",
);
}
// Unconditionally abort the request signal. Note that we don't use
// an error here.
this.#abortController.abort();
this.#abortController.abort(signalAbortError);
this.#external = null;
}