From ebfc75fe8cfb8af1a6f5a1a021d8fd9f235bdd8e Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Bartek=20Iwa=C5=84czuk?= Date: Mon, 24 Apr 2023 15:55:06 +0200 Subject: [PATCH] test: disable flaky Node test (#18821) If we hit a slow runner this test almost always fails. --- cli/tests/node_compat/config.jsonc | 6 ++- .../test-child-process-exec-timeout-kill.js | 50 ------------------- 2 files changed, 4 insertions(+), 52 deletions(-) delete mode 100644 cli/tests/node_compat/test/parallel/test-child-process-exec-timeout-kill.js diff --git a/cli/tests/node_compat/config.jsonc b/cli/tests/node_compat/config.jsonc index ce1cf3a08c..fd7703d6b8 100644 --- a/cli/tests/node_compat/config.jsonc +++ b/cli/tests/node_compat/config.jsonc @@ -32,7 +32,8 @@ "test-child-process-exec-std-encoding.js", // TODO(bartlomieju): this test was flaky on macOS CI // "test-child-process-exec-timeout-expire.js", - "test-child-process-exec-timeout-kill.js", + // TODO(bartlomieju): this test was flaky on macOS CI + // "test-child-process-exec-timeout-kill.js", "test-child-process-exec-timeout-not-expired.js", "test-child-process-execFile-promisified-abortController.js", "test-child-process-execfile.js", @@ -212,7 +213,8 @@ "test-child-process-exec-stdout-stderr-data-string.js", // TODO(bartlomieju): this test was flaky on macOS CI // "test-child-process-exec-timeout-expire.js", - "test-child-process-exec-timeout-kill.js", + // TODO(bartlomieju): this test was flaky on macOS CI + // "test-child-process-exec-timeout-kill.js", // TODO(bartlomieju): this test was flaky on macOS CI // "test-child-process-execFile-promisified-abortController.js", "test-child-process-execfile-maxbuf.js", diff --git a/cli/tests/node_compat/test/parallel/test-child-process-exec-timeout-kill.js b/cli/tests/node_compat/test/parallel/test-child-process-exec-timeout-kill.js deleted file mode 100644 index fd4884fc5f..0000000000 --- a/cli/tests/node_compat/test/parallel/test-child-process-exec-timeout-kill.js +++ /dev/null @@ -1,50 +0,0 @@ -// deno-fmt-ignore-file -// deno-lint-ignore-file - -// Copyright Joyent and Node contributors. All rights reserved. MIT license. -// Taken from Node 18.12.1 -// This file is automatically generated by "node/_tools/setup.ts". Do not modify this file manually - -// TODO(PolarETech): The process.argv[3] check should be argv[2], and the -// command passed to exec() should not need to include "run", "-A", -// and "require.ts". - -'use strict'; - -// Test exec() with both a timeout and a killSignal. - -const common = require('../common'); -const assert = require('assert'); -const cp = require('child_process'); - -const { - cleanupStaleProcess, - logInTimeout, - kExpiringChildRunTime, - kExpiringParentTimer, -} = require('../common/child_process'); - -if (process.argv[3] === 'child') { - logInTimeout(kExpiringChildRunTime); - return; -} - -const cmd = `"${process.execPath}" run -A require.ts "${__filename}" child`; - -// Test with a different kill signal. -cp.exec(cmd, { - timeout: kExpiringParentTimer, - killSignal: 'SIGKILL' -}, common.mustCall((err, stdout, stderr) => { - console.log('[stdout]', stdout.trim()); - console.log('[stderr]', stderr.trim()); - - assert.strictEqual(err.killed, true); - assert.strictEqual(err.code, null); - assert.strictEqual(err.signal, 'SIGKILL'); - assert.strictEqual(err.cmd, cmd); - assert.strictEqual(stdout.trim(), ''); - assert.strictEqual(stderr.trim(), ''); -})); - -cleanupStaleProcess(__filename);