foster/denoland-deno
1
0
Fork 0
mirror of https://github.com/denoland/deno.git synced 2024-11-25 15:29:32 -05:00
Code Issues Packages 1 Wiki Activity

console.warn goes to stderr (#810)

Browse source
This commit is contained in:
Kevin (Kun) "Kassimo" Qian 2018-09-25 01:27:02 -04:00 committed by Ryan Dahl
parent ad5065e23e
commit f156a86024
4 changed files with 13 additions and 8 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

5
js/console.ts
View file

@ -110,7 +110,7 @@ export function stringifyArgs(args: any[]): string {
return out.join(" ");
}
type PrintFunc = (x: string) => void;
type PrintFunc = (x: string, isErr?: boolean) => void;
export class Console {
constructor(private printFunc: PrintFunc) {}
@ -125,8 +125,7 @@ export class Console {
// tslint:disable-next-line:no-any
warn(...args: any[]): void {
// TODO Log to stderr.
this.printFunc(stringifyArgs(args));
this.printFunc(stringifyArgs(args), true);
}
error = this.warn;

2
js/libdeno.ts
View file

@ -8,7 +8,7 @@ interface Libdeno {
send(msg: ArrayBufferView): null | Uint8Array;
print(x: string): void;
print(x: string, isErr?: boolean): void;
setGlobalErrorHandler: (
handler: (

12
libdeno/binding.cc
View file

@ -141,13 +141,19 @@ void ExitOnPromiseRejectCallback(
}
void Print(const v8::FunctionCallbackInfo<v8::Value>& args) {
CHECK_EQ(args.Length(), 1);
CHECK_GE(args.Length(), 1);
CHECK_LE(args.Length(), 2);
auto* isolate = args.GetIsolate();
Deno* d = static_cast<Deno*>(isolate->GetData(0));
auto context = d->context.Get(d->isolate);
v8::HandleScope handle_scope(isolate);
v8::String::Utf8Value str(isolate, args[0]);
bool is_err =
args.Length() >= 2 ? args[1]->BooleanValue(context).ToChecked() : false;
const char* cstr = ToCString(str);
printf("%s\n", cstr);
fflush(stdout);
auto stream = is_err ? stderr : stdout;
fprintf(stream, "%s\n", cstr);
fflush(stream);
}
static v8::Local<v8::Uint8Array> ImportBuf(v8::Isolate* isolate, deno_buf buf) {

2
libdeno/libdeno_test.js
View file

@ -112,7 +112,7 @@ global.SnapshotBug = () => {
global.GlobalErrorHandling = () => {
libdeno.setGlobalErrorHandler((message, source, line, col, error) => {
libdeno.print(`line ${line} col ${col}`);
libdeno.print(`line ${line} col ${col}`, true);
assert("ReferenceError: notdefined is not defined" === message);
assert(source === "helloworld.js");
assert(line === 3);