1
0
Fork 0
mirror of https://github.com/denoland/deno.git synced 2024-12-24 08:09:08 -05:00

fix(node): expose channels in worker_threads (#19086)

This PR ensures that node's `worker_threads` module exports
`MessageChannel`, `MessagePort` and the `BroadcastChannel` API. Fixing
these won't make `esbuild` work, but brings us one step closer 🎉

Fixes #19028 .
This commit is contained in:
Marvin Hagemeister 2023-05-11 12:32:19 +02:00 committed by GitHub
parent 28aa489de9
commit f1d0f745d3
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
4 changed files with 28 additions and 10 deletions

View file

@ -655,6 +655,8 @@
"test-whatwg-url-override-hostname.js",
"test-whatwg-url-properties.js",
"test-whatwg-url-toascii.js",
"test-worker-threads-broadcast-channel.js",
"test-worker-threads-message-channel.js",
"test-zlib-close-after-error.js",
"test-zlib-close-after-write.js",
"test-zlib-convenience-methods.js",

View file

@ -0,0 +1,9 @@
// deno-fmt-ignore-file
// deno-lint-ignore-file
"use strict";
const assert = require("assert/strict");
const worker_threads = require("worker_threads");
assert.equal(BroadcastChannel, worker_threads.BroadcastChannel);

View file

@ -0,0 +1,10 @@
// deno-fmt-ignore-file
// deno-lint-ignore-file
"use strict";
const assert = require("assert/strict");
const worker_threads = require("worker_threads");
assert.equal(MessageChannel, worker_threads.MessageChannel);
assert.equal(MessagePort, worker_threads.MessagePort);

View file

@ -4,6 +4,8 @@
import { resolve, toFileUrl } from "ext:deno_node/path.ts";
import { notImplemented } from "ext:deno_node/_utils.ts";
import { EventEmitter } from "ext:deno_node/events.ts";
import { BroadcastChannel } from "ext:deno_broadcast_channel/01_broadcast_channel.js";
import { MessageChannel, MessagePort } from "ext:deno_web/13_message_port.js";
const environmentData = new Map();
let threads = 0;
@ -204,12 +206,6 @@ export function setEnvironmentData(key: unknown, value?: unknown) {
}
}
// deno-lint-ignore no-explicit-any
const _MessagePort: typeof MessagePort = (globalThis as any).MessagePort;
const _MessageChannel: typeof MessageChannel =
// deno-lint-ignore no-explicit-any
(globalThis as any).MessageChannel;
export const BroadcastChannel = globalThis.BroadcastChannel;
export const SHARE_ENV = Symbol.for("nodejs.worker_threads.SHARE_ENV");
export function markAsUntransferable() {
notImplemented("markAsUntransferable");
@ -221,9 +217,10 @@ export function receiveMessageOnPort() {
notImplemented("receiveMessageOnPort");
}
export {
_MessageChannel as MessageChannel,
_MessagePort as MessagePort,
_Worker as Worker,
BroadcastChannel,
MessageChannel,
MessagePort,
parentPort,
threadId,
workerData,
@ -233,8 +230,8 @@ export default {
markAsUntransferable,
moveMessagePortToContext,
receiveMessageOnPort,
MessagePort: _MessagePort,
MessageChannel: _MessageChannel,
MessagePort,
MessageChannel,
BroadcastChannel,
Worker: _Worker,
getEnvironmentData,