From f474c4f4ff2db301573a228fba0b65f9f4970f8c Mon Sep 17 00:00:00 2001
From: Marvin Hagemeister <marvin@deno.com>
Date: Fri, 9 Aug 2024 14:25:33 +0200
Subject: [PATCH] fix: stub `node:module.register()` (#24965)

This is commonly used to register loading non standard file types. But
some libs also register TS loaders which Deno supports natively, like
the npm `payload` package. This PR unblocks those.

Fixes https://github.com/denoland/deno/issues/24902
---
 ext/node/polyfills/01_require.js | 13 +++++++++++++
 tests/unit_node/module_test.ts   | 10 ++++++++++
 2 files changed, 23 insertions(+)

diff --git a/ext/node/polyfills/01_require.js b/ext/node/polyfills/01_require.js
index f71e009ba9..1636edcb41 100644
--- a/ext/node/polyfills/01_require.js
+++ b/ext/node/polyfills/01_require.js
@@ -1293,6 +1293,19 @@ export function findSourceMap(_path) {
   return undefined;
 }
 
+/**
+ * @param {string | URL} _specifier
+ * @param {string | URL} _parentUrl
+ * @param {{ parentURL: string | URL, data: any, transferList: any[] }} [_options]
+ */
+export function register(_specifier, _parentUrl, _options) {
+  // TODO(@marvinhagemeister): Stub implementation for programs registering
+  // TypeScript loaders. We don't support registering loaders for file
+  // types that Deno itself doesn't support at the moment.
+
+  return undefined;
+}
+
 export { builtinModules, createRequire, isBuiltin, Module };
 export const _cache = Module._cache;
 export const _extensions = Module._extensions;
diff --git a/tests/unit_node/module_test.ts b/tests/unit_node/module_test.ts
index 25249101a6..994dcfb639 100644
--- a/tests/unit_node/module_test.ts
+++ b/tests/unit_node/module_test.ts
@@ -6,6 +6,11 @@ import {
   findSourceMap,
   isBuiltin,
   Module,
+  // @ts-ignore Our internal @types/node is at v18.16.19 which predates
+  // this change. Updating it is difficult due to different types in Node
+  // for `import.meta.filename` and `import.meta.dirname` that Deno
+  // provides.
+  register,
 } from "node:module";
 import { assert, assertEquals } from "@std/assert";
 import process from "node:process";
@@ -99,3 +104,8 @@ Deno.test("[node/module builtinModules] has 'module' in builtins", () => {
 Deno.test("[node/module findSourceMap] is a function", () => {
   assertEquals(findSourceMap("foo"), undefined);
 });
+
+// https://github.com/denoland/deno/issues/24902
+Deno.test("[node/module register] is a function", () => {
+  assertEquals(register("foo"), undefined);
+});