clippy (#4618)

cli/checksum.rs

@@ -1,4 +1,3 @@
-use ring;
 use std::fmt::Write;
 
 pub fn gen(v: Vec<&[u8]>) -> String {

cli/compilers/compiler_worker.rs

@@ -3,7 +3,6 @@ use crate::ops;
 use crate::state::State;
 use crate::web_worker::WebWorker;
 use core::task::Context;
-use deno_core;
 use deno_core::ErrBox;
 use deno_core::StartupData;
 use futures::future::Future;

cli/compilers/wasm.rs

@@ -12,7 +12,6 @@ use deno_core::Buf;
 use deno_core::ErrBox;
 use deno_core::ModuleSpecifier;
 use serde_derive::Deserialize;
-use serde_json;
 use std::collections::HashMap;
 use std::sync::atomic::Ordering;
 use std::sync::{Arc, Mutex};

cli/deno_dir.rs

@@ -1,7 +1,5 @@
 // Copyright 2018-2020 the Deno authors. All rights reserved. MIT license.
 use crate::disk_cache::DiskCache;
-use dirs;
-use std;
 use std::path::PathBuf;
 
 /// `DenoDir` serves as coordinator for multiple `DiskCache`s containing them

cli/diagnostics.rs

@@ -9,7 +9,6 @@ use crate::colors;
 use crate::fmt_errors::format_maybe_source_line;
 use crate::fmt_errors::format_maybe_source_name;
 use crate::fmt_errors::DisplayFormatter;
-use serde_json;
 use serde_json::value::Value;
 use std::error::Error;
 use std::fmt;

cli/file_fetcher.rs

@@ -11,7 +11,6 @@ use deno_core::ModuleSpecifier;
 use futures::future::FutureExt;
 use log::info;
 use regex::Regex;
-use reqwest;
 use std::collections::HashMap;
 use std::fs;
 use std::future::Future;

cli/fmt_errors.rs

@@ -3,7 +3,6 @@
 use crate::colors;
 use crate::source_maps::apply_source_map;
 use crate::source_maps::SourceMapGetter;
-use deno_core;
 use deno_core::ErrBox;
 use deno_core::JSStackFrame;
 use std::error::Error;

cli/global_state.rs

@@ -14,7 +14,6 @@ use crate::msg;
 use crate::permissions::DenoPermissions;
 use deno_core::ErrBox;
 use deno_core::ModuleSpecifier;
-use std;
 use std::env;
 use std::ops::Deref;
 use std::sync::atomic::AtomicUsize;

cli/global_timer.rs

@@ -13,7 +13,6 @@ use futures::channel::oneshot;
 use futures::future::FutureExt;
 use std::future::Future;
 use std::time::Instant;
-use tokio;
 
 #[derive(Default)]
 pub struct GlobalTimer {

cli/http_util.rs

@@ -3,7 +3,6 @@ use crate::version;
 use bytes::Bytes;
 use deno_core::ErrBox;
 use futures::future::FutureExt;
-use reqwest;
 use reqwest::header::HeaderMap;
 use reqwest::header::HeaderValue;
 use reqwest::header::IF_NONE_MATCH;

cli/inspector.rs

@@ -5,7 +5,6 @@
 //! https://hyperandroid.com/2020/02/12/v8-inspector-from-an-embedder-standpoint/
 
 use core::convert::Infallible as Never; // Alias for the future `!` type.
-use deno_core;
 use deno_core::v8;
 use futures::channel::mpsc;
 use futures::channel::mpsc::UnboundedReceiver;
@@ -37,7 +36,6 @@ use std::sync::Mutex;
 use std::sync::Once;
 use std::thread;
 use uuid::Uuid;
-use warp;
 use warp::filters::ws;
 use warp::filters::ws::WebSocket;
 use warp::Filter;

cli/op_error.rs

@@ -17,16 +17,11 @@
 use crate::import_map::ImportMapError;
 use deno_core::ErrBox;
 use deno_core::ModuleResolutionError;
-use dlopen;
-use notify;
-use reqwest;
 use rustyline::error::ReadlineError;
-use std;
 use std::env::VarError;
 use std::error::Error;
 use std::fmt;
 use std::io;
-use url;
 
 // Warning! The values in this enum are duplicated in js/errors.ts
 // Update carefully!

cli/ops/fetch.rs

@@ -9,7 +9,6 @@ use futures::future::FutureExt;
 use http::header::HeaderName;
 use http::header::HeaderValue;
 use http::Method;
-use std;
 use std::convert::From;
 
 pub fn init(i: &mut Isolate, s: &State) {

cli/ops/fs.rs

@@ -13,7 +13,6 @@ use std::env::{current_dir, set_current_dir, temp_dir};
 use std::io::SeekFrom;
 use std::path::{Path, PathBuf};
 use std::time::UNIX_EPOCH;
-use tokio;
 
 use rand::{thread_rng, Rng};
 

cli/ops/net.rs

@@ -7,13 +7,11 @@ use crate::state::State;
 use deno_core::*;
 use futures::future::poll_fn;
 use futures::future::FutureExt;
-use std;
 use std::convert::From;
 use std::net::Shutdown;
 use std::net::SocketAddr;
 use std::task::Context;
 use std::task::Poll;
-use tokio;
 use tokio::net::TcpListener;
 use tokio::net::TcpStream;
 use tokio::net::UdpSocket;

cli/ops/os.rs

@@ -6,7 +6,6 @@ use deno_core::*;
 use std::collections::HashMap;
 use std::env;
 use std::io::{Error, ErrorKind};
-use sys_info;
 use url::Url;
 
 pub fn init(i: &mut Isolate, s: &State) {

cli/ops/process.rs

@@ -5,11 +5,9 @@ use crate::op_error::OpError;
 use crate::signal::kill;
 use crate::state::State;
 use deno_core::*;
-use futures;
 use futures::future::poll_fn;
 use futures::future::FutureExt;
 use futures::TryFutureExt;
-use std;
 use std::convert::From;
 use tokio::process::Command;
 

cli/ops/signal.rs

@@ -9,8 +9,6 @@ use super::dispatch_json::Deserialize;
 #[cfg(unix)]
 use futures::future::{poll_fn, FutureExt};
 #[cfg(unix)]
-use serde_json;
-#[cfg(unix)]
 use std::task::Waker;
 #[cfg(unix)]
 use tokio::signal::unix::{signal, Signal, SignalKind};

cli/ops/timers.rs

@@ -4,7 +4,6 @@ use crate::op_error::OpError;
 use crate::state::State;
 use deno_core::*;
 use futures::future::FutureExt;
-use std;
 use std::time::Duration;
 use std::time::Instant;
 

cli/ops/tls.rs

@@ -7,7 +7,6 @@ use crate::state::State;
 use deno_core::*;
 use futures::future::poll_fn;
 use futures::future::FutureExt;
-use std;
 use std::convert::From;
 use std::fs::File;
 use std::io::BufReader;
@@ -16,7 +15,6 @@ use std::path::Path;
 use std::sync::Arc;
 use std::task::Context;
 use std::task::Poll;
-use tokio;
 use tokio::net::TcpListener;
 use tokio::net::TcpStream;
 use tokio_rustls::{rustls::ClientConfig, TlsConnector};
@@ -27,9 +25,7 @@ use tokio_rustls::{
   },
   TlsAcceptor,
 };
-use webpki;
 use webpki::DNSNameRef;
-use webpki_roots;
 
 pub fn init(i: &mut Isolate, s: &State) {
   i.register_op("op_connect_tls", s.stateful_json_op(op_connect_tls));

cli/ops/tty.rs

@@ -3,7 +3,6 @@ use super::io::{StreamResource, StreamResourceHolder};
 use crate::op_error::OpError;
 use crate::ops::json_op;
 use crate::state::State;
-use atty;
 use deno_core::*;
 #[cfg(unix)]
 use nix::sys::termios;

cli/ops/web_worker.rs

@@ -5,10 +5,8 @@ use crate::ops::json_op;
 use crate::state::State;
 use crate::worker::WorkerEvent;
 use deno_core::*;
-use futures;
 use futures::channel::mpsc;
 use futures::sink::SinkExt;
-use std;
 use std::convert::From;
 
 pub fn web_worker_op<D>(

cli/ops/worker_host.rs

@@ -12,10 +12,8 @@ use crate::web_worker::WebWorker;
 use crate::worker::WorkerEvent;
 use crate::worker::WorkerHandle;
 use deno_core::*;
-use futures;
 use futures::future::FutureExt;
 use futures::future::TryFutureExt;
-use std;
 use std::convert::From;
 use std::thread::JoinHandle;
 

cli/permissions.rs

@@ -2,8 +2,6 @@
 use crate::colors;
 use crate::flags::Flags;
 use crate::op_error::OpError;
-#[cfg(not(test))]
-use atty;
 use std::collections::HashSet;
 use std::fmt;
 #[cfg(not(test))]

cli/repl.rs

@@ -2,7 +2,6 @@
 use crate::deno_dir::DenoDir;
 use crate::op_error::OpError;
 use deno_core::ErrBox;
-use rustyline;
 use std::fs;
 use std::path::PathBuf;
 

cli/source_maps.rs

@@ -1,6 +1,5 @@
 // Copyright 2018-2020 the Deno authors. All rights reserved. MIT license.
 //! This mod provides functions to remap a deno_core::deno_core::JSError based on a source map
-use deno_core;
 use deno_core::JSStackFrame;
 use sourcemap::SourceMap;
 use std::collections::HashMap;

cli/state.rs

@@ -22,7 +22,6 @@ use futures::future::TryFutureExt;
 use rand::rngs::StdRng;
 use rand::SeedableRng;
 use serde_json::Value;
-use std;
 use std::cell::RefCell;
 use std::collections::HashMap;
 use std::ops::Deref;

cli/test_runner.rs

@@ -3,7 +3,6 @@
 use crate::fs as deno_fs;
 use crate::installer::is_remote_url;
 use deno_core::ErrBox;
-use std;
 use std::path::Path;
 use std::path::PathBuf;
 use url::Url;

cli/web_worker.rs

@@ -3,7 +3,6 @@ use crate::ops;
 use crate::state::State;
 use crate::worker::Worker;
 use crate::worker::WorkerEvent;
-use deno_core;
 use deno_core::ErrBox;
 use deno_core::StartupData;
 use futures::future::FutureExt;

cli/worker.rs

@@ -4,7 +4,6 @@ use crate::inspector::DenoInspector;
 use crate::ops;
 use crate::state::DebugType;
 use crate::state::State;
-use deno_core;
 use deno_core::Buf;
 use deno_core::ErrBox;
 use deno_core::ModuleId;

core/es_isolate.rs

@@ -424,9 +424,8 @@ impl EsIsolate {
 
     let is_main =
       load.state == LoadState::LoadingRoot && !load.is_dynamic_import();
-    let referrer_name = &module_url_found.to_string();
     let referrer_specifier =
-      ModuleSpecifier::resolve_url(referrer_name).unwrap();
+      ModuleSpecifier::resolve_url(&module_url_found).unwrap();
 
     // #A There are 3 cases to handle at this moment:
     // 1. Source code resolved result have the same module name as requested

core/resources.rs

@@ -7,7 +7,6 @@
 // descriptor (hence the different name).
 
 use downcast_rs::Downcast;
-use std;
 use std::any::Any;
 use std::collections::HashMap;