foster/denoland-deno
1
0
Fork 0
mirror of https://github.com/denoland/deno.git synced 2024-12-26 00:59:24 -05:00
Code Issues Packages 1 Wiki Activity

fix(fmt): should fail --check on parse error (#14907)

Browse source
This commit is contained in:
David Sherret 2022-06-18 12:44:43 -04:00 committed by GitHub
parent fa7cad06de
commit f564497630
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
5 changed files with 16 additions and 0 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

6
cli/tests/integration/fmt_tests.rs
View file

@ -177,6 +177,12 @@ itest!(fmt_check_ignore {
exit_code: 0,
});
itest!(fmt_check_parse_error {
args: "fmt --check fmt/parse_error/parse_error.ts",
output: "fmt/fmt_check_parse_error.out",
exit_code: 1,
});
itest!(fmt_stdin {
args: "fmt -",
input: Some("const a = 1\n"),

6
cli/tests/testdata/fmt/fmt_check_parse_error.out vendored Normal file
View file

@ -0,0 +1,6 @@
Error checking: [WILDCARD]
Line 2, column 7: Expected '{', got '<eof>'
class Test
~~~~
error: Found 1 not formatted file in 1 file

2
cli/tests/testdata/fmt/parse_error/parse_error.ts vendored Normal file
View file

@ -0,0 +1,2 @@
// a file that purposefully will cause an error
class Test

1
cli/tools/fmt.rs
View file

@ -316,6 +316,7 @@ async fn check_source_files(
incremental_cache.update_file(&file_path, &file_text);
}
Err(e) => {
not_formatted_files_count.fetch_add(1, Ordering::Relaxed);
let _g = output_lock.lock();
eprintln!("Error checking: {}", file_path.to_string_lossy());
eprintln!(" {}", e);

1
tools/lint.js
View file

@ -26,6 +26,7 @@ async function dlint() {
":!:cli/dts/**",
":!:cli/tests/testdata/encoding/**",
":!:cli/tests/testdata/error_syntax.js",
":!:cli/tests/testdata/fmt/**",
":!:cli/tests/testdata/lint/**",
":!:cli/tests/testdata/tsc/**",
":!:cli/tsc/*typescript.js",