foster/denoland-deno
1
0
Fork 0
mirror of https://github.com/denoland/deno.git synced 2024-11-24 15:19:26 -05:00
Code Issues Packages 1 Wiki Activity

refactor(lsp): cleanup document preload (#20520)

Browse source
This commit is contained in:
Nayeem Rahman 2023-09-18 20:58:16 +01:00 committed by GitHub
parent 86c04f43e0
commit f5963b6a05
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
4 changed files with 67 additions and 144 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

133
cli/lsp/config.rs
View file

@ -4,7 +4,6 @@ use super::logging::lsp_log;
use crate::args::ConfigFile;
use crate::lsp::logging::lsp_warn;
use crate::util::fs::canonicalize_path_maybe_not_exists;
use crate::util::path::specifier_from_file_path;
use crate::util::path::specifier_to_file_path;
use deno_core::error::AnyError;
use deno_core::parking_lot::Mutex;
@ -645,77 +644,44 @@ impl Config {
true
}
/// Gets the directories or specifically enabled file paths based on the
/// workspace config.
///
/// WARNING: This may incorrectly have some directory urls as being
/// represented as file urls.
pub fn enabled_urls(&self) -> Vec<Url> {
let mut urls = vec![];
pub fn get_enabled_paths(&self) -> Vec<PathBuf> {
let mut paths = vec![];
for (workspace_uri, _) in &self.workspace_folders {
let Ok(workspace_path) = specifier_to_file_path(workspace_uri) else {
lsp_log!("Unable to convert uri \"{}\" to path.", workspace_uri);
continue;
};
let specifier_settings = self.settings.specifiers.get(workspace_uri);
let enable = specifier_settings
.and_then(|s| s.enable)
.or(self.settings.workspace.enable)
.unwrap_or(self.has_config_file());
let disable_paths = specifier_settings
.map(|s| &s.disable_paths)
.unwrap_or(&self.settings.workspace.disable_paths);
let resolved_disable_paths = disable_paths
.iter()
.map(|p| workspace_path.join(p))
.collect::<Vec<_>>();
let enable_paths = specifier_settings
.and_then(|s| s.enable_paths.as_ref())
.or(self.settings.workspace.enable_paths.as_ref());
if let Some(enable_paths) = enable_paths {
for path in enable_paths {
let path = workspace_path.join(path);
let Ok(path_uri) = specifier_from_file_path(&path) else {
lsp_log!("Unable to convert path \"{}\" to uri.", path.display());
continue;
};
if !resolved_disable_paths.iter().any(|p| path.starts_with(p)) {
urls.push(path_uri);
}
paths.push(workspace_path.join(path));
}
} else if enable
&& !resolved_disable_paths
.iter()
.any(|p| workspace_path.starts_with(p))
{
urls.push(workspace_uri.clone());
} else {
paths.push(workspace_path);
}
}
// sort for determinism
urls.sort();
urls.dedup();
urls
paths.sort();
paths.dedup();
paths
}
pub fn disabled_urls(&self) -> Vec<Url> {
pub fn get_disabled_paths(&self) -> Vec<PathBuf> {
let mut paths = vec![];
if let Some(cf) = self.maybe_config_file() {
if let Some(files) = cf.to_files_config().ok().flatten() {
for path in files.exclude {
paths.push(path);
}
}
}
let root_enable = self
.settings
.workspace
.enable
.unwrap_or(self.has_config_file());
let mut urls = vec![];
if let Some(cf) = self.maybe_config_file() {
if let Some(files) = cf.to_files_config().ok().flatten() {
for path in files.exclude {
let Ok(path_uri) = specifier_from_file_path(&path) else {
lsp_log!("Unable to convert path \"{}\" to uri.", path.display());
continue;
};
urls.push(path_uri);
}
}
}
for (workspace_uri, _) in &self.workspace_folders {
let Ok(workspace_path) = specifier_to_file_path(workspace_uri) else {
lsp_log!("Unable to convert uri \"{}\" to path.", workspace_uri);
@ -730,20 +696,15 @@ impl Config {
.map(|s| &s.disable_paths)
.unwrap_or(&self.settings.workspace.disable_paths);
for path in disable_paths {
let path = workspace_path.join(path);
let Ok(path_uri) = specifier_from_file_path(&path) else {
lsp_log!("Unable to convert path \"{}\" to uri.", path.display());
continue;
};
urls.push(path_uri);
paths.push(workspace_path.join(path));
}
} else {
urls.push(workspace_uri.clone());
paths.push(workspace_path);
}
}
urls.sort();
urls.dedup();
urls
paths.sort();
paths.dedup();
paths
}
pub fn specifier_code_lens_test(&self, specifier: &ModuleSpecifier) -> bool {
@ -1129,45 +1090,33 @@ mod tests {
}
#[test]
fn config_enabled_urls() {
let root_dir = resolve_url("file:///example/").unwrap();
let mut config = Config::new_with_root(root_dir.clone());
config.settings.workspace.enable = Some(false);
config.settings.workspace.enable_paths = None;
assert_eq!(config.enabled_urls(), vec![]);
config.settings.workspace.enable = Some(true);
assert_eq!(config.enabled_urls(), vec![root_dir]);
config.settings.workspace.enable = Some(false);
let root_dir1 = Url::parse("file:///root1/").unwrap();
let root_dir2 = Url::parse("file:///root2/").unwrap();
let root_dir3 = Url::parse("file:///root3/").unwrap();
fn config_get_enabled_paths() {
let mut config = Config::new();
config.workspace_folders = vec![
(
root_dir1.clone(),
Url::parse("file:///root1/").unwrap(),
lsp::WorkspaceFolder {
uri: root_dir1.clone(),
uri: Url::parse("file:///root1/").unwrap(),
name: "1".to_string(),
},
),
(
root_dir2.clone(),
Url::parse("file:///root2/").unwrap(),
lsp::WorkspaceFolder {
uri: root_dir2.clone(),
uri: Url::parse("file:///root2/").unwrap(),
name: "2".to_string(),
},
),
(
root_dir3.clone(),
Url::parse("file:///root3/").unwrap(),
lsp::WorkspaceFolder {
uri: root_dir3.clone(),
uri: Url::parse("file:///root3/").unwrap(),
name: "3".to_string(),
},
),
];
config.set_specifier_settings(
root_dir1.clone(),
Url::parse("file:///root1/").unwrap(),
SpecifierSettings {
enable_paths: Some(vec![
"sub_dir".to_string(),
@ -1178,14 +1127,14 @@ mod tests {
},
);
config.set_specifier_settings(
root_dir2.clone(),
Url::parse("file:///root2/").unwrap(),
SpecifierSettings {
enable_paths: Some(vec!["other.ts".to_string()]),
..Default::default()
},
);
config.set_specifier_settings(
root_dir3.clone(),
Url::parse("file:///root3/").unwrap(),
SpecifierSettings {
enable: Some(true),
..Default::default()
@ -1193,13 +1142,13 @@ mod tests {
);
assert_eq!(
config.enabled_urls(),
config.get_enabled_paths(),
vec![
root_dir1.join("sub_dir").unwrap(),
root_dir1.join("sub_dir/other").unwrap(),
root_dir1.join("test.ts").unwrap(),
root_dir2.join("other.ts").unwrap(),
root_dir3
PathBuf::from("/root1/sub_dir"),
PathBuf::from("/root1/sub_dir/other"),
PathBuf::from("/root1/test.ts"),
PathBuf::from("/root2/other.ts"),
PathBuf::from("/root3/"),
]
);
}
@ -1209,12 +1158,12 @@ mod tests {
let root_uri = resolve_url("file:///root/").unwrap();
let mut config = Config::new_with_root(root_uri.clone());
config.settings.workspace.enable = None;
assert_eq!(config.enabled_urls(), vec![]);
assert!(!config.specifier_enabled(&root_uri));
config.set_config_file(
ConfigFile::new("{}", root_uri.join("deno.json").unwrap()).unwrap(),
);
assert_eq!(config.enabled_urls(), vec![root_uri]);
assert!(config.specifier_enabled(&root_uri));
}
// Regression test for https://github.com/denoland/vscode_deno/issues/917.

52
cli/lsp/documents.rs
View file

@ -803,8 +803,8 @@ impl FileSystemDocuments {
}
pub struct UpdateDocumentConfigOptions<'a> {
pub enabled_urls: Vec<Url>,
pub disabled_urls: Vec<Url>,
pub enabled_paths: Vec<PathBuf>,
pub disabled_paths: Vec<PathBuf>,
pub document_preload_limit: usize,
pub maybe_import_map: Option<Arc<import_map::ImportMap>>,
pub maybe_config_file: Option<&'a ConfigFile>,
@ -1183,7 +1183,7 @@ impl Documents {
pub fn update_config(&mut self, options: UpdateDocumentConfigOptions) {
fn calculate_resolver_config_hash(
enabled_urls: &[Url],
enabled_paths: &[PathBuf],
document_preload_limit: usize,
maybe_import_map: Option<&import_map::ImportMap>,
maybe_jsx_config: Option<&JsxImportSourceConfig>,
@ -1194,9 +1194,9 @@ impl Documents {
hasher.write_hashable(document_preload_limit);
hasher.write_hashable(&{
// ensure these are sorted so the hashing is deterministic
let mut enabled_urls = enabled_urls.to_vec();
enabled_urls.sort_unstable();
enabled_urls
let mut enabled_paths = enabled_paths.to_vec();
enabled_paths.sort_unstable();
enabled_paths
});
if let Some(import_map) = maybe_import_map {
hasher.write_str(&import_map.to_json());
@ -1233,7 +1233,7 @@ impl Documents {
.maybe_config_file
.and_then(|cf| cf.to_maybe_jsx_import_source_config().ok().flatten());
let new_resolver_config_hash = calculate_resolver_config_hash(
&options.enabled_urls,
&options.enabled_paths,
options.document_preload_limit,
options.maybe_import_map.as_deref(),
maybe_jsx_config.as_ref(),
@ -1278,16 +1278,8 @@ impl Documents {
// only refresh the dependencies if the underlying configuration has changed
if self.resolver_config_hash != new_resolver_config_hash {
self.refresh_dependencies(
options
.enabled_urls
.iter()
.filter_map(|url| specifier_to_file_path(url).ok())
.collect(),
options
.disabled_urls
.iter()
.filter_map(|url| specifier_to_file_path(url).ok())
.collect(),
options.enabled_paths,
options.disabled_paths,
options.document_preload_limit,
);
self.resolver_config_hash = new_resolver_config_hash;
@ -1710,14 +1702,18 @@ impl PreloadDocumentFinder {
// initialize the finder with the initial paths
let mut dirs = Vec::with_capacity(options.enabled_paths.len());
for path in options.enabled_paths {
if path.is_dir() {
if is_allowed_root_dir(&path) {
dirs.push(path);
if !finder.disabled_paths.contains(&path)
&& !finder.disabled_globs.matches_path(&path)
{
if path.is_dir() {
if is_allowed_root_dir(&path) {
dirs.push(path);
}
} else {
finder
.pending_entries
.push_back(PendingEntry::SpecifiedRootFile(path));
}
} else {
finder
.pending_entries
.push_back(PendingEntry::SpecifiedRootFile(path));
}
}
for dir in sort_and_remove_non_leaf_dirs(dirs) {
@ -2028,8 +2024,8 @@ console.log(b, "hello deno");
.unwrap();
documents.update_config(UpdateDocumentConfigOptions {
enabled_urls: vec![],
disabled_urls: vec![],
enabled_paths: vec![],
disabled_paths: vec![],
document_preload_limit: 1_000,
maybe_import_map: Some(Arc::new(import_map)),
maybe_config_file: None,
@ -2070,8 +2066,8 @@ console.log(b, "hello deno");
.unwrap();
documents.update_config(UpdateDocumentConfigOptions {
enabled_urls: vec![],
disabled_urls: vec![],
enabled_paths: vec![],
disabled_paths: vec![],
document_preload_limit: 1_000,
maybe_import_map: Some(Arc::new(import_map)),
maybe_config_file: None,

4
cli/lsp/language_server.rs
View file

@ -1353,8 +1353,8 @@ impl Inner {
async fn refresh_documents_config(&mut self) {
self.documents.update_config(UpdateDocumentConfigOptions {
enabled_urls: self.config.enabled_urls(),
disabled_urls: self.config.disabled_urls(),
enabled_paths: self.config.get_enabled_paths(),
disabled_paths: self.config.get_disabled_paths(),
document_preload_limit: self
.config
.workspace_settings()

22
cli/util/path.rs
View file

@ -122,28 +122,6 @@ pub fn specifier_to_file_path(
}
}
/// Attempts to convert a file path to a specifier. By default, uses the Url
/// crate's `from_file_path()` method, but falls back to try and resolve
/// unix-style paths on Windows.
pub fn specifier_from_file_path(
path: &Path,
) -> Result<ModuleSpecifier, AnyError> {
if cfg!(windows) {
match ModuleSpecifier::from_file_path(path) {
Ok(url) => Ok(url),
Err(()) => {
let mut url = ModuleSpecifier::parse("file:///").unwrap();
url.set_path(&path.to_string_lossy());
Ok(url)
}
}
} else {
ModuleSpecifier::from_file_path(path).map_err(|()| {
uri_error(format!("Invalid file path.\n Path: {}", path.display()))
})
}
}
/// `from.make_relative(to)` but with fixes.
pub fn relative_specifier(
from: &ModuleSpecifier,