foster/denoland-deno
1
0
Fork 0
mirror of https://github.com/denoland/deno.git synced 2024-11-29 16:30:56 -05:00
Code Issues Packages 1 Wiki Activity

fix(core): get v8 console from context extra bindings (#17243)

Browse source 
Explicitly get `console` object from V8 instead of relying on `console`
defined on the global object.
This commit is contained in:
Chengzhong Wu 2023-01-07 05:37:42 +08:00 committed by David Sherret
parent ab07129ee7
commit f7613eac84
2 changed files with 8 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

6
core/bindings.rs
View file

@ -133,6 +133,12 @@ pub fn initialize_context<'s>(
// Bind functions to Deno.core.* // Bind functions to Deno.core.*
set_func(scope, core_obj, "callConsole", call_console); set_func(scope, core_obj, "callConsole", call_console);
// Bind v8 console object to Deno.core.console
let extra_binding_obj = context.get_extras_binding_object(scope);
let console_str = v8::String::new(scope, "console").unwrap();
let console_obj = extra_binding_obj.get(scope, console_str.into()).unwrap();
core_obj.set(scope, console_str.into(), console_obj);
// Bind functions to Deno.core.ops.* // Bind functions to Deno.core.ops.*
let ops_obj = v8::Object::new(scope); let ops_obj = v8::Object::new(scope);
let ops_str = v8::String::new(scope, "ops").unwrap(); let ops_str = v8::String::new(scope, "ops").unwrap();

4
runtime/js/99_main.js
View file

@ -399,7 +399,7 @@ delete Intl.v8BreakIterator;
performance.setTimeOrigin(DateNow()); performance.setTimeOrigin(DateNow());
net.setup(runtimeOptions.unstableFlag); net.setup(runtimeOptions.unstableFlag);
const consoleFromV8 = window.console; const consoleFromV8 = window.Deno.core.console;
const wrapConsole = window.__bootstrap.console.wrapConsole; const wrapConsole = window.__bootstrap.console.wrapConsole;
// Remove bootstrapping data from the global scope // Remove bootstrapping data from the global scope
@ -544,7 +544,7 @@ delete Intl.v8BreakIterator;
performance.setTimeOrigin(DateNow()); performance.setTimeOrigin(DateNow());
net.setup(runtimeOptions.unstableFlag); net.setup(runtimeOptions.unstableFlag);
const consoleFromV8 = window.console; const consoleFromV8 = window.Deno.core.console;
const wrapConsole = window.__bootstrap.console.wrapConsole; const wrapConsole = window.__bootstrap.console.wrapConsole;
// Remove bootstrapping data from the global scope // Remove bootstrapping data from the global scope