From f7b08cd962aeaf6f727c2c9f54296a464ea1a839 Mon Sep 17 00:00:00 2001 From: Asher Gomez Date: Fri, 23 Feb 2024 11:17:39 +1100 Subject: [PATCH] chore: fail properly in web platform test (#22549) Having `|| true` means that the job always executes with a success code, even when it really fails. Credit to Bartek for spotting this possible mistake. Towards #22257 --- .github/workflows/wpt_epoch.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/wpt_epoch.yml b/.github/workflows/wpt_epoch.yml index ab4a2ec4d3..cac5c9a466 100644 --- a/.github/workflows/wpt_epoch.yml +++ b/.github/workflows/wpt_epoch.yml @@ -72,7 +72,7 @@ jobs: deno run --unstable --allow-write --allow-read --allow-net \ --allow-env --allow-run --lock=tools/deno.lock.json \ ./tools/wpt.ts run \ - --binary=$(which deno) --quiet --release --no-ignore --json=wpt.json --wptreport=wptreport.json || true + --binary=$(which deno) --quiet --release --no-ignore --json=wpt.json --wptreport=wptreport.json - name: Upload wpt results to wpt.fyi env: