1
0
Fork 0
mirror of https://github.com/denoland/deno.git synced 2024-12-24 08:09:08 -05:00

perf(web): optimize AbortController (#12165)

- Use regular class constructor and symbol "private" attributes
- Lazy init Set of follower signals
This commit is contained in:
Aaron O'Mullan 2021-09-21 17:38:57 +02:00 committed by GitHub
parent 8375f5464b
commit f827b93df4
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23

View file

@ -11,7 +11,6 @@
Boolean,
Set,
SetPrototypeAdd,
SetPrototypeClear,
SetPrototypeDelete,
Symbol,
SymbolToStringTag,
@ -21,13 +20,12 @@
const add = Symbol("add");
const signalAbort = Symbol("signalAbort");
const remove = Symbol("remove");
const aborted = Symbol("aborted");
const abortAlgos = Symbol("abortAlgos");
const illegalConstructorKey = Symbol("illegalConstructorKey");
class AbortSignal extends EventTarget {
#aborted = false;
#abortAlgorithms = new Set();
static abort() {
const signal = new AbortSignal(illegalConstructorKey);
signal[signalAbort]();
@ -35,25 +33,30 @@
}
[add](algorithm) {
SetPrototypeAdd(this.#abortAlgorithms, algorithm);
if (this[abortAlgos] === null) {
this[abortAlgos] = new Set();
}
SetPrototypeAdd(this[abortAlgos], algorithm);
}
[signalAbort]() {
if (this.#aborted) {
if (this[aborted]) {
return;
}
this.#aborted = true;
for (const algorithm of this.#abortAlgorithms) {
this[aborted] = true;
if (this[abortAlgos] !== null) {
for (const algorithm of this[abortAlgos]) {
algorithm();
}
SetPrototypeClear(this.#abortAlgorithms);
this[abortAlgos] = null;
}
const event = new Event("abort");
setIsTrusted(event, true);
this.dispatchEvent(event);
}
[remove](algorithm) {
SetPrototypeDelete(this.#abortAlgorithms, algorithm);
this[abortAlgos] && SetPrototypeDelete(this[abortAlgos], algorithm);
}
constructor(key = null) {
@ -61,11 +64,13 @@
throw new TypeError("Illegal constructor.");
}
super();
this[aborted] = false;
this[abortAlgos] = null;
this[webidl.brand] = webidl.brand;
}
get aborted() {
return Boolean(this.#aborted);
return Boolean(this[aborted]);
}
get [SymbolToStringTag]() {