foster/denoland-deno
1
0
Fork 0
mirror of https://github.com/denoland/deno.git synced 2024-11-21 15:04:11 -05:00
Code Issues Packages 1 Wiki Activity

fix(ext/websocket): change default idleTimeout to 30s (#23985)

Browse source 
Change the default server websocket `idleTimeout` to 30s to work with common Nginx setups which have a default timeout of 60 seconds
This commit is contained in:
Alex Gleason 2024-05-26 00:16:05 -05:00 committed by GitHub
parent 0ef1c774f6
commit f8975a8ecb
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
2 changed files with 3 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
cli/tsc/dts/lib.deno.ns.d.ts vendored
View file

@ -5730,7 +5730,7 @@ declare namespace Deno {
* `pong` within the timeout specified, the connection is deemed * `pong` within the timeout specified, the connection is deemed
* unhealthy and is closed. The `close` and `error` event will be emitted. * unhealthy and is closed. The `close` and `error` event will be emitted.
* *
* The unit is seconds, with a default of 120. * The unit is seconds, with a default of 30.
* Set to `0` to disable timeouts. */ * Set to `0` to disable timeouts. */
idleTimeout?: number; idleTimeout?: number;
} }

3
ext/http/02_websocket.ts
View file

@ -91,7 +91,8 @@ function upgradeWebSocket(request, options = { __proto__: null }) {
const socket = createWebSocketBranded(WebSocket); const socket = createWebSocketBranded(WebSocket);
setEventTargetData(socket); setEventTargetData(socket);
socket[_server] = true; socket[_server] = true;
socket[_idleTimeoutDuration] = options.idleTimeout ?? 120; // Nginx timeout is 60s, so default to a lower number: https://github.com/denoland/deno/pull/23985
socket[_idleTimeoutDuration] = options.idleTimeout ?? 30;
socket[_idleTimeoutTimeout] = null; socket[_idleTimeoutTimeout] = null;
if (inner._wantsUpgrade) { if (inner._wantsUpgrade) {