foster/denoland-deno
1
0
Fork 0
mirror of https://github.com/denoland/deno.git synced 2024-12-26 17:19:06 -05:00
Code Issues Packages 1 Wiki Activity

fix(upgrade): move the file permission check to the beginning of the upgrade process (#13726)

Browse source
This commit is contained in:
mlemesle 2022-02-23 22:11:46 +01:00 committed by GitHub
parent 973fe6dd3a
commit f8b73ab97e
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
1 changed files with 7 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

9
cli/tools/upgrade.rs
View file

@ -23,6 +23,13 @@ static ARCHIVE_NAME: Lazy<String> =
const RELEASE_URL: &str = "https://github.com/denoland/deno/releases";
pub async fn upgrade(upgrade_flags: UpgradeFlags) -> Result<(), AnyError> {
let old_exe_path = std::env::current_exe()?;
let permissions = fs::metadata(&old_exe_path)?.permissions();
if permissions.readonly() {
bail!("You do not have write permission to {:?}", old_exe_path);
}
let mut client_builder = Client::builder();
// If we have been provided a CA Certificate, add it into the HTTP client
@ -114,9 +121,7 @@ pub async fn upgrade(upgrade_flags: UpgradeFlags) -> Result<(), AnyError> {
println!("Deno is upgrading to version {}", &install_version);
let old_exe_path = std::env::current_exe()?;
let new_exe_path = unpack(archive_data, cfg!(windows))?;
let permissions = fs::metadata(&old_exe_path)?.permissions();
fs::set_permissions(&new_exe_path, permissions)?;
check_exe(&new_exe_path)?;