foster/denoland-deno
1
0
Fork 0
mirror of https://github.com/denoland/deno.git synced 2024-12-22 07:14:47 -05:00
Code Issues Packages 1 Wiki Activity

chdir should require --allow-write (#4889)

Browse source
This commit is contained in:
Ryan Dahl 2020-04-24 19:55:33 -04:00 committed by GitHub
parent 1378df3364
commit f8d83361cd
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
2 changed files with 6 additions and 5 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

5
cli/js/lib.deno.ns.d.ts vendored
View file

@ -405,9 +405,6 @@ declare namespace Deno {
export function cwd(): string; export function cwd(): string;
/** /**
* **UNSTABLE**: Currently under evaluation to decide if explicit permission is
* required to change the current working directory.
*
* Change the current working directory to the specified path. * Change the current working directory to the specified path.
* *
* Deno.chdir("/home/userA"); * Deno.chdir("/home/userA");
@ -417,6 +414,8 @@ declare namespace Deno {
* Throws `Deno.errors.NotFound` if directory not found. * Throws `Deno.errors.NotFound` if directory not found.
* Throws `Deno.errors.PermissionDenied` if the user does not have access * Throws `Deno.errors.PermissionDenied` if the user does not have access
* rights * rights
*
* Requires --allow-write.
*/ */
export function chdir(directory: string): void; export function chdir(directory: string): void;

6
cli/ops/fs.rs
View file

@ -245,12 +245,14 @@ struct ChdirArgs {
} }
fn op_chdir( fn op_chdir(
_state: &State, state: &State,
args: Value, args: Value,
_zero_copy: Option<ZeroCopyBuf>, _zero_copy: Option<ZeroCopyBuf>,
) -> Result<JsonOp, OpError> { ) -> Result<JsonOp, OpError> {
let args: ChdirArgs = serde_json::from_value(args)?; let args: ChdirArgs = serde_json::from_value(args)?;
set_current_dir(&args.directory)?; let d = PathBuf::from(&args.directory);
state.check_write(&d)?;
set_current_dir(&d)?;
Ok(JsonOp::Sync(json!({}))) Ok(JsonOp::Sync(json!({})))
} }