foster/denoland-deno
0
0
Fork 0
mirror of https://github.com/denoland/deno.git synced 2024-10-29 08:58:01 -04:00
Code Issues Wiki Activity

Remove impl Send for Isolate and EsIsolate (#4151)

Browse source
This commit is contained in:
Ryan Dahl 2020-02-26 16:10:41 -05:00 committed by GitHub
parent 7fff2d2d1e
commit fb1075da6e
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
2 changed files with 0 additions and 8 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

4
core/es_isolate.rs
View file

@ -82,10 +82,6 @@ impl DerefMut for EsIsolate {
}
}
// TODO(ry): a V8 Isolate cannot actually be moved between threads without the
// use of a Locker, therefore EsIsolate should not implement the `Send` trait.
unsafe impl Send for EsIsolate {}
impl EsIsolate {
pub fn new(
loader: Rc<dyn Loader + Unpin>,

4
core/isolate.rs
View file

@ -182,10 +182,6 @@ pub struct Isolate {
error_handler: Option<Box<IsolateErrorHandleFn>>,
}
// TODO(ry): a V8 Isolate cannot actually be moved between threads without the
// use of a Locker, therefore Isolate should not implement the `Send` trait.
unsafe impl Send for Isolate {}
impl Drop for Isolate {
fn drop(&mut self) {
if let Some(creator) = self.snapshot_creator.take() {