foster/denoland-deno
1
0
Fork 0
mirror of https://github.com/denoland/deno.git synced 2024-11-24 15:19:26 -05:00
Code Issues Packages 1 Wiki Activity

fix(ext/node): internal buffer length in readSync (#26064)

Browse source 
Closes https://github.com/denoland/deno/issues/26054
This commit is contained in:
Satya Rohith 2024-10-08 16:11:32 +05:30 committed by GitHub
parent 2d488e4bfb
commit ff4e682ff9
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
2 changed files with 12 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
ext/node/polyfills/_fs/_fs_read.ts
View file

@ -173,7 +173,7 @@ export function readSync(
validateBuffer(buffer); validateBuffer(buffer);
if (length == null) { if (length == null) {
length = 0; length = buffer.byteLength;
} }
if (typeof offsetOrOpt === "number") { if (typeof offsetOrOpt === "number") {

11
tests/unit_node/fs_test.ts
View file

@ -4,13 +4,16 @@ import { assert, assertEquals, assertThrows } from "@std/assert";
import { join } from "node:path"; import { join } from "node:path";
import { tmpdir } from "node:os"; import { tmpdir } from "node:os";
import { import {
closeSync,
constants, constants,
createWriteStream, createWriteStream,
existsSync, existsSync,
lstatSync, lstatSync,
mkdtempSync, mkdtempSync,
openSync,
promises, promises,
readFileSync, readFileSync,
readSync,
Stats, Stats,
statSync, statSync,
writeFileSync, writeFileSync,
@ -201,3 +204,11 @@ Deno.test(
assertEquals(res, [0, 1, 2, 3, 4, 5]); assertEquals(res, [0, 1, 2, 3, 4, 5]);
}, },
); );
Deno.test("[node/fs] readSync works", () => {
const fd = openSync("tests/testdata/assets/hello.txt", "r");
const buf = new Uint8Array(256);
const bytesRead = readSync(fd!, buf);
assertEquals(bytesRead, 12);
closeSync(fd!);
});