Andreu Botella
760f4c9e24
chore(ext/timers): move ext/timers to ext/web ( #13665 )
2022-02-15 12:17:30 +01:00
Ryan Dahl
a5d204d425
feat: permission prompt by default ( #13650 )
2022-02-12 22:13:21 -05:00
Maxim
65de5fb465
refactor: use Arc instead of making copies of Flags struct ( #13610 )
2022-02-11 14:04:31 -05:00
Bartek Iwańczuk
2fa0096821
compat: support --compat in web workers ( #13629 )
...
Adds another callback to WebWorkerOptions that allows to execute
some modules before actual worker code executes. This allows to set up Node
global using std/node.
2022-02-11 13:41:56 +01:00
Kitson Kelly
2f2c778a07
feat(lsp): support linking to symbols in JSDoc on hover ( #13631 )
...
Closes #13198
2022-02-10 10:08:53 +11:00
Kitson Kelly
773f882e5e
feat(lsp): provide completions from import map if available ( #13624 )
...
Closes #13619
2022-02-10 07:13:50 +11:00
Divy Srivastava
e218d567d5
fix(ext/crypto): support EC p256 private key material in exportKey ( #13547 )
...
Co-authored-by: Luca Casonato <hello@lcas.dev>
2022-02-08 18:48:28 +05:30
Leo Kettmeir
4799aaac15
refactor: factor out CDP message types ( #13551 )
2022-02-07 17:05:49 +01:00
Kitson Kelly
9c7ed1c98b
fix(lsp): op_exists handles bad specifiers ( #13612 )
...
Fixes: #13611
2022-02-07 10:39:07 +11:00
Bartek Iwańczuk
d0dd838521
fix(compat): ESM resolver for package subpath ( #13599 )
2022-02-07 00:02:52 +01:00
Zach
a7850d7fe6
fix(ext/console): fix uncaught TypeError in css styling ( #13567 )
...
When using css coloring in the console, non-color values should be ignored rather than throw exceptions.
Fixes #13469
2022-02-06 19:00:06 +09:00
David Sherret
8cc9a9350b
fix(lsp): do not panic getting root_uri to auto discover configuration file ( #13603 )
2022-02-05 17:41:15 -05:00
Leo Kettmeir
592b1fb911
chore: update clap_complete to 3.0.5 ( #13597 )
2022-02-05 16:22:15 +01:00
Bartek Iwańczuk
82284d8052
chore: forward v1.18.2 to main ( #13595 )
2022-02-04 21:44:38 +01:00
Leo Kettmeir
2f438f4106
feat(ext/console): better circular information in object inspection ( #13555 )
2022-02-04 21:10:47 +01:00
Kitson Kelly
af5a373e00
feat(lsp): add redirect diagnostic and quick fix ( #13580 )
...
Ref: #12864
2022-02-04 18:14:57 +11:00
Luca Casonato
681c3be18d
fix: don't crash when $HOME is a relative path ( #13581 )
...
Absolutize the cache/home dir before use in DenoDir.
2022-02-03 14:08:17 +01:00
David Sherret
ed3086e4b1
refactor(lsp): remove circular dependency between LanguageServer and DiagnosticsServer ( #13577 )
2022-02-02 18:02:59 -05:00
Kitson Kelly
de5a4a1757
fix(cli): handle local files with query params on emit ( #13568 )
...
Fixes #13562
2022-02-03 06:48:54 +11:00
Bartek Iwańczuk
975e55d524
chore: upgrade crates ( #13560 )
2022-02-02 19:24:24 +01:00
David Sherret
37aba8f754
perf(lsp): cancellable TS diagnostics ( #13565 )
2022-02-02 09:25:22 -05:00
Leo Kettmeir
3a5ddeb03f
fix(cli/dts/webgpu): make GPUBlendComponent properties optional ( #13574 )
2022-02-02 14:38:01 +01:00
Kitson Kelly
26f5c223df
fix(lsp): properly display x-deno-warning with redirects ( #13554 )
...
Fixes: #13472
2022-02-02 13:04:26 +11:00
Kitson Kelly
7d356250e8
refactor: integrate deno_graph breaking changes ( #13495 )
...
Co-authored-by: Bartek Iwańczuk <biwanczuk@gmail.com>
2022-02-01 09:33:57 +11:00
Zheyu Zhang
5490cfed20
feat(cli): add "--no-clear-screen" flag ( #13454 )
...
This commit adds "--no-clear-screen" flag which can be used
with "--watch" flag to disable clearing of terminal screen on
each file change.
2022-01-31 17:39:39 +01:00
Yosi Pramajaya
3e566bb457
feat(ext/net): Add Conn.setNoDelay and Conn.setKeepAlive ( #13103 )
2022-01-31 16:36:54 +01:00
Bartek Iwańczuk
b7b6b9c9e5
Revert "refactor: factor out CDP message types ( #13501 )" ( #13540 )
...
This reverts commit 382a978859
2022-01-31 14:00:18 +01:00
Kitson Kelly
68c8c66b0f
fix(cli): handle extensionless imports better ( #13548 )
...
Fixes #13526
2022-01-31 20:32:49 +11:00
Yoshiya Hinosawa
49a0db0d2a
feat(unstable): add Deno.getUid ( #13496 )
2022-01-31 14:44:19 +09:00
Yoshiya Hinosawa
245f69256b
feat(runtime): stabilize addSignalListener API ( #13438 )
2022-01-31 14:16:39 +09:00
Divy Srivastava
efa02ffa2a
fix(ext/crypto): enforce 128bits tagLength for AES-GCM decryption ( #13536 )
2022-01-30 18:42:29 +05:30
David Sherret
a2e4fa471b
fix(lsp): regression where certain diagnostics were showing for disabled files ( #13530 )
2022-01-29 17:50:15 -05:00
Bartek Iwańczuk
5cf23176dc
chore: forward v1.18.1 to main ( #13514 )
2022-01-27 18:52:34 +01:00
Leo Kettmeir
382a978859
refactor: factor out CDP message types ( #13501 )
2022-01-27 15:09:47 +01:00
Yoshiya Hinosawa
380ebbd6d5
docs: fix markdown error in sleepSync jsdoc ( #13492 )
2022-01-26 18:23:45 +09:00
Luca Casonato
b53997273d
feat(test): better errors for resource sanitizer ( #13296 )
...
This commit makes the errors produced from the resource sanitizer much
more human readable. It does this by using real words rather than our
"resource names" when referring to resources, and by giving helpful
hints on how to clean up each of the resources.
2022-01-25 17:03:38 +01:00
David Sherret
d4dd9ae4cf
refactor(lsp): remove RwLock on Config ( #13485 )
2022-01-25 10:30:38 -05:00
David Sherret
0e12acc6ff
refactor(lsp): Documents - combine duplicate exists methods ( #13479 )
2022-01-25 09:21:59 -05:00
David Sherret
2f72c44e1d
fix(lsp): independent diagnostic publishing should include all diagnostic sources on each publish ( #13483 )
2022-01-24 18:04:24 -05:00
Aaron O'Mullan
bd5d445da9
chore: re-enable wgpu_sync ( #13453 )
2022-01-24 23:47:05 +01:00
David Sherret
bc8de78da3
perf(lsp): independent diagnostic source publishes ( #13427 )
2022-01-24 15:30:01 -05:00
Bartek Iwańczuk
23d2b34d4b
tests: Add inspector tests for "Memory" and "Profile" tabs ( #13476 )
2022-01-24 16:07:08 +01:00
Yoshiya Hinosawa
d08da94233
feat(unstable): add Deno.networkInterfaces ( #13475 )
2022-01-24 18:39:28 +09:00
Kitson Kelly
1a3983a538
perf(lsp): improve some tsc op hot paths ( #13473 )
2022-01-24 19:01:33 +11:00
Kitson Kelly
3ec248cff8
fix(lsp): respect DENO_CERT and other options related to TLS certs ( #13467 )
...
Fixes #13437
2022-01-24 11:27:52 +11:00
Divy Srivastava
2ea535c8c1
1.18.0
2022-01-20 21:49:30 +05:30
Divy Srivastava
16776c9ade
chore: bump crate version for 0.18.0 ( #13441 )
2022-01-20 20:50:39 +05:30
Aaron O'Mullan
3ab68bd0a2
revert( #13402 ): experiment: wgpu sync ( #13439 )
2022-01-20 15:23:53 +01:00
Yoshiya Hinosawa
4c1053ad33
chore: update copyright year ( #13434 )
2022-01-20 16:10:16 +09:00
Yoshiya Hinosawa
ee51c3ddd9
fix(cli/dts): add NotSupported error type ( #13432 )
2022-01-20 12:29:37 +09:00
David Sherret
1ec07368b4
fix(fmt): markdown formatting should not remove backslashed backslash at start of paragraph ( #13429 )
2022-01-20 01:04:33 +01:00
David Sherret
f73a5fbc89
refactor(lsp): reduce data stored in StateSnapshot ( #13426 )
2022-01-19 17:10:14 -05:00
Kitson Kelly
6cf05220e3
fix(lsp): better handling of registry config errors ( #13418 )
...
Fixes: #13383
Fixes: denoland/vscode_deno#609
2022-01-20 08:05:19 +11:00
David Sherret
1cece36fa5
refactor(lsp): store the LspUrlMap's state inside a mutex ( #13416 )
2022-01-19 11:38:40 -05:00
Aaron O'Mullan
2ab21dafa7
experiment: wgpu sync ( #13402 )
2022-01-19 13:38:51 +01:00
Sean Michael Wykes
9139985180
feat(ext/crypto): implement pkcs8/JWK for P-384 curves ( #13154 )
2022-01-19 12:14:35 +05:30
Sean Michael Wykes
77e58fe7f9
feat(ext/crypto): implement pkcs8/spki/jwk exportKey for ECDSA and ECDH ( #13104 )
2022-01-19 09:08:35 +05:30
David Sherret
b3545dd447
refactor(lsp): store assets behind a mutex ( #13414 )
2022-01-18 16:28:47 -05:00
David Sherret
0f3a53e5d4
feat: stabilize test steps API ( #13400 )
2022-01-18 15:02:56 -05:00
Ryan Dahl
ce52bfc59c
Add LSP benchmark mimicking the one on quick-lint-js ( #13365 )
2022-01-18 06:58:50 -05:00
Ryan Dahl
39ea4abff4
feat: auto-discover config file ( #13313 )
2022-01-17 20:10:17 -05:00
Bartek Iwańczuk
b10563cb20
fix(runtime): don't crash when window is deleted ( #13392 )
...
This commit fixes an error when user deletes "window" global JS
variable. Instead of relying on "window" or "globalThis" to dispatch
"load" and "unload" events, we are default to global scope of the
worker.
2022-01-18 00:13:14 +01:00
Bartek Iwańczuk
bc666e42a8
fix(ext/console): don't depend on globalThis present ( #13387 )
2022-01-17 23:23:49 +01:00
David Sherret
1ab5dea367
refactor(lsp): remove performance from StateSnapshot ( #13403 )
2022-01-17 17:09:43 -05:00
Ryan Dahl
3595f37b07
refactor: simplify how LSP deals with config file specifier ( #13401 )
2022-01-17 14:45:05 -05:00
Andreu Botella
76c7b9abf9
fix(tsc): Add typings for Intl.ListFormat ( #13301 )
...
V8 has supported `Intl.ListFormat` since version 7.2, but TypeScript doesn't
have typings for it yet. This PR manually adds those typings, copying them from
microsoft/TypeScript#47254 .
2022-01-17 06:50:10 +01:00
Andreu Botella
9def44979a
fix(cli): Don't strip shebangs from modules ( #13220 )
...
Deno's module loader currently strips a shebang if a module file
starts with one. However, this is no longer necessary, since there is
a stage-3 TC39 that adds support for shebangs (or "hashbangs") to the
language (https://github.com/tc39/proposal-hashbang ), and V8, `tsc`
and `swc` all support it.
Furthermore, stripping shebangs causes a correctness bug with JSON
modules, since a JSON file with a shebang should not parse as a JSON
module, yet it does with this stripping. This change fixes this.
2022-01-16 16:48:32 +01:00
David Sherret
ad224f53c7
chore: upgrade to rust 1.58 ( #13377 )
2022-01-15 07:10:12 +01:00
David Sherret
903cb48fe9
refactor(installer): refactor installer code to be more testable ( #13374 )
2022-01-14 13:23:47 -05:00
Bartek Iwańczuk
dc58063d00
test: type check lib.deno_core.d.ts ( #13356 )
2022-01-14 19:05:16 +01:00
Leo Kettmeir
e650165e80
chore: upgrade clap to v3 ( #13266 )
2022-01-14 17:38:17 +01:00
Tomofumi Chiba
9e37fd1db6
fix(cli): fix deno install --prompt ( #13349 )
2022-01-14 09:59:32 -05:00
Divy Srivastava
919ded1a0b
feat(ext/crypto): implement AES-GCM decryption ( #13319 )
2022-01-14 14:18:53 +05:30
David Sherret
eda6e58520
refactor: upgrade to import_map v0.6 ( #13368 )
2022-01-13 18:17:56 -05:00
Bartek Iwańczuk
9975ede773
chore: forward v1.17.3 to main ( #13364 )
2022-01-13 20:47:42 +01:00
David Sherret
f12164646b
refactor: move transpiling to deno_ast ( #13332 )
2022-01-13 11:58:00 -05:00
Ryan Dahl
282c235ba1
chore: rename cli/bench/fixtures to cli/bench/testdata ( #13363 )
2022-01-13 16:25:20 +01:00
juju
50e8ab8a86
feat(cli): add ignore directives to bundled code ( #13309 )
...
This commit adds lint and fmt ignore directives to bundled
code as well as a comment stating that the code was bundled
and shouldn't be edited manually.
2022-01-12 13:05:06 +01:00
DjDeveloper
62291e9b0e
feat(ext/ffi): UnsafeFnPointer API ( #13340 )
2022-01-12 12:38:26 +01:00
Bartek Iwańczuk
13751d9de6
fix(coverage): merge coverage ranges ( #13334 )
...
Covered ranges were not merged and thus it appeared that some lines
might be uncovered. To fix this I used "v8-coverage" that takes care
of merging the ranges properly. With this change, coverage collected
from a file by multiple entrypoints is now correctly calculated.
I ended up forking https://github.com/demurgos/v8-coverage and adding
"cli/tools/coverage/merge.rs" and "cli/tools/coverage/range_tree.rs".
2022-01-11 21:17:25 +01:00
DjDeveloper
a7ea93b978
fix(ext/ffi): pointer type can accept null ( #13335 )
2022-01-11 15:01:52 +05:30
DjDeveloper
5680d33dd9
feat(ext/ffi): support alias names for symbol definitions ( #13090 )
2022-01-11 07:21:16 +01:00
Sean Michael Wykes
91f6c5fc7e
feat(ext/crypto): implement AES-KW for wrapKey/unwrapKey ( #13286 )
2022-01-11 10:14:47 +05:30
Rabin Gaire
605b8db8f6
cli(compile): fix output flag behaviour on compile command ( #13299 )
2022-01-10 23:24:39 -05:00
evan
b66afa2518
feat(cli, runtime): compress snapshots ( #13320 )
2022-01-10 15:51:23 -08:00
Bartek Iwańczuk
a3b3a792b5
fix(coverage): don't type check ( #13324 )
...
This commit changes "deno coverage" command not to type check.
Instead of relying on infrastructure for module loading in "deno run";
the code now directly reaches into cache for original and transpiled
sources. In case sources are not available the error is returned to the
user, suggesting to first run "deno test --coverage" command.
2022-01-10 17:36:58 +01:00
Divy Srivastava
d8e96d2742
feat(ext/ffi): infer symbol types ( #13221 )
...
Co-authored-by: sinclairzx81 <sinclairzx81@users.noreply.github.com>
2022-01-10 21:03:25 +05:30
David Sherret
994ac6d49b
docs: update writeSync docs to refer to writeAllSync in deno.land/std instead of Deno.writeAllSync ( #13314 )
2022-01-10 09:22:41 -05:00
David Sherret
ea86c0818a
fix: install shim with --allow-all should not output each permission individually ( #13325 )
2022-01-10 09:22:03 -05:00
Rodney van den Velden
c487b7ed54
fix: expose "Deno.memoryUsage()" in worker context ( #13293 )
2022-01-09 23:42:14 +01:00
Bartek Iwańczuk
bd53567acf
test: add inspector test with ts files ( #13312 )
2022-01-09 17:44:36 +01:00
Ryan Dahl
1fb5858009
chore: update copyright to 2022 ( #13306 )
...
Co-authored-by: Erfan Safari <erfanshield@outlook.com>
2022-01-07 22:09:52 -05:00
Kitson Kelly
57bfa87b2c
feat(lsp): provide registry details on hover if present ( #13294 )
...
Closes: #13272
2022-01-07 11:27:13 +11:00
Leo Kettmeir
2067820714
feat(ext/websocket): server automatically handle ping/pong for incoming WebSocket ( #13172 )
2022-01-06 17:41:16 +01:00
Bartek Iwańczuk
46f2ff1205
chore: forward 1.17.2 to main ( #13295 )
2022-01-06 13:20:42 +01:00
Leo Kettmeir
c40419b55b
feat(ext/websocket): add header support to WebSocketStream ( #11887 )
2022-01-05 17:41:44 +01:00
Divy Srivastava
c74eb7a889
feat(ext/crypto): implement AES-GCM encryption ( #13119 )
2022-01-05 20:42:30 +05:30
Sean Michael Wykes
c4a0a43ce8
fix(ext/crypto) - exportKey JWK for AES/HMAC must use base64url ( #13264 )
...
Co-authored-by: Divy Srivastava <dj.srivastava23@gmail.com>
2022-01-05 01:00:37 +01:00
Leo Kettmeir
80bf2828c6
fix: support mts, cjs & cts files for deno test & deno fmt ( #13274 )
2022-01-05 00:46:34 +01:00
David Sherret
19c8cd3a45
fix: upgrade swc_ecmascript to 0.103 ( #13284 )
2022-01-04 17:02:56 -05:00
Leo Kettmeir
b46da66056
fix(signals): prevent panic when listening to forbidden signals ( #13273 )
2022-01-04 21:55:06 +01:00
Kitson Kelly
01ff7a8784
fix(lsp): handle repeating patterns in registry correctly ( #13275 )
2022-01-04 17:42:33 +11:00
VishnuJin
d9b130410b
feat(compat) preload Node.js built-in modules in global vars REPL ( #13127 )
...
This commit adds preloading of built-in Node.js modules in
the REPL if running with "deno repl --compat --unstable".
2022-01-03 20:10:17 +01:00
Sean Michael Wykes
340764adec
fix(ext/crypto): use forgiving base64 encoding for JWK ( #13240 )
...
Implements "forgiving" in JWK decode passing suitable config to base64::decode_config
2022-01-03 17:54:45 +05:30
Sean Michael Wykes
9a42d65fc7
feat(ext/crypto): support AES-CTR encrypt/decrypt ( #13177 )
...
Fixes #13201 .
2022-01-03 12:27:28 +01:00
Bartek Iwańczuk
a721c34c19
chore: update std submodule to efa94f2 ( #13260 )
2022-01-02 14:04:40 +01:00
Kitson Kelly
2e72893fa2
fix(lsp): better handling of folders in registry completions ( #13250 )
2022-01-02 16:27:19 +11:00
Kitson Kelly
0ae46a975c
fix(lsp): properly generate data URLs for completion items ( #13246 )
2022-01-02 16:25:42 +11:00
Steven Guerrero
39a6c94071
feat(test): Add support for "deno test --compat" ( #13235 )
2021-12-30 17:18:30 +01:00
Bartek Iwańczuk
1adf8ee545
fix(core): inspector works if no "Runtime.runIfWaitingForDebugger" message is sent ( #13191 )
...
This commit changes flow in inspector code to no longer require
"Runtime.runIfWaitingForDebugger" message to complete a handshake.
Even though clients like Chrome DevTools always send this message on startup,
it is against the protocol to require this message to start an inspector
session.
Instead "Runtime.runIfWaitingForDebugger" is required only when running with
"--inspect-brk" flag, which matches behavior of Node.js.
2021-12-30 16:47:58 +01:00
Leo Kettmeir
167982be9e
feat: output cause on JS runtime errors ( #13209 )
2021-12-29 19:34:13 +01:00
Aaron O'Mullan
42777f2541
cleanup(cli/lsp): use op Extensions ( #13225 )
2021-12-29 15:22:00 +01:00
Aaron O'Mullan
4208199490
cleanup(cli): use op Extensions ( #13223 )
...
Enabling op-middleware for overrides in lieu of imperative .replace_op() etc...
Impacts #13219 , #12938 , #13122
2021-12-29 14:30:08 +01:00
Kitson Kelly
6d017d42aa
fix(lsp): add code lens for tests just using named functions ( #13218 )
...
Fixes: #13216
2021-12-29 14:00:24 +11:00
David Sherret
7ebbda7fd7
fix(coverage): use only string byte indexes and 0-indexed line numbers ( #13190 )
2021-12-23 20:02:54 -05:00
Kitson Kelly
37dbe5249c
fix(cli): include JSON modules in bundle ( #13188 )
...
Fixes #13150
2021-12-24 09:38:20 +11:00
Zach
de2df20d57
fix(ext/console): map basic css color keywords to ansi ( #13175 )
2021-12-23 13:06:24 +01:00
Bartek Iwańczuk
9391ba1098
chore: merge v1.17.1 into main ( #13184 )
2021-12-22 22:20:17 +01:00
Kitson Kelly
8547a37132
chore: update deno_graph and deno_doc ( #13173 )
2021-12-22 14:25:06 +01:00
David Sherret
ac06797fa8
chore(tests): remove pty_complete_imports test for deleting the cwd ( #13164 )
2021-12-21 12:21:07 -05:00
Bartek Iwańczuk
aca41a472a
refactor: Cleanup core/modules.rs ( #13149 )
2021-12-21 15:53:46 +01:00
Bartek Iwańczuk
907cef563e
refactor: cleanup cli/main.rs ( #13160 )
2021-12-21 15:49:27 +01:00
Kitson Kelly
b5fdfb9d25
feat(lsp): supply accept header when fetching registry config ( #13159 )
...
Closes #13153
2021-12-21 13:40:22 +11:00
Bartek Iwańczuk
1eb78731eb
refactor: Use dedicated flags structures ( #13148 )
2021-12-20 22:29:02 +01:00
Luca Casonato
17d81ad2ef
chore: add custom panic message ( #13145 )
2021-12-20 14:49:05 +01:00
Jesper van den Ende
0888ba7a8d
feat(lsp): add code lens for debugging tests ( #13138 )
...
Closes: #13130
2021-12-20 16:00:38 +11:00
Divy Srivastava
6de53b631f
refactor: use once_cell instead of lazy_static ( #13135 )
2021-12-18 16:14:42 -05:00
Bartek Iwańczuk
3db18bf9e6
refactor(repl): factor out ReplEditor and ReplSession ( #13131 )
2021-12-18 02:18:17 +01:00
Bartek Iwańczuk
f3cd9a94b5
fix: inspector prompts ( #13123 )
...
This commit fixes prompts printed to the terminal when
running with "--inspect" or "--inspect-brk" flags.
When debugger disconnects error is no longer printed as
users don't care about the reason debugger did disconnect.
A message suggesting to go to "chrome://inspect" is printed
if debugger is active.
Additionally and information that process is waiting for
debugger to connect is printed if running with "--inspect-brk"
flag.
2021-12-17 18:43:25 +01:00
Nayeem Rahman
ca1fbdd636
fix(cli/tools/coverage): Split sources by char index ( #13114 )
2021-12-17 17:17:35 +01:00
David Sherret
5d8baf054e
fix(repl): support assertions on import & export declarations ( #13121 )
2021-12-17 11:00:27 -05:00
Bartek Iwańczuk
e133d37e37
chore: add codeblocks for lib.deno.shared_globals.d.ts ( #13117 )
2021-12-17 02:36:03 +01:00
Bartek Iwańczuk
5f11f87495
v1.17.0
2021-12-16 19:24:16 +01:00
Bartek Iwańczuk
e0cba6b19b
chore: release crates for v1.17.0 ( #13112 )
2021-12-16 18:51:23 +01:00
Sean Michael Wykes
60faf7a0ed
feat(ext/crypto): support importing ECSDA and ECDH ( #13088 )
...
Co-authored-by: Luca Casonato <hello@lcas.dev>
2021-12-16 17:28:43 +01:00
Andreu Botella
8efe829fca
feat(fetch): support abort reasons in fetch ( #13106 )
2021-12-16 12:58:24 +01:00
Andreu Botella
01a6b66034
feat: support abort reasons in Deno APIs and WebSocketStream ( #13066 )
2021-12-16 12:57:26 +01:00
Nayeem Rahman
9ffc7edc23
refactor(cli): use GraphData for check and emit ( #12960 )
2021-12-16 21:45:41 +11:00
Kitson Kelly
e28fb70aee
fix(lsp): provide diagnostics for import assertions ( #13105 )
...
Fixes: #13099
2021-12-16 14:53:17 +11:00
Jesper van den Ende
0f53b82cd2
fix(test): wait for inspector session in side modules ( #13065 )
...
This commit fixes inspector integration with "deno test" subcommand
by waiting for inspector sessions to connect if "--inspect-brk" flag
is passed.
Co-authored-by: Bartek Iwańczuk <biwanczuk@gmail.com>
2021-12-16 00:38:27 +01:00
Jesper van den Ende
5a3ded6611
feat(watch): support watching external files ( #13087 )
2021-12-15 16:04:43 -05:00
Bartek Iwańczuk
d8e7e3fbe3
chore: update cli/Cargo.toml ( #13096 )
2021-12-15 20:57:43 +01:00
David Sherret
6c324acf23
feat: REPL import specifier auto-completions ( #13078 )
2021-12-15 13:23:43 -05:00
Bartek Iwańczuk
a1f0796fcc
feat: Add support for import assertions and JSON modules ( #12866 )
...
This commit adds proper support for import assertions and JSON modules.
Implementation of "core/modules.rs" was changed to account for multiple possible
module types, instead of always assuming that the code is an "ES module". In
effect "ModuleMap" now has knowledge about each modules' type (stored via
"ModuleType" enum). Module loading pipeline now stores information about
expected module type for each request and validates that expected type matches
discovered module type based on file's "MediaType".
Relevant tests were added to "core/modules.rs" and integration tests,
additionally multiple WPT tests were enabled.
There are still some rough edges in the implementation and not all WPT were
enabled, due to:
a) unclear BOM handling in source code by "FileFetcher"
b) design limitation of Deno's "FileFetcher" that doesn't download the same
module multiple times in a single run
Co-authored-by: Kitson Kelly <me@kitsonkelly.com>
2021-12-15 19:22:36 +01:00
Elias Sjögreen
ee49cce726
feat(ext/ffi): implement UnsafePointer and UnsafePointerView ( #12828 )
2021-12-15 15:41:49 +01:00
Ben Noordhuis
4d176b7b7c
fix(ext/net): make unix and tcp identical on close ( #13075 )
...
std/http/server knows how to handle "Listener has been closed"
exceptions but not "operation canceled" errors.
Make "unix" listen sockets throw the same exception as "tcp" listen
sockets when the socket is closed and has a pending accept operation.
There is still a discrepancy when multiple accept requests are posted
but that's probably a less visible issue and something for another day.
Fixes #13033
2021-12-14 23:27:04 +01:00
Kitson Kelly
e8d7b430ce
chore: updates to support deno_graph API changes ( #13080 )
2021-12-15 07:39:20 +11:00
Luca Casonato
b220a58d1a
feat(ext/crypto): support exporting RSA JWKs ( #13081 )
...
This commit adds support for exporting RSA JWKs in the Web Crypto API.
It also does some minor fixes for RSA JWK imports.
Co-authored-by: Sean Michael Wykes <sean.wykes@nascent.com.br>
2021-12-14 17:02:14 +01:00
David Sherret
c9d32e0581
fix(lsp): handle import specifier not having a trailing quote ( #13074 )
...
* fix(lsp): handle import specifier not having a trailing quote
* clean up
* Add test.
2021-12-13 16:28:35 -05:00
Kitson Kelly
a54fc7a129
feat(lsp): improve registry completion suggestions ( #13023 )
...
Resolves #10051
2021-12-14 06:24:11 +11:00
Yoshiya Hinosawa
308813ae29
fix(ext/web): set location undefined when --location is not specified ( #13046 )
2021-12-14 00:35:59 +09:00
Jesper van den Ende
a2b4d13540
docs: Fix typo in EmitOptions ( #13062 )
2021-12-13 13:26:03 +01:00
Bartek Iwańczuk
0dec9b4381
fix: op_set_exit_code ( #13034 )
...
Fixes "op_set_exit_code" by sharing a single "Arc" between
all workers (via "op state") instead of having a "global" value stored in
"deno_runtime" crate. As a consequence setting an exit code is always
scoped to a tree of workers, instead of being overridable if there are
multiple worker tree (like in "deno test --jobs" subcommand).
Refactored "cli/main.rs" functions to return "Result<i32, AnyError>" instead
of "Result<(), AnyError>" so they can return exit code.
2021-12-11 15:56:45 +01:00
Bartek Iwańczuk
13d7d57227
feat(watcher): clear screen on each restart ( #12613 )
...
This commit adds automatic clearing of terminal screen after
restarting execution on file change.
2021-12-11 01:12:25 +01:00
VishnuJin
2bdb528eb8
feat(repl): add --unsafe-ignore-certificate-errors flag ( #13045 )
2021-12-10 15:47:55 +01:00
Luca Casonato
6f8f1cc244
tests: deflake crypto InvalidIntializationVector ( #13040 )
...
Use fixed data that is known to error as the test intends.
2021-12-10 11:47:21 +01:00
David Sherret
f530189c50
fix(watch): mitigate race condition between file write by other process and watch read ( #13038 )
2021-12-09 20:24:37 -05:00
Kitson Kelly
616ff1d482
chore: place @deprecated tag after documentation block ( #13037 )
2021-12-10 11:05:50 +11:00
Kitson Kelly
345f0fbe5c
feat(cli): update to TypeScript 4.5 ( #12410 )
...
Co-authored-by: Bartek Iwańczuk <biwanczuk@gmail.com>
2021-12-10 09:12:21 +11:00
Kitson Kelly
2347e60934
feat(lsp): registry suggestion cache respects cache headers ( #13010 )
...
Fixes #9931
2021-12-09 22:16:17 +11:00
Yoshiya Hinosawa
69ad5f0e78
feat(ext/timers): add refTimer, unrefTimer API ( #12953 )
2021-12-09 17:00:55 +09:00
David Sherret
1507b8c984
fix: upgrade swc fixing many bundling and --no-check bugs ( #13025 )
2021-12-08 19:12:14 -05:00
WenheLI
b51b0c834b
feat(cli): use deno fmt for lock and coverage files ( #13018 )
2021-12-07 19:21:04 -05:00
Yoshiya Hinosawa
5c0636888c
fix(ext/timers): fix flakiness of httpConnAutoCloseDelayedOnUpgrade test ( #13017 )
2021-12-08 02:50:35 +09:00
Andreu Botella
33da15ae5a
refactor(timers): refactor timers to use one async op per timer ( #12862 )
...
This change also makes the timers implementation closer to the spec, and
sets up the stage to implement AbortSignal.timeout() (whatwg/dom#1032).
Fixes #8965
Fixes #10974
Fixes #11398
2021-12-07 13:39:58 +01:00
Bartek Iwańczuk
5027826a64
build: pin dependencies in cli crate ( #12967 )
2021-12-07 01:43:09 +01:00
Ryan Dahl
a2f1357fe8
chore: upgrade to rustls 0.20 ( #12488 )
...
Co-authored-by: Bartek Iwańczuk <biwanczuk@gmail.com>
Co-authored-by: Bert Belder <bertbelder@gmail.com>
2021-12-07 00:48:11 +01:00
Divy Srivastava
d31378726e
feat(ext/crypto): implement unwrapKey ( #12539 )
2021-12-05 04:55:11 +01:00
Bartek Iwańczuk
c59f90d01f
chore: upgrade to Rust 1.57.0 ( #12968 )
2021-12-04 14:19:06 +01:00
Luca Casonato
72e9720e91
chore: merge v1.16.4 into main ( #12984 )
2021-12-04 01:26:54 +01:00
Ryan Dahl
084caffc08
refactor: cli doesn't need to depend on deno_tls ( #12952 )
...
also move create_http_client to deno_fetch
2021-12-01 11:13:11 -05:00
KnorpelSenf
4c36fa1fdf
chore: Fix typo in no-pending-ops error message ( #12948 )
2021-12-01 15:22:11 +01:00
Andreu Botella
9a10668694
fix(test): Improve reliability of deno test's op sanitizer with timers ( #12934 )
...
Although not easy to replicate in the wild, the `deno test` op sanitizer
can fail when there are intervals that started before a test runs, since
the op sanitizer can end up running in the time between the timer op for
an interval's run resolves and the op for the next run starts.
This change fixes that by adding a new macrotask callback that will run
after the timer macrotask queue has drained. This ensures that there is
a timer op if there are any timers which are unresolved by the time the
op sanitizer runs.
2021-11-30 01:27:30 +01:00
Kitson Kelly
18a63dd977
feat: add --no-check=remote flag ( #12766 )
...
Closes #11970
2021-11-30 09:23:30 +11:00
Zheyu Zhang
bd989143e1
refactor(cli): simplify lint/format resolver logic ( #12898 )
2021-11-29 09:17:57 -05:00
Andreu Botella
4a13c320d7
fix(workers): Make worker.terminate() not immediately kill the isolate ( #12831 )
...
Due to a bug in V8, terminating an isolate while a module with top-level
await is being evaluated would crash the process. This change makes it
so calling `worker.terminate()` will signal the worker to terminate at
the next iteration of the event loop, and it schedules a proper
termination of the worker's isolate after 2 seconds.
2021-11-29 13:37:44 +01:00
Bartek Iwańczuk
5178e093ed
Revert "fix(test): Improve reliability of deno test's op sanitizer with timers ( #12908 )" ( #12929 )
...
This reverts commit d335343a79
2021-11-29 12:07:47 +01:00
Michael Busby
6c09e02304
feat(ext/net): enable sending to broadcast address ( #12860 )
...
You can now send UDP datagrams to the broadcast address.
2021-11-29 11:14:46 +01:00
Andreu Botella
d335343a79
fix(test): Improve reliability of deno test's op sanitizer with timers ( #12908 )
...
Although not easy to replicate in the wild, the `deno test` op sanitizer
can fail when there are intervals that started before a test runs, since
the op sanitizer can end up running in the time between the timer op for
an interval's run resolves and the op for the next run starts.
This change fixes that by adding a new macrotask callback that will run
after the timer macrotask queue has drained. This ensures that there is
a timer op if there are any timers which are unresolved by the time the
op sanitizer runs.
2021-11-28 16:40:38 +01:00
Andreu Botella
1974eb1021
fix(websocket): bad rid on WebSocketStream abort( #12913 )
...
Fix a bad resource ID error when aborting a WebSocketStream immediately
after its creation.
2021-11-28 12:25:49 +01:00
Ben Noordhuis
993a1dd41a
feat(runtime): add op_set_exit_code ( #12911 )
...
Set the exit code to use if none is provided to Deno.exit(), or when
Deno exits naturally.
Needed for process.exitCode Node compat. Paves the way for #12888 .
2021-11-28 00:45:38 +01:00
Yury Selivanov
1d3f734e18
feat(ext/net): ALPN support in Deno.connectTls() ( #12786 )
2021-11-26 19:59:53 +01:00
Andreu Botella
d763633781
feat(etc/fetch): Support WebAssembly.instantiateStreaming for file fetches ( #12901 )
...
Fetching of local files, added in #12545 , returns a response with no
headers, including the `Content-Type` header. This currently makes it
not work with the WebAssembly streaming APIs, which require the response
to have a content type of `application/wasm`.
Since the only way to obtain a `Response` object with a non-empty `url`
field is via `fetch()`, this change changes the content type requirement
to only apply to responses whose url has the `file:` scheme.
2021-11-26 19:52:41 +11:00
David Sherret
6a780543a4
refactor(repl): move rustyline sync channel communication into struct ( #12900 )
2021-11-25 14:05:12 -05:00
Ben Noordhuis
47cf7b0b2e
fix(cli): fix slow test, unbreak ci ( #12897 )
...
Reduce the number of iterations from 1,024 to 128.
On my big bruiser of a desktop machine it already takes up close to a
minute to complete when nothing else is running so no way it's going to
finish in the allotted time on the CI.
The fact that the test used to pass may be indicative of a performance
regression somewhere but it's not clear to me when or where that would
have been introduced.
Fixes #12887 .
2021-11-25 14:25:22 +01:00
Bartek Iwańczuk
1193d46485
tests: add 'await' to all invocations of 'assertRejects' ( #12893 )
2021-11-25 02:23:03 +01:00
Bartek Iwańczuk
e68a241946
chore: upgrade lspower to 1.4.0 ( #12894 )
2021-11-25 12:10:12 +11:00
Bert Belder
c6f3493f18
chore: merge v1.16.3 into main ( #12892 )
2021-11-24 15:56:18 -08:00
David Sherret
adc5974333
fix(lsp): lsp should respect include/exclude files in format config ( #12876 )
2021-11-24 15:14:19 -05:00
Bartek Iwańczuk
1117d2db39
compat: support compat mode in REPL ( #12882 )
...
This commit introduces "ProcState::maybe_resolver" field, which
stores a single instance of resolver for the whole lifetime of the
process, instead of creating these resolvers for each creation
of module graph. As a result, this resolver can be used in fallback
case where graph is not constructed (REPL, loading modules using
"require") unifying resolution logic.
2021-11-24 16:55:10 +01:00
Bartek Iwańczuk
1a51f2392d
chore: speed up compat tests ( #12884 )
...
This commit speeds up compat tests by using local copy of "deno_std"
instead of downloading it from https://deno.land for each test.
Additionally type checking is skipped.
2021-11-24 12:24:13 +01:00
David Sherret
0f90b4665a
chore(lsp): fix possible race condition with tests expecting 3 publishDiagnostics messages ( #12868 )
...
The tests expect 3 publish notifications. It was possible for less than 3 to occur if two or more tasks set the diagnostics in the collection, exited the lock at the same time, then called `publish_diagnostics`
2021-11-23 20:04:27 -05:00
Zheyu Zhang
fd6d0e309c
fix(cli/compile): skip bundling for pre-bundled code ( #12687 )
2021-11-23 23:59:17 +01:00
Nayeem Rahman
63fc73c491
refactor(cli): deduplicate source cache for redirected specifiers ( #12795 )
2021-11-24 08:30:52 +11:00
Nayeem Rahman
7413c96985
fix(cli): don't cache .tsbuildinfo unless emitting ( #12830 )
...
Fixes #12755
Fixes #12807
Fixes #12832
2021-11-24 08:20:30 +11:00
Bartek Iwańczuk
d2c53e7f10
tests: remove 'fmt_check_tests_dir' test ( #12875 )
2021-11-23 18:36:13 +01:00
igorsaux
3f8c3b8568
fix(lsp): normalize urls in did_change_watched_files ( #12873 )
2021-11-23 12:32:40 -05:00
Bartek Iwańczuk
bedb2adfb0
refactor: remove "unitTest" wrapper from cli/tests/unit ( #12750 )
2021-11-23 17:45:18 +01:00
David Sherret
51e3db956a
fix(cli): config file should resolve paths relative to the config file ( #12867 )
...
* Add `specifier_to_file_path` to support converting a ModuleSpecifier with a unix-style path to a PathBuf on Windows.
2021-11-23 10:38:11 -05:00
Bartek Iwańczuk
d8afd56838
feat(test): Add more overloads for "Deno.test" ( #12749 )
...
This commit adds 4 more overloads to "Deno.test()" API.
```
// Deno.test(function testName() { });
export function test(fn: (t: TestContext) => void | Promise<void>): void;
// Deno.test("test name", { only: true }, function() { });
export function test(
name: string,
options: Omit<TestDefinition, "name">,
fn: (t: TestContext) => void | Promise<void>,
): void;
// Deno.test({ name: "test name" }, function() { });
export function test(
options: Omit<TestDefinition, "fn">,
fn: (t: TestContext) => void | Promise<void>,
): void;
// Deno.test({ only: true }, function testName() { });
export function test(
options: Omit<TestDefinition, "fn" | "name">,
fn: (t: TestContext) => void | Promise<void>,
): void;
```
2021-11-23 14:57:51 +01:00
Luca Casonato
ae34f8fa10
fix: support "other" event type in FSWatcher ( #12836 )
...
This commit adds support for "other" events in `FSWatcher`. Flags on
events are now exposed via the `flag` property on `FsEvent`.
2021-11-23 11:30:24 +01:00
Kitson Kelly
210300d049
feat(lsp): add type definition provider ( #12789 )
2021-11-23 11:09:19 +11:00
Kitson Kelly
bf5657cd59
feat(lsp): add workspace symbol provider ( #12787 )
2021-11-23 11:08:56 +11:00
igorsaux
3abe31252e
fix(lsp): use lint exclude files list from the config file ( #12825 )
2021-11-22 18:10:33 -05:00
Luca Casonato
71ceca0ffc
fix(ext/crypto): don't panic on decryption failure ( #12840 )
2021-11-22 23:58:21 +01:00
Luca Casonato
3cc724c9ba
fix(runtime): support reading /proc using readFile ( #12839 )
2021-11-22 16:53:58 +01:00
Luca Casonato
429c773a2e
tests: extend readFile file length during read ( #12835 )
...
This commit adds some tests that demonstrate that Deno.readFile reads
the entire file, even if the read file is extended during read.
2021-11-22 16:25:42 +01:00
David Sherret
ddfba7d8ca
fix(fmt): markdown formatting was incorrectly removing some non-breaking space html entities ( #12818 )
2021-11-19 12:54:41 -05:00
David Sherret
c82ce74133
refactor(lsp): remove Documents mutex and require Documents to be mutated to change it ( #12747 )
2021-11-18 13:50:24 -05:00
Kitson Kelly
14f83da221
fix(lsp): tag deprecated diagnostics properly ( #12801 )
2021-11-18 13:05:20 +11:00
Bert Belder
77c4c249ba
test(ext/http): DELETE requests should always have body ( #12798 )
...
Refs: #12741
Refs: #12746
2021-11-17 15:34:41 -08:00
David Sherret
4836ab769c
1.16.2 ( #12794 )
2021-11-17 11:00:58 -05:00
David Sherret
cd61cedd19
chore: bump crates for 1.16.2 ( #12792 )
2021-11-17 10:14:23 -05:00
Kitson Kelly
cc38580106
fix(lsp): retain module dependencies when parse is invalid ( #12782 )
...
Fixes #12753
2021-11-17 09:23:25 +11:00
Ryan Dahl
b2036a4db7
refactor: re-export anyhow from deno_core ( #12777 )
2021-11-16 09:02:28 -05:00
Yacine Hmito
f9f9ddc5e3
tests(lsp): regression test for providing completions when editing documents ( #12776 )
...
Ref: #12753
2021-11-16 13:59:33 +11:00
Ryan Dahl
01644488ae
refactor: clean up cli/file_fetcher.rs ( #12772 )
2021-11-15 19:59:19 -05:00
Nayeem Rahman
cd9193f126
fix(cli): short-circuit in prepare_module_load() ( #12604 )
2021-11-16 10:25:52 +11:00
David Sherret
243d3ba755
fix(transpile): do not panic on swc_ecma_utils::HANDLER diagnostics ( #12773 )
2021-11-15 18:04:34 -05:00
David Sherret
ec9f5d5af2
feat(unstable/test): include test step pass/fail/ignore counts in final report ( #12432 )
2021-11-15 10:20:37 -05:00
Geert-Jan Zwiers
58e7b290dc
fix(test): support typechecking docs with CRLF line endings ( #12748 )
2021-11-15 09:58:04 -05:00
David Sherret
28dbb4a95e
refactor(lsp): prefer using document instead of documents collection ( #12720 )
2021-11-12 11:42:04 -05:00
Luca Casonato
fdf890a68d
v1.16.1
2021-11-11 11:59:29 +01:00
Luca Casonato
3250ffe020
chore: bump crate versions for 1.16.1 ( #12729 )
2021-11-11 11:16:05 +01:00
Luca Casonato
08067b5e12
fix: add typings for AbortSignal.reason ( #12730 )
2021-11-11 10:28:06 +01:00
upendra1997
e00bfecf96
fix(crypto): handling large key length in HKDF ( #12692 )
2021-11-11 10:04:17 +01:00
Bert Belder
72a6231a61
refactor(ext/http): rewrite hyper integration and fix bug ( #12732 )
...
Fixes: #12193
Fixes: #12251
Closes: #12714
2021-11-10 14:51:43 -08:00
Luca Casonato
6af916c3f4
fix: non ascii buffer response in http server ( #12728 )
2021-11-10 16:48:46 +01:00
Bartek Iwańczuk
8ce53dd22b
fix: update unstable Deno props for signal API ( #12723 )
2021-11-10 14:30:20 +01:00
Geert-Jan Zwiers
9817c24642
typo
2021-11-09 13:43:23 -05:00
Aaron O'Mullan
375ce63c63
feat(core): streams ( #12596 )
...
This allows resources to be "streams" by implementing read/write/shutdown. These streams are implicit since their nature (read/write/duplex) isn't known until called, but we could easily add another method to explicitly tag resources as streams.
`op_read/op_write/op_shutdown` are now builtin ops provided by `deno_core`
Note: this current implementation is simple & straightforward but it results in an additional alloc per read/write call
Closes #12556
2021-11-09 19:26:17 +01:00
Luca Casonato
1eae6c139e
v1.16.0
2021-11-09 13:55:05 +01:00
Luca Casonato
4f64acd4e4
chore: bump crate versions for 1.16.0 ( #12706 )
2021-11-09 13:03:17 +01:00
Luca Casonato
0de6d1edc4
fix(fetch): set content-length for empty POST/PUT ( #12703 )
...
This commit changes `fetch` to set `content-length: 0` on POST and PUT
requests with no body.
2021-11-09 12:10:40 +01:00
Luca Casonato
75793baae8
Revert "refactor(ext/http): rewrite hyper integration and fix bug ( #12332 )" ( #12704 )
...
This reverts commit 5b1e537446
2021-11-09 12:10:21 +01:00
Kitson Kelly
31fde9deba
chore(lsp): align ScriptElementKind to current versions of TypeScript/vscode ( #12663 )
2021-11-09 21:45:40 +11:00
Luca Casonato
22dd1b90c4
fix(cli/upgrade): nice error when unzip is missing ( #12693 )
...
Previously just a generic "error: No such file or directory (os error
2)" was printed. Now "`unzip` was not found on your PATH, please install
`unzip`" will be printed.
2021-11-09 11:06:45 +01:00
Kitson Kelly
f5eb177f50
feat(cli): support React 17 JSX transforms ( #12631 )
...
Closes #8440
2021-11-09 12:26:39 +11:00
David Sherret
45425c1146
fix(lint): use recommended tags when no tags specified in config, but includes or excludes are ( #12700 )
2021-11-08 20:10:33 -05:00
Bert Belder
5b1e537446
refactor(ext/http): rewrite hyper integration and fix bug ( #12332 )
...
Fixes: #12193
2021-11-08 12:49:11 -08:00
Bert Belder
f1b1a3f389
refactor: move mod tokio_util to runtime ( #12332 )
...
This avoids a bunch of duplicated code.
2021-11-08 12:49:11 -08:00
Luca Casonato
80d3a5f8be
feat: update to V8 9.7 ( #12685 )
...
This commit updates the rusty_v8 to 0.34.0. This commit also adds
the required typings for the new Array#findLast and Array#findIndexLast
methods.
2021-11-08 14:24:54 +01:00
Yoshiya Hinosawa
8e010b6844
feat(compat): add .code to dyn import error ( #12633 )
2021-11-08 16:02:40 +09:00
Kitson Kelly
182de1452b
fix(lsp): display module types only dependencies on hover ( #12683 )
...
Fixes: #12675
2021-11-08 11:50:48 +11:00
Kitson Kelly
91f8bdda2c
fix(lsp): cache unsupported import completion origins ( #12661 )
...
Fixes #12621
2021-11-08 09:35:32 +11:00
Luca Casonato
b6b25671b2
fix(lsp): display signature docs as markdown ( #12636 )
...
These were previously displayed as plain text. Now they are displayed as
`MarkupContent` with type `Markdown`.
2021-11-07 23:26:11 +01:00
Aaron O'Mullan
0f8299d011
fix(cli): don't panic when mapping unknown errors ( #12659 )
...
Instead fallback to generic "Error" class, fixes #12590 , also update WPT expectations
2021-11-07 15:33:56 +01:00
Aaron O'Mullan
44511e4f33
feat(runtime): give OS errors .code attributes ( #12591 )
...
This adds `.code` attributes to errors returned by the op-layer, facilitating classifying OS errors and helping node-compat.
Similar to Node, these `.code` attributes are stringified names of unix ERRNOs, the mapping tables are generated by [tools/codegen_error_codes.js](https://gist.github.com/AaronO/dfa1106cc6c7e2a6ebe4dba9d5248858 ) and derived from libuv and rust's std internals
2021-11-04 16:44:34 +01:00
Zheyu Zhang
efe956b4fd
fix(lint): use recommended tag if there is no tags in config file or flags ( #12644 )
2021-11-04 11:12:12 -04:00
Luca Casonato
318dcc33af
Revert "feat(cli): enable useUnknownInCatchVariables by default" ( #12643 )
...
This partially reverts commit a065604155
2021-11-04 11:30:37 +01:00
