3 commits

Author	SHA1	Message	Date
Nathan Whitaker	368eb9073b	fix(napi): Read reference ownership before calling finalizer to avoid crash (#24203) ... Fixes #23493. What was happening here was that napi-rs was freeing the napi reference ([here](19e3488efc/crates/napi/src/bindgen_runtime/mod.rs (L62))) during its finalize callback (which we call [here](fb31eaa9ca/cli/napi/js_native_api.rs (L132))). We then were [reading the `ownership` field](fb31eaa9ca/cli/napi/js_native_api.rs (L136)) of that freed reference. For some reason on arm macs the freed memory gets zeroed, so the value of `ownership` was `0` when we read it (i.e. it was `ReferenceOwnership::Runtime`). We then freed it again (since we thought we owned it), causing the segfault.	2024-06-13 22:31:42 +00:00
David Sherret	47f7bed677	chore: enable clippy::print_stdout and clippy::print_stderr (#23732) ... 1. Generally we should prefer to use the `log` crate. 2. I very often accidentally commit `eprintln`s. When we should use `println` or `eprintln`, it's not too bad to be a bit more verbose and ignore the lint rule.	2024-05-08 22:45:06 -04:00
Matt Mastracci	f60720090c	chore: move test_ffi and test_nap to tests/ [WIP] (#22394) ... Moving some additional NAPI and. FFI tests out of the tree root.	2024-02-12 13:46:50 -07:00

Renamed from test_napi/tests/napi_tests.rs (Browse further)