foster/denoland-deno
1
0
Fork 0
mirror of https://github.com/denoland/deno.git synced 2024-12-28 01:59:06 -05:00
Code Issues Packages 1 Wiki Activity
2611 commits 138 branches 356 tags 316 MiB
Commit graph

371 commits

Author SHA1 Message Date
Bert Belder
7d03a63ded
Revert "Fix permissions for dial and listen (#2373)" 
This reverts commit 7219787894.
 2019-05-22 19:47:15 -07:00
Bartek Iwańczuk
7219787894 Fix permissions for dial and listen (#2373) 2019-05-17 14:50:53 -04:00
Bert Belder
6e7ccf0b49
tools: format .gn files in the 'cli' directory 2019-05-16 19:57:31 -07:00
Ryan Dahl
160a815767
Rename HTTP benchmarks (#2350) 2019-05-14 15:22:50 -04:00
Kevin (Kun) "Kassimo" Qian
d9cdc6788b fix: support relative path for whitelisting (#2317) 
Using `std::fs::canonicalize` to expand path to full existing path, such that
later attempt to loop-pop and compare path segment would work.
 2019-05-09 12:20:34 -04:00
andy finch
2edee3367d First pass at permissions whitelist (#2129) 2019-05-08 19:20:30 -04:00
Bartek Iwańczuk
ac8c6fec5b Refactor unit test runner (#2294) 
Properly discovers the permissions needed for each test.
 2019-05-08 19:15:24 -04:00
Bartek Iwańczuk
f6a9d7d717 add "deno run" subcommand (#2215) 2019-05-03 17:15:16 -04:00
Kevin (Kun) "Kassimo" Qian
3608117132 feat(cli cmd): deno xeval (#2260) 2019-05-03 16:24:09 -04:00
Ryan Dahl
e4354ce739
Re-enable networking unit tests (#2268) 
The following tests were commented out in order to get this to go green :
- bodyMultipartFormData
- bodyURLEncodedFormData
- fetchRequestInitStringBody
- netConcurrentAccept
- netListenAsyncIterator
 2019-05-02 17:08:02 -04:00
Bartek Iwańczuk
8978870808 Rename test targets (#2262) 2019-05-01 09:48:56 -04:00
andy finch
c36b5dd01c Make error in ast_util more informative. (#2252) 2019-04-30 12:15:03 -07:00
Bartek Iwańczuk
b7d8a0c6f6 Rename deno prefetch to deno fetch (#2210) 2019-04-25 13:47:33 -04:00
Ryan Dahl
9dfebbc949
Fix eslint warnings (#2151) 
Co-authored-by: Bartek Iwańczuk <biwanczuk@gmail.com>
Co-authored-by: LE GOFF Vincent <g_n_s@hotmail.fr>
 2019-04-21 16:40:10 -04:00
Bartek Iwańczuk
cd19da62d9 Refactor CLI entry point (#2157) 
Changes "deno --types" to "deno types"
and "deno --prefetch" to "deno prefetch"
 2019-04-21 11:34:18 -04:00
Jonathon Orsi
648d2f3ba8 fix typo in permissions explanation (#2162) 2019-04-20 15:12:00 -04:00
Ryan Dahl
f03280ead1
benchmarks: improve syscall and thread count (#2140) 2019-04-17 15:47:07 -04:00
Ryan Dahl
f20b05af24
benchmarks: fix max_memory and clean up (#2137) 2019-04-17 10:52:36 -04:00
Dmitry Sharshakov
0c46358220 Add max memory benchmark (#2061) 2019-04-16 13:57:05 -04:00
Yoshiya Hinosawa
5a3f3a7445 upgrade deno_std & add workaround prettier issue (#2087) 2019-04-09 13:32:48 -04:00
Vincent LE GOFF
734cf781c6 Allow high precision performance.now() (#1977) 2019-04-08 16:22:40 -04:00
Ryan Dahl
3995473925
Fix unit_tests.py (#2065) 
They were silently broken in 780e72 due to flag reordering. This commit
also includes a new assert that would avoid that kind of failure in the
future.
 2019-04-07 20:58:26 +03:00
Bartek Iwańczuk
780e72ab6a Refactor CLI flag parsing (#2025) 2019-04-07 01:13:06 +03:00
Ryan Dahl
cb11bbd839
Test TCP_NODELAY in hyper_hello (#2060) 2019-04-06 16:56:30 +03:00
Ryan Dahl
9e890c260b Fix tools/docs.py (#2055) 2019-04-06 15:54:54 +02:00
andy finch
7a3df0a184 Add worker benchmarks (#2059) 2019-04-05 22:57:59 +03:00
Kevin (Kun) "Kassimo" Qian
534b8d3021 Follow redirect location as new referrers for nested module imports (#2031) 
Fixes #1742
Fixes #2021
 2019-04-01 21:46:40 -04:00
andy finch
b0a23beb8f Add web worker JS API (#1993) 
* Refactored the way worker polling is scheduled and errors are handled.
* Share the worker future as a Shared
 2019-04-01 15:09:59 -04:00
Kitson Kelly
ada5ffa610 Upgrade to TypeScript 3.4.1 (#2027) 2019-04-01 12:47:25 -04:00
Bert Belder
97265895ba
Publish rust crate on crates.io (#2024) 2019-03-31 17:22:02 -04:00
Ryan Dahl
6744bb8d75
Call ninja directly from build.rs (#2020) 2019-03-30 19:27:00 -04:00
Ryan Dahl
c9614d86c1
Move //libdeno to //core/libdeno (#2015) 
Fixes some sed errors introduced in c43cfe.

Unfortunately moving libdeno required splitting build.rs into two parts,
one for cli and one for core.

I've also removed the arm64 build - it's complicating things at this
re-org and we're not even testing it. I need to swing back to it and get
tools/test.py running for it.
 2019-03-30 14:45:36 -04:00
Ryan Dahl
c25e262b04
Merge the --recompile and --reload flags (#2003) 2019-03-28 16:05:41 -04:00
Bartek Iwańczuk
5ae78eb1de Update ts_library_builder (#1920) 2019-03-25 00:23:24 -04:00
Bernard Lin
3cc90d9bcf Add benchmark for max latency (#1975) 2019-03-24 23:36:27 -04:00
Ryan Dahl
12753e492f
Website updates (#1984) 2019-03-22 11:34:47 -04:00
Ryan Dahl
fa3c35301a
Rename //src/ to //cli/ (#1962) 
To better distinguish the deno_core crate from the executable deno,
which will now be called "the cli" internally.
 2019-03-19 12:18:05 -04:00
Ryan Dahl
c7d81fa9ff Make write_gn_args.py quiet 2019-03-19 03:50:47 -04:00
Ryan Dahl
8f3d0ca664 Deprecate DENO_BUILD_MODE=release 
Instead use: tools/build.py --release
 2019-03-19 03:50:47 -04:00
andy finch
e98d3391de Re-enable permissions prompt tests (#1957) 2019-03-18 18:54:59 -04:00
Ryan Dahl
44773c9b0f Integrate //core into existing code base 
This disables a few tests which are broken still:
- tests/error_004_missing_module.test
- tests/error_005_missing_dynamic_import.test
- tests/error_006_import_ext_failure.test
- repl_test test_set_timeout
- repl_test test_async_op
- repl_test test_set_timeout_interlaced
- all of permission_prompt_test
 2019-03-18 17:17:08 -04:00
Ryan Dahl
33438b83a2 Re-order tests for sanity 2019-03-18 17:17:08 -04:00
andy finch
08a674bf91 More permissions prompt options (#1926) 2019-03-18 16:46:23 -04:00
Ryan Dahl
59ac2063e0 Remove unused tools/build_test.py file 2019-03-18 14:07:24 -04:00
Ryan Dahl
52b7cc5499 Fix entry point for tools/docs.py 2019-03-18 14:07:24 -04:00
Ryan Dahl
1811318097 core: Behavior shouldn't be generic 
We always pass around Box<[u8]>, and adding this generic is an
unnecessary complication.

Add deno_core_http_bench_test to test.py

sharedQueue works on deno_core_http_bench
 2019-03-15 10:58:18 -04:00
Ryan Dahl
76c73ec61e
Add --no-binary-download option to setup.py (#1916) 2019-03-15 10:06:17 -04:00
andy finch
7e09221031 --no-prompt flag for non-interactive environments (#1913) 2019-03-13 12:43:47 -04:00
Kitson Kelly
75a500ba81 Update to TypeScript 3.3 (#1908) 2019-03-11 10:53:18 -04:00
Kitson Kelly
034e2cc028 Migrate from tslint to eslint for linting (#1905) 2019-03-09 12:30:38 -05:00
Kitson Kelly
24d6bf6aeb Remove 'deno' builtin module (#1895) 2019-03-07 21:56:56 -05:00
Kitson Kelly
0473d832c1 Cleanup node_modules, update packages (#1894) 
And fix new lint issues.
 2019-03-07 08:53:56 -05:00
Andy Hayden
91364cabae Replace deno.land/x/std with deno.land/std (#1890) 2019-03-06 10:23:47 -05:00
Bert Belder
ee29ed79a7
tools/run_node: only create 'node_modules' symlink once 
Previously run_node.py would always attempt to remove and then re-create
the 'target/xx/node_modules' symlink. This causes sporadic build errors
on windows when multiple build targets that use run_node.py are being
built concurrently.
 2019-03-04 21:01:52 -08:00
Bert Belder
860be9f0de
tools: remove fix_symlinks() function 
This fixes an issue on Windows that causes build to fails when
fix_symlinks() is called concurrently with another build step.

It is also no longer necessary, since recent versions of git know how to
properly create symbolic links on checkout.
 2019-03-04 21:01:52 -08:00
Yoshiya Hinosawa
a7bb8ccce8 Add Deno.version.gnArgs (#1845) 
To display specific build args passed to GN.
 2019-03-01 19:33:28 -05:00
Ryan Dahl
b8a537d020
deno_core (#1827) 
A new low-level crate with focus on speed. 
This doesn't yet hook into the existing code base.
 2019-02-26 17:36:05 -05:00
Ryan Dahl
e109941bd2 Improve readme (#1822) 2019-02-21 20:22:44 -08:00
Dmitry Sharshakov
4dc4329e27 Add execPath function (#1743) 2019-02-15 11:22:02 -05:00
Ryan Dahl
748e456cdb
Use prebuilt hyperfine (#1755) 2019-02-14 18:18:24 -05:00
Ryan Dahl
f29c40a433
Decouple ts_library_builder from std/testing (#1749) 2019-02-12 15:22:43 -05:00
Ryan Dahl
0b0d962eb9
Revert "Rewrite tools/format.py in deno (#1528)" (#1752) 
tools/format.ts is making CI flaky and it's difficult to run right now.
Reverting to tools/format.py

This reverts commit f19622e768.
 2019-02-12 15:20:32 -05:00
Kitson Kelly
a21a5ad2fa Add Deno global namespace (#1748) 
Resolves #1705

This PR adds the Deno APIs as a global namespace named `Deno`. For backwards
compatibility, the ability to `import * from "deno"` is preserved. I have tried
to convert every test and internal code the references the module to use the
namespace instead, but because I didn't break compatibility I am not sure.

On the REPL, `deno` no longer exists, replaced only with `Deno` to align with
the regular runtime.

The runtime type library includes both the namespace and module. This means it
duplicates the whole type information. When we remove the functionality from the
runtime, it will be a one line change to the library generator to remove the
module definition from the type library.

I marked a `TODO` in a couple places where to remove the `"deno"` module, but
there are additional places I know I didn't mark.
 2019-02-12 10:08:56 -05:00
Ryan Dahl
a4dec944bc
web design (#1728) 2019-02-11 17:41:13 -05:00
Kevin (Kun) "Kassimo" Qian
489c69f8e1 REPL multiline support with recoverable errors (#1731) 2019-02-11 14:01:28 -05:00
Yoshiya Hinosawa
d26655371b fix: improve formatting (#1732) 2019-02-11 12:57:26 -05:00
Kevin (Kun) "Kassimo" Qian
1d36eb47eb Support scoped variables, unblock REPL async op, and REPL error colors (#1721) 2019-02-09 16:55:40 -05:00
Yoshiya Hinosawa
1502051453 Add read permission for format.ts (#1726) 2019-02-09 10:55:18 -05:00
J2P
65cafd2edf Add --allow-read test code 2019-02-09 05:57:41 -05:00
Bert Belder
394b81de15
Move .rustfmt.toml to the repository root 
This allows rustfmt to automatically pick it up.
It's right there with similar files such as .prettierrc.
 2019-02-08 20:06:21 -08:00
Ryan Dahl
526497bc29
Adds deno.noColor (#1716) 2019-02-08 22:13:04 -05:00
Yoshiya Hinosawa
4c869dc885 Use std/prettier in deno //tools/format.ts (#1708) 2019-02-08 21:38:59 -05:00
Dmitry Sharshakov
9ab03389f0 Add --allow-read (#1689) 
Co-authored-by: Greg Altman <g.s.altman@gmail.com>
 2019-02-08 15:59:38 -05:00
Ryan Dahl
46804e50ed
Color exceptions (#1698) 2019-02-07 20:07:20 -05:00
Dmitry Sharshakov
5c50d2819b Add emojis to permission prompts (#1684) 2019-02-07 16:19:50 -05:00
Dmitry Sharshakov
aea7884d11 Make integration tests standalone (#1671) 
Co-authored-by: Sergey Golovin <golovim@gmail.com>
 2019-02-07 15:11:03 -05:00
Ryan Dahl
79b95341d9
Upgrade V8 to 7.4.98 (kKeep fix) (#1640) 
* Upgrade V8 to 7.4.98 (kKeep fix)

https://github.com/denoland/deno/issues/814
https://bugs.chromium.org/p/v8/issues/detail?id=8761

* fix tests
 2019-02-06 23:43:31 -05:00
Kitson Kelly
48fedee34e Add WebAssembly to runtime library (#1677) 
This also modifies the `ts_library_builder` to support inlining assets.

Includes integration tests from @sh7dm
 2019-02-05 08:12:58 -05:00
Dmitry Sharshakov
181b03273c Add isTTY function (#1622) 2019-02-02 22:05:30 -05:00
Ryan Dahl
18b815e336 Support --fmt 2019-02-02 17:48:43 -05:00
Ryan Dahl
98d20cd178 Make it possible to run one integration test at a time 2019-02-02 17:33:21 -05:00
Kevin (Kun) "Kassimo" Qian
3650bae5f6 Add --info flag to display file info (compiled code/source map) (#1647) 2019-02-02 01:28:31 -05:00
Ryan Dahl
eff7a1484e
Upgrade deno_std to bef7ba (#1609) 2019-01-31 18:11:37 -05:00
Ryan Dahl
06c0e29118 Fix cpplint 2019-01-30 15:53:23 -05:00
Ryan Dahl
b9e368cb4c
Add snapshot_compiler.bin to binary size benchmark (#1611) 2019-01-30 14:01:13 -05:00
Sergey Golovin
240ca25617 Add repl functions "help" and "exit" (#1563) 2019-01-29 14:41:12 -05:00
JaePil Jung
7f88b5fff3 Minor code cleanups (#1570) 2019-01-24 10:54:43 -05:00
Yoshiya Hinosawa
77114fbda4 chore: update license lines (#1557) 2019-01-21 13:03:30 -06:00
Yoshiya Hinosawa
f19622e768 Rewrite tools/format.py in deno (#1528) 
Note: findFiles and findFilesWalk are borrowed from the previous
attempt of @pseudo-su (#1434)
 2019-01-17 15:09:44 -05:00
J2P
befc6b2e76 Fixed copyright of types output 2019-01-17 14:44:31 -05:00
Kitson Kelly
00b655add1 Add globalThis definition to runtime (#1534) 2019-01-16 17:57:15 -05:00
Kevin (Kun) "Kassimo" Qian
c870cf4082 Add --prefetch flag for deps prefetch without running (#1475) 2019-01-15 12:19:58 -05:00
Ryan Dahl
8ae178e9ce
Fix permission_prompt_test (#1509) 2019-01-13 12:09:45 -05:00
JaePil Jung
37e3db00a2 Add --allow-run test code (#1504) 2019-01-12 11:29:45 -05:00
Maxim Mazurok
3634488caa Fix flaky REPL test (#1491) 
Fixes #1490
 2019-01-09 15:32:05 -05:00
Ryan Dahl
4f62a56f90
Move testing module to deno_std (#1451) 
Upgrades deno_std submodule.
 2019-01-03 14:55:22 -05:00
Kevin (Kun) "Kassimo" Qian
8d452d74fa Support more fetch init body types (#1449) 2019-01-03 06:41:20 -05:00
Ryan Dahl
2c477dd7cb Happy new year! 2019-01-02 02:37:08 +01:00
Kevin (Kun) "Kassimo" Qian
73fb98ce70 Lazily create .mime files only with mismatch/no extension (#1417) 2018-12-27 20:40:06 +00:00
Ryan Dahl
32e1641628 deno_net -> deno_std rename 
Also don't format external js/deps
 2018-12-24 11:31:17 -05:00
Kevin (Kun) "Kassimo" Qian
cbee2895b3 Implement Body.formData for fetch (#1393) 2018-12-21 17:09:53 -05:00
Ryan Dahl
aa66ef98ea
travis: Set CARGO_HOME to third_party/rust_crates (#1370) 
Adds prebuilt hyperfine and sccache binaries 

Only build test_cc for LSAN

Add Cargo.lock

Only run benchmarks in master
 2018-12-18 21:09:30 -05:00
Ryan Dahl
7a0d9370e8 Load sccache from S3 on CI 2018-12-18 15:15:08 -05:00
Bert Belder
b40326875c Remove prebuilt v8 support 2018-12-18 15:15:08 -05:00
Ryan Dahl
0481d6c2c0
Enable jumbo build in release. (#1362) 2018-12-18 09:16:49 -05:00
Ryan Dahl
bba1a0d44a tools: remove_and_symlink can be skipped on unix 
This is more optimial and this fixes a problem where occasionally
remove_and_symlink will error with:

    gen/compiler_bundle/main.js --sourcemapFile /Users/rld/src/deno --silent
    Traceback (most recent call last):
      File "../../tools/run_node.py", line 18, in <module>
        util.remove_and_symlink(target_rel, "node_modules", True)
      File "/Users/rld/src/deno/tools/util.py", line 103, in remove_and_symlink
        symlink(target, name, target_is_dir)
      File "/Users/rld/src/deno/tools/util.py", line 141, in symlink
        os.symlink(target, name)
    OSError: [Errno 17] File exists
 2018-12-11 15:07:38 -05:00
Ryan Dahl
9a960b9f58
Use stderr for exceptions (#1303) 2018-12-10 17:50:41 -05:00
Bartek Iwańczuk
ba429ccde8 Add benchmark for net/http (#1289) 2018-12-07 16:36:16 -05:00
Kitson Kelly
6cc89b9e27 Use alternate TextEncoder/TextDecoder implementation (#1281) 
This is faster and smaller.
 2018-12-06 10:01:15 -08:00
Ryan Dahl
8373046719 Add LSAN build to travis. 
For now it only runs test_cc and has to filter out a test which leaks.
However we will expand this over time until the entire build is LSAN clean.
 2018-12-03 15:31:06 -08:00
Bert Belder
7d02971c2c
third_party: symlink //third_party/v8/build => //build 2018-12-03 12:14:05 -08:00
Ryan Dahl
c5d8cf8eb6 Use pylint. 2018-11-30 11:33:45 -08:00
Ryan Dahl
122ccce89a Fix flaky REPL test. 2018-11-30 09:23:04 -08:00
Ryan Dahl
cc126528f0
Add prebuilt/win/v8_debug.lib (#1249) 
The windows debug build was broken due to libc link errors.
 2018-11-29 23:25:59 -08:00
Ryan Dahl
1ac2934604 Make //build a git submodule 
So we can float patches before sending them upstream.
https://github.com/denoland/chromium_build

Remove build_extra/toolchain
 2018-11-29 23:12:38 -08:00
Ryan Dahl
84a1b4d793 Move libdeno build config to libdeno/BUILD.gn 2018-11-29 17:46:09 -08:00
Andy Hayden
e6309b78b0 Cleanup setTimeout repl test and alphabetize tests 2018-11-29 11:53:17 -08:00
Kevin (Kun) "Kassimo" Qian
09aa9b9698 REPL unblock event loop AND fix REPL setTimeout fire problems 2018-11-28 15:25:30 -08:00
Ryan Dahl
89096c9210 Use prebuilt V8 library by default. 
This still retains the ability to build V8 from scratch, with an number
of configurations. The prebuilt binaries were created using

DENO_BUILD_MODE=release ./tools/build.py v8
 2018-11-27 15:47:31 -08:00
Ryan Dahl
65cce40a89 gitignore vim .swp files 2018-11-27 15:47:31 -08:00
Bert Belder
48bf4062e4 First pass at running subprocesses (#1156) 2018-11-16 12:07:40 +08:00
Ryan Dahl
765863e87a Add a simple doc generation tool. 
And website upload tool.
 2018-11-14 17:34:28 -08:00
Kitson Kelly
34b6b86c76 Ensure global type instances are available. 2018-11-09 08:39:49 -08:00
Ryan Dahl
a18e51fd61
build: Use target/ instead of out/ (#1153) 2018-11-08 10:38:20 -08:00
Andy Hayden
e9327be831 Support repl multiline input (#1165) 2018-11-06 11:19:16 -08:00
Andy Hayden
27ecfc1617 Add repl (#998) 
- Running repl from js side.
- Add tests for repl behavior.
- Handle ctrl-C and ctrl-D.
 2018-11-05 09:55:59 -08:00
Kitson Kelly
5e48a681c4 Fix issue with runtime lib generation. 2018-11-05 07:17:47 -08:00
Kitson Kelly
4e07783663 Improve integration test harness (#1142) 2018-11-04 11:52:31 -08:00
Kitson Kelly
765f229357 Improve robustness of lib builder. 2018-11-04 05:56:49 -08:00
Ryan Dahl
198e396ead
Support cargo check (#1128) 
- Based on code from @qti3e and @piscisaureus in #724 and #1125
  respectively.
- TODO The DENO_BUILD_PATH env var must be supplied and must be an
  absolute path, this restriction should be removed in future work.
 2018-10-31 11:11:10 -07:00
Ryan Dahl
0fbee30f05 Make format.py less verbose. 2018-10-30 17:42:19 -07:00
Kevin (Kun) "Kassimo" Qian
a68403d090 Add application/x-typescript mime type support 2018-10-28 11:18:53 -07:00
Ryan Dahl
6adc87e3eb
Ergonomics: Prompt TTY for permission escalation (#1081) 2018-10-27 06:11:39 -07:00
Bert Belder
dfe21af237
Disable treat_warnings_as_errors on windows when sccache is in use 2018-10-26 04:14:37 +02:00
Ryan Dahl
231bb9cfb6 Add error_001.ts to execution time benchmarks. 
Ref #1087
 2018-10-25 16:12:52 -07:00
Ryan Dahl
3438dbe350 Remove deno_ns 2018-10-24 14:52:38 -07:00
Ryan Dahl
a4fb5175ce
Add node_tcp target to http_benchmark. (#1074) 2018-10-23 15:02:30 -07:00
Bert Belder
e9bf206416
format: don't format files in third_party 
It's annoying, and it also makes appveyor slow because it will re-upload
the third_party cache every time something changes in there.
 2018-10-23 18:51:06 +02:00
Bert Belder
0dda87f962
third_party: install yapf with pip 2018-10-23 16:51:54 +02:00
Bert Belder
4ceb205512
Bundle pywin32 in third_party 2018-10-23 16:29:46 +02:00
Kitson Kelly
8ef7da2611 Enforce media types 2018-10-23 04:48:00 -07:00
Kitson Kelly
64f0dfd50e Improve globals for runtime type library 2018-10-22 19:37:38 -07:00
Ryan Dahl
47c96a6152 CI should fail when code isn't formatted. 2018-10-21 13:59:53 -07:00
Ryan Dahl
bb9a927bd5 Add yapf to third_party. 2018-10-21 13:59:53 -07:00
Kyra
fbb3f05b6f Add URLSearchParams (#1049) 2018-10-21 08:07:29 -07:00
Kevin (Kun) "Kassimo" Qian
86409eb836 Add Rust hyper http benchmark (#1043) 
* Add go net/http benchmark

* Forget about Go. Let's do Rust Hyper

* Update BUILD.gn

* Rename
 2018-10-20 19:56:16 -07:00
Yoshiya Hinosawa
f44ecdff97 feat: show only 20 benchmark data in inde.html 2018-10-20 08:07:20 -04:00
Ryan Dahl
00884d7164 Add rustfmt to third_party. 2018-10-20 01:19:59 -04:00
Andy Hayden
2d583f85ee Exit http_server.py if it's crashed 2018-10-20 00:27:37 -04:00
ztplz
b809a82fd9 Add missing copyrights (#1024) 2018-10-19 15:25:29 -04:00