denoland-deno

foster/denoland-deno

Fork 0

mirror of https://github.com/denoland/deno.git synced 2024-12-02 17:01:14 -05:00

Commit graph

Author SHA1 Message Date

Author	SHA1	Message	Date
Divy Srivastava	a411144219	fix(ext/websocket): Avoid write deadlock that requires read_frame to complete (#18705 ) Fixes https://github.com/denoland/deno/issues/18700 Timeline of the events that lead to the bug. 1. WebSocket handshake complete 2. Server on `read_frame` holding an AsyncRefCell borrow of the WebSocket stream. 3. Client sends a TXT frame after a some time 4. Server recieves the frame and goes back to `read_frame`. 5. After some time, Server starts a `write_frame` but `read_frame` is still holding a borrow! ^--- Locked. read_frame needs to complete so we can resume the write. This commit changes all writes to directly borrow the `fastwebsocket::WebSocket` resource under the assumption that it won't affect ongoing reads.	2023-04-14 22:17:39 +05:30
Divy Srivastava	659d1dd7f8	perf(ext/websocket): make `op_server_ws_next_event` deferred (#18632 ) Avoid attempting to read immediately, wasting time polling the future. 2% throughput improvement on Linux.	2023-04-13 00:51:47 +02:00
Divy Srivastava	4cc8784f5b	perf(ext/websocket): replace tokio_tungstenite server with fastwebsockets (#18587 ) https://github.com/littledivy/fastwebsockets ``` # This PR ./load_test 100 0.0.0.0 8080 0 0 Running benchmark now... Msg/sec: 176355.000000 # main ./load_test 100 0.0.0.0 8080 0 0 Running benchmark now... Msg/sec: 157198.750000 ```	2023-04-06 18:44:31 +05:30

Divy Srivastava

a411144219

fix(ext/websocket): Avoid write deadlock that requires read_frame to complete (#18705 )

Fixes https://github.com/denoland/deno/issues/18700

Timeline of the events that lead to the bug.

1. WebSocket handshake complete
2. Server on `read_frame` holding an AsyncRefCell borrow of the
WebSocket stream.
3. Client sends a TXT frame after a some time
4. Server recieves the frame and goes back to `read_frame`.
5. After some time, Server starts a `write_frame` but `read_frame` is
still holding a borrow!
^--- Locked. read_frame needs to complete so we can resume the write.

This commit changes all writes to directly borrow the
`fastwebsocket::WebSocket` resource under the assumption that it won't
affect ongoing reads.

2023-04-14 22:17:39 +05:30

Divy Srivastava

659d1dd7f8

perf(ext/websocket): make op_server_ws_next_event deferred (#18632 )

Avoid attempting to read immediately, wasting time polling the future.
2% throughput improvement on Linux.

2023-04-13 00:51:47 +02:00

Divy Srivastava

4cc8784f5b

perf(ext/websocket): replace tokio_tungstenite server with fastwebsockets (#18587 )

https://github.com/littledivy/fastwebsockets

```
# This PR
./load_test 100 0.0.0.0 8080 0 0
Running benchmark now...
Msg/sec: 176355.000000

# main
./load_test 100 0.0.0.0 8080 0 0
Running benchmark now...
Msg/sec: 157198.750000
```

2023-04-06 18:44:31 +05:30

3 commits