denoland-deno

foster/denoland-deno

Fork 0

mirror of https://github.com/denoland/deno.git synced 2024-11-25 15:29:32 -05:00

Commit graph

Author	SHA1	Message	Date
Nathan Whitaker	7c57105cc4	fix(ext/node): only set our end of child process pipe to nonblocking mode (#26495 ) Fixes playwright on linux, as reported in https://github.com/denoland/deno/issues/16899#issuecomment-2378268454. The issue was that we were opening the socket in nonblocking mode, which meant that subprocesses trying to use it would get a `EWOULDBLOCK` error (unexpectedly). The fix here is to only set nonblocking mode on our end (which we need to use asynchronously)	2024-10-23 21:13:30 -07:00
Nathan Whitaker	8749d651fb	fix(node): Create additional pipes for child processes (#25016 ) Linux/macos only currently. Part of https://github.com/denoland/deno/issues/23524 (fixes it on platforms other than windows). Part of #16899 (fixes it on platforms other than windows). After this PR, playwright is functional on mac/linux.	2024-08-15 09:38:46 -07:00

Author

SHA1

Message

Date

Nathan Whitaker

7c57105cc4

fix(ext/node): only set our end of child process pipe to nonblocking mode (#26495 )

Fixes playwright on linux, as reported in
https://github.com/denoland/deno/issues/16899#issuecomment-2378268454.

The issue was that we were opening the socket in nonblocking mode, which
meant that subprocesses trying to use it would get a `EWOULDBLOCK` error
(unexpectedly). The fix here is to only set nonblocking mode on our end
(which we need to use asynchronously)

2024-10-23 21:13:30 -07:00

Nathan Whitaker

8749d651fb

fix(node): Create additional pipes for child processes (#25016 )

Linux/macos only currently.

Part of https://github.com/denoland/deno/issues/23524 (fixes it on
platforms other than windows).
Part of #16899  (fixes it on platforms other than windows).

After this PR, playwright is functional on mac/linux.

2024-08-15 09:38:46 -07:00

2 commits