denoland-deno

foster/denoland-deno

Fork 0

mirror of https://github.com/denoland/deno.git synced 2025-01-09 23:58:23 -05:00

Commit graph

Author SHA1 Message Date

Author	SHA1	Message	Date
Divy Srivastava	001a9a5856	fix(ext/websocket): Avoid write deadlock that requires read_frame to complete (#18705 ) Fixes https://github.com/denoland/deno/issues/18700 Timeline of the events that lead to the bug. 1. WebSocket handshake complete 2. Server on `read_frame` holding an AsyncRefCell borrow of the WebSocket stream. 3. Client sends a TXT frame after a some time 4. Server recieves the frame and goes back to `read_frame`. 5. After some time, Server starts a `write_frame` but `read_frame` is still holding a borrow! ^--- Locked. read_frame needs to complete so we can resume the write. This commit changes all writes to directly borrow the `fastwebsocket::WebSocket` resource under the assumption that it won't affect ongoing reads.	2023-04-18 17:41:51 +02:00
Divy Srivastava	0b023538a0	perf(ext/websocket): make `op_server_ws_next_event` deferred (#18632 ) Avoid attempting to read immediately, wasting time polling the future. 2% throughput improvement on Linux.	2023-04-18 17:41:50 +02:00
Divy Srivastava	cd57451e05	perf(ext/websocket): replace tokio_tungstenite server with fastwebsockets (#18587 ) https://github.com/littledivy/fastwebsockets ``` # This PR ./load_test 100 0.0.0.0 8080 0 0 Running benchmark now... Msg/sec: 176355.000000 # main ./load_test 100 0.0.0.0 8080 0 0 Running benchmark now... Msg/sec: 157198.750000 ```	2023-04-12 15:49:40 +02:00

Divy Srivastava

001a9a5856

fix(ext/websocket): Avoid write deadlock that requires read_frame to complete (#18705 )

Fixes https://github.com/denoland/deno/issues/18700

Timeline of the events that lead to the bug.

1. WebSocket handshake complete
2. Server on `read_frame` holding an AsyncRefCell borrow of the
WebSocket stream.
3. Client sends a TXT frame after a some time
4. Server recieves the frame and goes back to `read_frame`.
5. After some time, Server starts a `write_frame` but `read_frame` is
still holding a borrow!
^--- Locked. read_frame needs to complete so we can resume the write.

This commit changes all writes to directly borrow the
`fastwebsocket::WebSocket` resource under the assumption that it won't
affect ongoing reads.

2023-04-18 17:41:51 +02:00

Divy Srivastava

0b023538a0

perf(ext/websocket): make op_server_ws_next_event deferred (#18632 )

Avoid attempting to read immediately, wasting time polling the future.
2% throughput improvement on Linux.

2023-04-18 17:41:50 +02:00

Divy Srivastava

cd57451e05

perf(ext/websocket): replace tokio_tungstenite server with fastwebsockets (#18587 )

https://github.com/littledivy/fastwebsockets

```
# This PR
./load_test 100 0.0.0.0 8080 0 0
Running benchmark now...
Msg/sec: 176355.000000

# main
./load_test 100 0.0.0.0 8080 0 0
Running benchmark now...
Msg/sec: 157198.750000
```

2023-04-12 15:49:40 +02:00

3 commits