1
0
Fork 0
mirror of https://github.com/denoland/deno.git synced 2024-11-21 15:04:11 -05:00
denoland-deno/tests/node_compat/test/parallel/test-child-process-execfile.js
Nathan Whitaker 29934d558c
fix(node): Run node compat tests listed in the ignore field (and fix the ones that fail) (#24631)
The intent is that those tests will be executed, but our check that the
files are up to date won't overwrite the contents of the tests. This is
useful when a test needs some manual edits to work.

It turns out we weren't actually running them.

---

This ended up turning into a couple of small bug fixes to get the tests
passing:

- We weren't canonicalizing the exec path properly (it sometimes still
had `..` or `.` in it)
- We weren't accepting strings in `process.exit`

There was one failure I couldn't figure out quickly, so I disabled the
test for now, and filed a follow up issue: #24694
2024-07-24 03:12:08 +00:00

135 lines
4.3 KiB
JavaScript

// deno-fmt-ignore-file
// deno-lint-ignore-file
// Copyright Joyent and Node contributors. All rights reserved. MIT license.
// Taken from Node 18.8.0
// This file is automatically generated by "node/_tools/setup.ts". Do not modify this file manually
// TODO(PolarETech): The args passed to execFile() should not need to
// include "runner.ts".
// TODO(cjihrig): See inline TODO comments below.
'use strict';
const common = require('../common');
const assert = require('assert');
const { execFile, execFileSync } = require('child_process');
const { getSystemErrorName } = require('util');
const fixtures = require('../common/fixtures');
const os = require('os');
const fixture = fixtures.path('exit.js');
const echoFixture = fixtures.path('echo.js');
const execOpts = { encoding: 'utf8', shell: true };
{
execFile(
process.execPath,
['runner.ts', fixture, 42],
common.mustCall((e) => {
// Check that arguments are included in message
assert.strictEqual(e.message.trim(),
`Command failed: ${process.execPath} runner.ts ${fixture} 42`);
assert.strictEqual(e.code, 42);
})
);
}
{
// Verify that negative exit codes can be translated to UV error names.
const errorString = `Error: Command failed: ${process.execPath}`;
const code = -1;
const callback = common.mustCall((err, stdout, stderr) => {
assert.strictEqual(err.toString().trim(), errorString);
assert.strictEqual(err.code, getSystemErrorName(code));
assert.strictEqual(err.killed, true);
assert.strictEqual(err.signal, null);
assert.strictEqual(err.cmd, process.execPath);
assert.strictEqual(stdout.trim(), '');
assert.strictEqual(stderr.trim(), '');
});
const child = execFile(process.execPath, callback);
child.kill();
child.emit('close', code, null);
}
{
// Verify the shell option works properly
execFile(process.execPath, ['runner.ts', fixture, 0], execOpts, common.mustSucceed());
}
{
// Verify that the signal option works properly
const ac = new AbortController();
const { signal } = ac;
const test = () => {
const check = common.mustCall((err) => {
assert.strictEqual(err.code, 'ABORT_ERR');
assert.strictEqual(err.name, 'AbortError');
assert.strictEqual(err.signal, undefined);
});
execFile(process.execPath, ['runner.ts', echoFixture, 0], { signal }, check);
};
// Verify that it still works the same way now that the signal is aborted.
test();
ac.abort();
}
{
// Verify that does not spawn a child if already aborted
const signal = AbortSignal.abort();
const check = common.mustCall((err) => {
assert.strictEqual(err.code, 'ABORT_ERR');
assert.strictEqual(err.name, 'AbortError');
assert.strictEqual(err.signal, undefined);
});
execFile(process.execPath, ['runner.ts', echoFixture, 0], { signal }, check);
}
{
// Verify that if something different than Abortcontroller.signal
// is passed, ERR_INVALID_ARG_TYPE is thrown
assert.throws(() => {
const callback = common.mustNotCall(() => {});
execFile(process.execPath, ['runner.ts', echoFixture, 0], { signal: 'hello' }, callback);
}, { code: 'ERR_INVALID_ARG_TYPE', name: 'TypeError' });
}
{
// Verify that the process completing removes the abort listener
const ac = new AbortController();
const { signal } = ac;
const callback = common.mustCall((err) => {
// TODO(cjihrig): The assertion on the next line currently fails because
// kEvents is not defined. See TODO comment in _events.mjs.
// assert.strictEqual(getEventListeners(ac.signal).length, 0);
assert.strictEqual(err, null);
});
execFile(process.execPath, ['runner.ts', fixture, 0], { signal }, callback);
}
// Verify the execFile() stdout is the same as execFileSync().
{
const file = 'echo';
const args = ['foo', 'bar'];
// Test with and without `{ shell: true }`
[
// Skipping shell-less test on Windows because its echo command is a shell built-in command.
...(common.isWindows ? [] : [{ encoding: 'utf8' }]),
{ shell: true, encoding: 'utf8' },
].forEach((options) => {
const execFileSyncStdout = execFileSync(file, args, options);
assert.strictEqual(execFileSyncStdout, `foo bar${os.EOL}`);
execFile(file, args, options, common.mustCall((_, stdout) => {
assert.strictEqual(stdout, execFileSyncStdout);
}));
});
}