mirror of
https://github.com/denoland/deno.git
synced 2024-11-21 15:04:11 -05:00
4e899d48cf
Improving the breadth of collected data, and ensuring that the collected data is more likely to be successfully reported. - Use `log` crate in more places - Hook up `log` crate to otel - Switch to process-wide otel processors - Handle places that use `process::exit` Also adds a more robust testing framework, with a deterministic tracing setting. Refs: https://github.com/denoland/deno/issues/26852
1845 lines
53 KiB
Rust
1845 lines
53 KiB
Rust
// Copyright 2018-2024 the Deno authors. All rights reserved. MIT license.
|
|
|
|
//! This module provides feature to upgrade deno executable
|
|
|
|
use crate::args::Flags;
|
|
use crate::args::UpgradeFlags;
|
|
use crate::args::UPGRADE_USAGE;
|
|
use crate::colors;
|
|
use crate::factory::CliFactory;
|
|
use crate::http_util::HttpClient;
|
|
use crate::http_util::HttpClientProvider;
|
|
use crate::shared::ReleaseChannel;
|
|
use crate::util::archive;
|
|
use crate::util::progress_bar::ProgressBar;
|
|
use crate::util::progress_bar::ProgressBarStyle;
|
|
use crate::version;
|
|
|
|
use async_trait::async_trait;
|
|
use deno_core::anyhow::bail;
|
|
use deno_core::anyhow::Context;
|
|
use deno_core::error::AnyError;
|
|
use deno_core::unsync::spawn;
|
|
use deno_core::url::Url;
|
|
use deno_semver::Version;
|
|
use once_cell::sync::Lazy;
|
|
use std::borrow::Cow;
|
|
use std::env;
|
|
use std::fs;
|
|
use std::io::IsTerminal;
|
|
use std::ops::Sub;
|
|
use std::path::Path;
|
|
use std::path::PathBuf;
|
|
use std::process::Command;
|
|
use std::sync::Arc;
|
|
use std::time::Duration;
|
|
|
|
const RELEASE_URL: &str = "https://github.com/denoland/deno/releases";
|
|
const CANARY_URL: &str = "https://dl.deno.land/canary";
|
|
const DL_RELEASE_URL: &str = "https://dl.deno.land/release";
|
|
|
|
pub static ARCHIVE_NAME: Lazy<String> =
|
|
Lazy::new(|| format!("deno-{}.zip", env!("TARGET")));
|
|
|
|
// How often query server for new version. In hours.
|
|
const UPGRADE_CHECK_INTERVAL: i64 = 24;
|
|
|
|
const UPGRADE_CHECK_FETCH_DELAY: Duration = Duration::from_millis(500);
|
|
|
|
/// Environment necessary for doing the update checker.
|
|
/// An alternate trait implementation can be provided for testing purposes.
|
|
trait UpdateCheckerEnvironment: Clone {
|
|
fn read_check_file(&self) -> String;
|
|
fn write_check_file(&self, text: &str);
|
|
fn current_time(&self) -> chrono::DateTime<chrono::Utc>;
|
|
}
|
|
|
|
#[derive(Clone)]
|
|
struct RealUpdateCheckerEnvironment {
|
|
cache_file_path: PathBuf,
|
|
current_time: chrono::DateTime<chrono::Utc>,
|
|
}
|
|
|
|
impl RealUpdateCheckerEnvironment {
|
|
pub fn new(cache_file_path: PathBuf) -> Self {
|
|
Self {
|
|
cache_file_path,
|
|
// cache the current time
|
|
current_time: chrono::Utc::now(),
|
|
}
|
|
}
|
|
}
|
|
|
|
impl UpdateCheckerEnvironment for RealUpdateCheckerEnvironment {
|
|
fn read_check_file(&self) -> String {
|
|
std::fs::read_to_string(&self.cache_file_path).unwrap_or_default()
|
|
}
|
|
|
|
fn write_check_file(&self, text: &str) {
|
|
let _ = std::fs::write(&self.cache_file_path, text);
|
|
}
|
|
|
|
fn current_time(&self) -> chrono::DateTime<chrono::Utc> {
|
|
self.current_time
|
|
}
|
|
}
|
|
|
|
#[derive(Debug, Copy, Clone)]
|
|
enum UpgradeCheckKind {
|
|
Execution,
|
|
Lsp,
|
|
}
|
|
|
|
#[async_trait(?Send)]
|
|
trait VersionProvider: Clone {
|
|
/// Fetch latest available version for the given release channel
|
|
async fn latest_version(
|
|
&self,
|
|
release_channel: ReleaseChannel,
|
|
) -> Result<AvailableVersion, AnyError>;
|
|
|
|
/// Returns either a semver or git hash. It's up to implementor to
|
|
/// decide which one is appropriate, but in general only "stable"
|
|
/// and "lts" versions use semver.
|
|
fn current_version(&self) -> Cow<str>;
|
|
|
|
fn get_current_exe_release_channel(&self) -> ReleaseChannel;
|
|
}
|
|
|
|
#[derive(Clone)]
|
|
struct RealVersionProvider {
|
|
http_client_provider: Arc<HttpClientProvider>,
|
|
check_kind: UpgradeCheckKind,
|
|
}
|
|
|
|
impl RealVersionProvider {
|
|
pub fn new(
|
|
http_client_provider: Arc<HttpClientProvider>,
|
|
check_kind: UpgradeCheckKind,
|
|
) -> Self {
|
|
Self {
|
|
http_client_provider,
|
|
check_kind,
|
|
}
|
|
}
|
|
}
|
|
|
|
#[async_trait(?Send)]
|
|
impl VersionProvider for RealVersionProvider {
|
|
async fn latest_version(
|
|
&self,
|
|
release_channel: ReleaseChannel,
|
|
) -> Result<AvailableVersion, AnyError> {
|
|
fetch_latest_version(
|
|
&self.http_client_provider.get_or_create()?,
|
|
release_channel,
|
|
self.check_kind,
|
|
)
|
|
.await
|
|
}
|
|
|
|
fn current_version(&self) -> Cow<str> {
|
|
Cow::Borrowed(version::DENO_VERSION_INFO.version_or_git_hash())
|
|
}
|
|
|
|
fn get_current_exe_release_channel(&self) -> ReleaseChannel {
|
|
version::DENO_VERSION_INFO.release_channel
|
|
}
|
|
}
|
|
|
|
struct UpdateChecker<
|
|
TEnvironment: UpdateCheckerEnvironment,
|
|
TVersionProvider: VersionProvider,
|
|
> {
|
|
env: TEnvironment,
|
|
version_provider: TVersionProvider,
|
|
maybe_file: Option<CheckVersionFile>,
|
|
}
|
|
|
|
impl<
|
|
TEnvironment: UpdateCheckerEnvironment,
|
|
TVersionProvider: VersionProvider,
|
|
> UpdateChecker<TEnvironment, TVersionProvider>
|
|
{
|
|
pub fn new(env: TEnvironment, version_provider: TVersionProvider) -> Self {
|
|
let maybe_file = CheckVersionFile::parse(env.read_check_file());
|
|
Self {
|
|
env,
|
|
version_provider,
|
|
maybe_file,
|
|
}
|
|
}
|
|
|
|
pub fn should_check_for_new_version(&self) -> bool {
|
|
let Some(file) = &self.maybe_file else {
|
|
return true;
|
|
};
|
|
|
|
let last_check_age = self
|
|
.env
|
|
.current_time()
|
|
.signed_duration_since(file.last_checked);
|
|
last_check_age > chrono::Duration::hours(UPGRADE_CHECK_INTERVAL)
|
|
}
|
|
|
|
/// Returns the current exe release channel and a version if a new one is available and it should be prompted about.
|
|
pub fn should_prompt(&self) -> Option<(ReleaseChannel, String)> {
|
|
let file = self.maybe_file.as_ref()?;
|
|
// If the current version saved is not the actually current version of the binary
|
|
// It means
|
|
// - We already check for a new version today
|
|
// - The user have probably upgraded today
|
|
// So we should not prompt and wait for tomorrow for the latest version to be updated again
|
|
let current_version = self.version_provider.current_version();
|
|
if file.current_version != current_version {
|
|
return None;
|
|
}
|
|
if file.latest_version == current_version {
|
|
return None;
|
|
}
|
|
|
|
if let Ok(current) = Version::parse_standard(¤t_version) {
|
|
if let Ok(latest) = Version::parse_standard(&file.latest_version) {
|
|
if current >= latest {
|
|
return None;
|
|
}
|
|
}
|
|
}
|
|
|
|
let last_prompt_age = self
|
|
.env
|
|
.current_time()
|
|
.signed_duration_since(file.last_prompt);
|
|
if last_prompt_age > chrono::Duration::hours(UPGRADE_CHECK_INTERVAL) {
|
|
Some((file.current_release_channel, file.latest_version.clone()))
|
|
} else {
|
|
None
|
|
}
|
|
}
|
|
|
|
/// Store that we showed the update message to the user.
|
|
pub fn store_prompted(self) {
|
|
if let Some(file) = self.maybe_file {
|
|
self.env.write_check_file(
|
|
&file.with_last_prompt(self.env.current_time()).serialize(),
|
|
);
|
|
}
|
|
}
|
|
}
|
|
|
|
fn get_minor_version_blog_post_url(semver: &Version) -> String {
|
|
format!("https://deno.com/blog/v{}.{}", semver.major, semver.minor)
|
|
}
|
|
|
|
fn get_rc_version_blog_post_url(semver: &Version) -> String {
|
|
format!(
|
|
"https://deno.com/blog/v{}.{}-rc-{}",
|
|
semver.major, semver.minor, semver.pre[1]
|
|
)
|
|
}
|
|
|
|
async fn print_release_notes(
|
|
current_version: &str,
|
|
new_version: &str,
|
|
client: &HttpClient,
|
|
) {
|
|
let Ok(current_semver) = Version::parse_standard(current_version) else {
|
|
return;
|
|
};
|
|
let Ok(new_semver) = Version::parse_standard(new_version) else {
|
|
return;
|
|
};
|
|
|
|
let is_switching_from_deno1_to_deno2 =
|
|
new_semver.major == 2 && current_semver.major == 1;
|
|
let is_deno_2_rc = new_semver.major == 2
|
|
&& new_semver.minor == 0
|
|
&& new_semver.patch == 0
|
|
&& new_semver.pre.first() == Some(&"rc".to_string());
|
|
|
|
if is_deno_2_rc || is_switching_from_deno1_to_deno2 {
|
|
log::info!(
|
|
"{}\n\n {}\n",
|
|
colors::gray("Migration guide:"),
|
|
colors::bold(
|
|
"https://docs.deno.com/runtime/manual/advanced/migrate_deprecations"
|
|
)
|
|
);
|
|
}
|
|
|
|
if is_deno_2_rc {
|
|
log::info!(
|
|
"{}\n\n {}\n",
|
|
colors::gray("If you find a bug, please report to:"),
|
|
colors::bold("https://github.com/denoland/deno/issues/new")
|
|
);
|
|
|
|
// Check if there's blog post entry for this release
|
|
let blog_url_str = get_rc_version_blog_post_url(&new_semver);
|
|
let blog_url = Url::parse(&blog_url_str).unwrap();
|
|
if client.download(blog_url).await.is_ok() {
|
|
log::info!(
|
|
"{}\n\n {}\n",
|
|
colors::gray("Blog post:"),
|
|
colors::bold(blog_url_str)
|
|
);
|
|
}
|
|
return;
|
|
}
|
|
|
|
let should_print = current_semver.major != new_semver.major
|
|
|| current_semver.minor != new_semver.minor;
|
|
|
|
if !should_print {
|
|
return;
|
|
}
|
|
|
|
log::info!(
|
|
"{}\n\n {}\n",
|
|
colors::gray("Release notes:"),
|
|
colors::bold(format!(
|
|
"https://github.com/denoland/deno/releases/tag/v{}",
|
|
&new_version,
|
|
))
|
|
);
|
|
log::info!(
|
|
"{}\n\n {}\n",
|
|
colors::gray("Blog post:"),
|
|
colors::bold(get_minor_version_blog_post_url(&new_semver))
|
|
);
|
|
}
|
|
|
|
pub fn upgrade_check_enabled() -> bool {
|
|
matches!(
|
|
env::var("DENO_NO_UPDATE_CHECK"),
|
|
Err(env::VarError::NotPresent)
|
|
)
|
|
}
|
|
|
|
pub fn check_for_upgrades(
|
|
http_client_provider: Arc<HttpClientProvider>,
|
|
cache_file_path: PathBuf,
|
|
) {
|
|
if !upgrade_check_enabled() {
|
|
return;
|
|
}
|
|
|
|
let env = RealUpdateCheckerEnvironment::new(cache_file_path);
|
|
let version_provider = RealVersionProvider::new(
|
|
http_client_provider.clone(),
|
|
UpgradeCheckKind::Execution,
|
|
);
|
|
let update_checker = UpdateChecker::new(env, version_provider);
|
|
|
|
if update_checker.should_check_for_new_version() {
|
|
let env = update_checker.env.clone();
|
|
let version_provider = update_checker.version_provider.clone();
|
|
// do this asynchronously on a separate task
|
|
spawn(async move {
|
|
// Sleep for a small amount of time to not unnecessarily impact startup
|
|
// time.
|
|
tokio::time::sleep(UPGRADE_CHECK_FETCH_DELAY).await;
|
|
|
|
fetch_and_store_latest_version(&env, &version_provider).await;
|
|
|
|
// text is used by the test suite
|
|
log::debug!("Finished upgrade checker.")
|
|
});
|
|
}
|
|
|
|
// Don't bother doing any more computation if we're not in TTY environment.
|
|
let should_prompt =
|
|
log::log_enabled!(log::Level::Info) && std::io::stderr().is_terminal();
|
|
|
|
if !should_prompt {
|
|
return;
|
|
}
|
|
|
|
// Print a message if an update is available
|
|
if let Some((release_channel, upgrade_version)) =
|
|
update_checker.should_prompt()
|
|
{
|
|
match release_channel {
|
|
ReleaseChannel::Stable => {
|
|
log::info!(
|
|
"{} {} → {} {}",
|
|
colors::green("A new release of Deno is available:"),
|
|
colors::cyan(version::DENO_VERSION_INFO.deno),
|
|
colors::cyan(&upgrade_version),
|
|
colors::italic_gray("Run `deno upgrade` to install it.")
|
|
);
|
|
}
|
|
ReleaseChannel::Canary => {
|
|
log::info!(
|
|
"{} {}",
|
|
colors::green("A new canary release of Deno is available."),
|
|
colors::italic_gray("Run `deno upgrade canary` to install it.")
|
|
);
|
|
}
|
|
ReleaseChannel::Rc => {
|
|
log::info!(
|
|
"{} {}",
|
|
colors::green("A new release candidate of Deno is available."),
|
|
colors::italic_gray("Run `deno upgrade rc` to install it.")
|
|
);
|
|
}
|
|
ReleaseChannel::Lts => {
|
|
log::info!(
|
|
"{} {} → {} {}",
|
|
colors::green("A new LTS release of Deno is available:"),
|
|
colors::cyan(version::DENO_VERSION_INFO.deno),
|
|
colors::cyan(&upgrade_version),
|
|
colors::italic_gray("Run `deno upgrade lts` to install it.")
|
|
);
|
|
}
|
|
}
|
|
|
|
update_checker.store_prompted();
|
|
}
|
|
}
|
|
|
|
#[derive(Debug, Clone, PartialEq, Eq)]
|
|
pub struct LspVersionUpgradeInfo {
|
|
pub latest_version: String,
|
|
pub is_canary: bool,
|
|
}
|
|
|
|
pub async fn check_for_upgrades_for_lsp(
|
|
http_client_provider: Arc<HttpClientProvider>,
|
|
) -> Result<Option<LspVersionUpgradeInfo>, AnyError> {
|
|
if !upgrade_check_enabled() {
|
|
return Ok(None);
|
|
}
|
|
|
|
let version_provider =
|
|
RealVersionProvider::new(http_client_provider, UpgradeCheckKind::Lsp);
|
|
check_for_upgrades_for_lsp_with_provider(&version_provider).await
|
|
}
|
|
|
|
async fn check_for_upgrades_for_lsp_with_provider(
|
|
version_provider: &impl VersionProvider,
|
|
) -> Result<Option<LspVersionUpgradeInfo>, AnyError> {
|
|
let release_channel = version_provider.get_current_exe_release_channel();
|
|
let latest_version = version_provider.latest_version(release_channel).await?;
|
|
let current_version = version_provider.current_version();
|
|
|
|
// Nothing to upgrade
|
|
if current_version == latest_version.version_or_hash {
|
|
return Ok(None);
|
|
}
|
|
|
|
match release_channel {
|
|
ReleaseChannel::Stable | ReleaseChannel::Rc | ReleaseChannel::Lts => {
|
|
if let Ok(current) = Version::parse_standard(¤t_version) {
|
|
if let Ok(latest) =
|
|
Version::parse_standard(&latest_version.version_or_hash)
|
|
{
|
|
if current >= latest {
|
|
return Ok(None); // nothing to upgrade
|
|
}
|
|
}
|
|
}
|
|
Ok(Some(LspVersionUpgradeInfo {
|
|
latest_version: latest_version.version_or_hash,
|
|
is_canary: false,
|
|
}))
|
|
}
|
|
|
|
ReleaseChannel::Canary => Ok(Some(LspVersionUpgradeInfo {
|
|
latest_version: latest_version.version_or_hash,
|
|
is_canary: true,
|
|
})),
|
|
}
|
|
}
|
|
|
|
async fn fetch_and_store_latest_version<
|
|
TEnvironment: UpdateCheckerEnvironment,
|
|
TVersionProvider: VersionProvider,
|
|
>(
|
|
env: &TEnvironment,
|
|
version_provider: &TVersionProvider,
|
|
) {
|
|
let release_channel = version_provider.get_current_exe_release_channel();
|
|
let Ok(latest_version) =
|
|
version_provider.latest_version(release_channel).await
|
|
else {
|
|
return;
|
|
};
|
|
|
|
let version_file = CheckVersionFile {
|
|
// put a date in the past here so that prompt can be shown on next run
|
|
last_prompt: env
|
|
.current_time()
|
|
.sub(chrono::Duration::hours(UPGRADE_CHECK_INTERVAL + 1)),
|
|
last_checked: env.current_time(),
|
|
current_version: version_provider.current_version().to_string(),
|
|
latest_version: latest_version.version_or_hash,
|
|
current_release_channel: release_channel,
|
|
};
|
|
|
|
env.write_check_file(&version_file.serialize());
|
|
}
|
|
|
|
pub async fn upgrade(
|
|
flags: Arc<Flags>,
|
|
upgrade_flags: UpgradeFlags,
|
|
) -> Result<(), AnyError> {
|
|
let factory = CliFactory::from_flags(flags);
|
|
let http_client_provider = factory.http_client_provider();
|
|
let client = http_client_provider.get_or_create()?;
|
|
let current_exe_path = std::env::current_exe()?;
|
|
let full_path_output_flag = match &upgrade_flags.output {
|
|
Some(output) => Some(
|
|
std::env::current_dir()
|
|
.context("failed getting cwd")?
|
|
.join(output),
|
|
),
|
|
None => None,
|
|
};
|
|
let output_exe_path =
|
|
full_path_output_flag.as_ref().unwrap_or(¤t_exe_path);
|
|
|
|
let permissions = set_exe_permissions(¤t_exe_path, output_exe_path)?;
|
|
|
|
let force_selection_of_new_version =
|
|
upgrade_flags.force || full_path_output_flag.is_some();
|
|
|
|
let requested_version =
|
|
RequestedVersion::from_upgrade_flags(upgrade_flags.clone())?;
|
|
|
|
log::info!("Current Deno version: v{}", version::DENO_VERSION_INFO.deno);
|
|
|
|
let maybe_selected_version_to_upgrade = match &requested_version {
|
|
RequestedVersion::Latest(channel) => {
|
|
find_latest_version_to_upgrade(
|
|
http_client_provider.clone(),
|
|
*channel,
|
|
force_selection_of_new_version,
|
|
)
|
|
.await?
|
|
}
|
|
RequestedVersion::SpecificVersion(channel, version) => {
|
|
select_specific_version_for_upgrade(
|
|
*channel,
|
|
version.clone(),
|
|
force_selection_of_new_version,
|
|
)?
|
|
}
|
|
};
|
|
|
|
let Some(selected_version_to_upgrade) = maybe_selected_version_to_upgrade
|
|
else {
|
|
return Ok(());
|
|
};
|
|
|
|
let download_url = get_download_url(
|
|
&selected_version_to_upgrade.version_or_hash,
|
|
requested_version.release_channel(),
|
|
)?;
|
|
log::info!("{}", colors::gray(format!("Downloading {}", &download_url)));
|
|
let Some(archive_data) = download_package(&client, download_url).await?
|
|
else {
|
|
log::error!("Download could not be found, aborting");
|
|
deno_runtime::exit(1)
|
|
};
|
|
|
|
log::info!(
|
|
"{}",
|
|
colors::gray(format!(
|
|
"Deno is upgrading to version {}",
|
|
&selected_version_to_upgrade.version_or_hash
|
|
))
|
|
);
|
|
|
|
let temp_dir = tempfile::TempDir::new()?;
|
|
let new_exe_path = archive::unpack_into_dir(archive::UnpackArgs {
|
|
exe_name: "deno",
|
|
archive_name: &ARCHIVE_NAME,
|
|
archive_data: &archive_data,
|
|
is_windows: cfg!(windows),
|
|
dest_path: temp_dir.path(),
|
|
})?;
|
|
fs::set_permissions(&new_exe_path, permissions)?;
|
|
check_exe(&new_exe_path)?;
|
|
|
|
if upgrade_flags.dry_run {
|
|
fs::remove_file(&new_exe_path)?;
|
|
log::info!("Upgraded successfully (dry run)");
|
|
if requested_version.release_channel() == ReleaseChannel::Stable {
|
|
print_release_notes(
|
|
version::DENO_VERSION_INFO.deno,
|
|
&selected_version_to_upgrade.version_or_hash,
|
|
&client,
|
|
)
|
|
.await;
|
|
}
|
|
drop(temp_dir);
|
|
return Ok(());
|
|
}
|
|
|
|
let output_exe_path =
|
|
full_path_output_flag.as_ref().unwrap_or(¤t_exe_path);
|
|
|
|
#[cfg(windows)]
|
|
kill_running_deno_lsp_processes();
|
|
|
|
let output_result = if *output_exe_path == current_exe_path {
|
|
replace_exe(&new_exe_path, output_exe_path)
|
|
} else {
|
|
fs::rename(&new_exe_path, output_exe_path)
|
|
.or_else(|_| fs::copy(&new_exe_path, output_exe_path).map(|_| ()))
|
|
};
|
|
check_windows_access_denied_error(output_result, output_exe_path)?;
|
|
|
|
log::info!(
|
|
"\nUpgraded successfully to Deno {} {}\n",
|
|
colors::green(selected_version_to_upgrade.display()),
|
|
colors::gray(&format!(
|
|
"({})",
|
|
selected_version_to_upgrade.release_channel.name()
|
|
))
|
|
);
|
|
if requested_version.release_channel() == ReleaseChannel::Stable {
|
|
print_release_notes(
|
|
version::DENO_VERSION_INFO.deno,
|
|
&selected_version_to_upgrade.version_or_hash,
|
|
&client,
|
|
)
|
|
.await;
|
|
}
|
|
|
|
drop(temp_dir); // delete the temp dir
|
|
Ok(())
|
|
}
|
|
|
|
#[derive(Debug, PartialEq)]
|
|
enum RequestedVersion {
|
|
Latest(ReleaseChannel),
|
|
SpecificVersion(ReleaseChannel, String),
|
|
}
|
|
|
|
impl RequestedVersion {
|
|
fn from_upgrade_flags(upgrade_flags: UpgradeFlags) -> Result<Self, AnyError> {
|
|
let is_canary = upgrade_flags.canary;
|
|
let re_hash = lazy_regex::regex!("^[0-9a-f]{40}$");
|
|
let channel = if is_canary {
|
|
ReleaseChannel::Canary
|
|
} else if upgrade_flags.release_candidate {
|
|
ReleaseChannel::Rc
|
|
} else {
|
|
ReleaseChannel::Stable
|
|
};
|
|
let mut maybe_passed_version = upgrade_flags.version.clone();
|
|
|
|
// TODO(bartlomieju): prefer flags first? This whole logic could be cleaned up...
|
|
if let Some(val) = &upgrade_flags.version_or_hash_or_channel {
|
|
if let Ok(channel) = ReleaseChannel::deserialize(&val.to_lowercase()) {
|
|
// TODO(bartlomieju): print error if any other flags passed?
|
|
return Ok(Self::Latest(channel));
|
|
} else if re_hash.is_match(val) {
|
|
return Ok(Self::SpecificVersion(
|
|
ReleaseChannel::Canary,
|
|
val.to_string(),
|
|
));
|
|
} else {
|
|
maybe_passed_version = Some(val.to_string());
|
|
}
|
|
}
|
|
|
|
let Some(passed_version) = maybe_passed_version else {
|
|
return Ok(Self::Latest(channel));
|
|
};
|
|
|
|
let passed_version = passed_version
|
|
.strip_prefix('v')
|
|
.unwrap_or(&passed_version)
|
|
.to_string();
|
|
|
|
let (channel, passed_version) = if is_canary {
|
|
if !re_hash.is_match(&passed_version) {
|
|
bail!(
|
|
"Invalid commit hash passed ({})\n\nPass a semver, or a full 40 character git commit hash, or a release channel name.\n\nUsage:\n{}",
|
|
colors::gray(passed_version),
|
|
UPGRADE_USAGE
|
|
);
|
|
}
|
|
|
|
(ReleaseChannel::Canary, passed_version)
|
|
} else {
|
|
let Ok(semver) = Version::parse_standard(&passed_version) else {
|
|
bail!(
|
|
"Invalid version passed ({})\n\nPass a semver, or a full 40 character git commit hash, or a release channel name.\n\nUsage:\n{}",
|
|
colors::gray(passed_version),
|
|
UPGRADE_USAGE
|
|
);
|
|
};
|
|
|
|
if semver.pre.contains(&"rc".to_string()) {
|
|
(ReleaseChannel::Rc, passed_version)
|
|
} else {
|
|
(ReleaseChannel::Stable, passed_version)
|
|
}
|
|
};
|
|
|
|
Ok(RequestedVersion::SpecificVersion(channel, passed_version))
|
|
}
|
|
|
|
/// Channels that use Git hashes as versions are considered canary.
|
|
pub fn release_channel(&self) -> ReleaseChannel {
|
|
match self {
|
|
Self::Latest(channel) => *channel,
|
|
Self::SpecificVersion(channel, _) => *channel,
|
|
}
|
|
}
|
|
}
|
|
|
|
fn select_specific_version_for_upgrade(
|
|
release_channel: ReleaseChannel,
|
|
version: String,
|
|
force: bool,
|
|
) -> Result<Option<AvailableVersion>, AnyError> {
|
|
let current_is_passed = match release_channel {
|
|
ReleaseChannel::Stable | ReleaseChannel::Rc | ReleaseChannel::Lts => {
|
|
version::DENO_VERSION_INFO.release_channel == release_channel
|
|
&& version::DENO_VERSION_INFO.deno == version
|
|
}
|
|
ReleaseChannel::Canary => version::DENO_VERSION_INFO.git_hash == version,
|
|
};
|
|
|
|
if !force && current_is_passed {
|
|
log::info!(
|
|
"Version {} is already installed",
|
|
version::DENO_VERSION_INFO.deno
|
|
);
|
|
return Ok(None);
|
|
}
|
|
|
|
Ok(Some(AvailableVersion {
|
|
version_or_hash: version,
|
|
release_channel,
|
|
}))
|
|
}
|
|
|
|
async fn find_latest_version_to_upgrade(
|
|
http_client_provider: Arc<HttpClientProvider>,
|
|
release_channel: ReleaseChannel,
|
|
force: bool,
|
|
) -> Result<Option<AvailableVersion>, AnyError> {
|
|
log::info!(
|
|
"{}",
|
|
colors::gray(&format!("Looking up {} version", release_channel.name()))
|
|
);
|
|
|
|
let client = http_client_provider.get_or_create()?;
|
|
|
|
let latest_version_found = match fetch_latest_version(
|
|
&client,
|
|
release_channel,
|
|
UpgradeCheckKind::Execution,
|
|
)
|
|
.await
|
|
{
|
|
Ok(v) => v,
|
|
Err(err) => {
|
|
if err.to_string().contains("Not found") {
|
|
bail!(
|
|
"No {} release available at the moment.",
|
|
release_channel.name()
|
|
);
|
|
} else {
|
|
return Err(err);
|
|
}
|
|
}
|
|
};
|
|
|
|
let (maybe_newer_latest_version, current_version) = match release_channel {
|
|
ReleaseChannel::Canary => {
|
|
let current_version = version::DENO_VERSION_INFO.git_hash;
|
|
let current_is_most_recent =
|
|
current_version == latest_version_found.version_or_hash;
|
|
|
|
if !force && current_is_most_recent {
|
|
(None, current_version)
|
|
} else {
|
|
(Some(latest_version_found), current_version)
|
|
}
|
|
}
|
|
ReleaseChannel::Stable | ReleaseChannel::Lts | ReleaseChannel::Rc => {
|
|
let current_version = version::DENO_VERSION_INFO.deno;
|
|
|
|
// If the current binary is not the same channel, we can skip
|
|
// computation if we're on a newer release - we're not.
|
|
if version::DENO_VERSION_INFO.release_channel != release_channel {
|
|
(Some(latest_version_found), current_version)
|
|
} else {
|
|
let current = Version::parse_standard(current_version)?;
|
|
let latest =
|
|
Version::parse_standard(&latest_version_found.version_or_hash)?;
|
|
let current_is_most_recent = current >= latest;
|
|
|
|
if !force && current_is_most_recent {
|
|
(None, current_version)
|
|
} else {
|
|
(Some(latest_version_found), current_version)
|
|
}
|
|
}
|
|
}
|
|
};
|
|
|
|
log::info!("");
|
|
if let Some(newer_latest_version) = maybe_newer_latest_version.as_ref() {
|
|
log::info!(
|
|
"Found latest {} version {}",
|
|
newer_latest_version.release_channel.name(),
|
|
color_print::cformat!("<g>{}</>", newer_latest_version.display())
|
|
);
|
|
} else {
|
|
log::info!(
|
|
"Local deno version {} is the most recent release",
|
|
color_print::cformat!("<g>{}</>", current_version)
|
|
);
|
|
}
|
|
log::info!("");
|
|
|
|
Ok(maybe_newer_latest_version)
|
|
}
|
|
|
|
#[derive(Debug, Clone, PartialEq)]
|
|
struct AvailableVersion {
|
|
version_or_hash: String,
|
|
release_channel: ReleaseChannel,
|
|
}
|
|
|
|
impl AvailableVersion {
|
|
/// Format display version, appending `v` before version number
|
|
/// for non-canary releases.
|
|
fn display(&self) -> Cow<str> {
|
|
match self.release_channel {
|
|
ReleaseChannel::Canary => Cow::Borrowed(&self.version_or_hash),
|
|
_ => Cow::Owned(format!("v{}", self.version_or_hash)),
|
|
}
|
|
}
|
|
}
|
|
|
|
async fn fetch_latest_version(
|
|
client: &HttpClient,
|
|
release_channel: ReleaseChannel,
|
|
check_kind: UpgradeCheckKind,
|
|
) -> Result<AvailableVersion, AnyError> {
|
|
let url = get_latest_version_url(release_channel, env!("TARGET"), check_kind);
|
|
let text = client.download_text(url.parse()?).await?;
|
|
let version = normalize_version_from_server(release_channel, &text)?;
|
|
Ok(version)
|
|
}
|
|
|
|
fn normalize_version_from_server(
|
|
release_channel: ReleaseChannel,
|
|
text: &str,
|
|
) -> Result<AvailableVersion, AnyError> {
|
|
let text = text.trim();
|
|
match release_channel {
|
|
ReleaseChannel::Stable | ReleaseChannel::Rc | ReleaseChannel::Lts => {
|
|
let v = text.trim_start_matches('v').to_string();
|
|
Ok(AvailableVersion {
|
|
version_or_hash: v.to_string(),
|
|
release_channel,
|
|
})
|
|
}
|
|
ReleaseChannel::Canary => Ok(AvailableVersion {
|
|
version_or_hash: text.to_string(),
|
|
release_channel,
|
|
}),
|
|
}
|
|
}
|
|
|
|
fn get_latest_version_url(
|
|
release_channel: ReleaseChannel,
|
|
target_tuple: &str,
|
|
check_kind: UpgradeCheckKind,
|
|
) -> String {
|
|
let file_name = match release_channel {
|
|
ReleaseChannel::Stable => Cow::Borrowed("release-latest.txt"),
|
|
ReleaseChannel::Canary => {
|
|
Cow::Owned(format!("canary-{target_tuple}-latest.txt"))
|
|
}
|
|
ReleaseChannel::Rc => Cow::Borrowed("release-rc-latest.txt"),
|
|
ReleaseChannel::Lts => Cow::Borrowed("release-lts-latest.txt"),
|
|
};
|
|
let query_param = match check_kind {
|
|
UpgradeCheckKind::Execution => "",
|
|
UpgradeCheckKind::Lsp => "?lsp",
|
|
};
|
|
format!("{}/{}{}", base_upgrade_url(), file_name, query_param)
|
|
}
|
|
|
|
fn base_upgrade_url() -> Cow<'static, str> {
|
|
// this is used by the test suite
|
|
if let Ok(url) = env::var("DENO_DONT_USE_INTERNAL_BASE_UPGRADE_URL") {
|
|
Cow::Owned(url)
|
|
} else {
|
|
Cow::Borrowed("https://dl.deno.land")
|
|
}
|
|
}
|
|
|
|
fn get_download_url(
|
|
version: &str,
|
|
release_channel: ReleaseChannel,
|
|
) -> Result<Url, AnyError> {
|
|
let download_url = match release_channel {
|
|
ReleaseChannel::Stable => {
|
|
format!("{}/download/v{}/{}", RELEASE_URL, version, *ARCHIVE_NAME)
|
|
}
|
|
ReleaseChannel::Rc => {
|
|
format!("{}/v{}/{}", DL_RELEASE_URL, version, *ARCHIVE_NAME)
|
|
}
|
|
ReleaseChannel::Canary => {
|
|
format!("{}/{}/{}", CANARY_URL, version, *ARCHIVE_NAME)
|
|
}
|
|
ReleaseChannel::Lts => {
|
|
format!("{}/v{}/{}", DL_RELEASE_URL, version, *ARCHIVE_NAME)
|
|
}
|
|
};
|
|
|
|
Url::parse(&download_url).with_context(|| {
|
|
format!(
|
|
"Failed to parse URL to download new release: {}",
|
|
download_url
|
|
)
|
|
})
|
|
}
|
|
|
|
async fn download_package(
|
|
client: &HttpClient,
|
|
download_url: Url,
|
|
) -> Result<Option<Vec<u8>>, AnyError> {
|
|
let progress_bar = ProgressBar::new(ProgressBarStyle::DownloadBars);
|
|
// provide an empty string here in order to prefer the downloading
|
|
// text above which will stay alive after the progress bars are complete
|
|
let progress = progress_bar.update("");
|
|
let maybe_bytes = client
|
|
.download_with_progress_and_retries(download_url.clone(), None, &progress)
|
|
.await
|
|
.with_context(|| format!("Failed downloading {download_url}. The version you requested may not have been built for the current architecture."))?;
|
|
Ok(maybe_bytes)
|
|
}
|
|
|
|
fn replace_exe(from: &Path, to: &Path) -> Result<(), std::io::Error> {
|
|
if cfg!(windows) {
|
|
// On windows you cannot replace the currently running executable.
|
|
// so first we rename it to deno.old.exe
|
|
fs::rename(to, to.with_extension("old.exe"))?;
|
|
} else {
|
|
fs::remove_file(to)?;
|
|
}
|
|
// Windows cannot rename files across device boundaries, so if rename fails,
|
|
// we try again with copy.
|
|
fs::rename(from, to).or_else(|_| fs::copy(from, to).map(|_| ()))?;
|
|
Ok(())
|
|
}
|
|
|
|
fn check_windows_access_denied_error(
|
|
output_result: Result<(), std::io::Error>,
|
|
output_exe_path: &Path,
|
|
) -> Result<(), AnyError> {
|
|
let Err(err) = output_result else {
|
|
return Ok(());
|
|
};
|
|
|
|
if !cfg!(windows) {
|
|
return Err(err.into());
|
|
}
|
|
|
|
const WIN_ERROR_ACCESS_DENIED: i32 = 5;
|
|
if err.raw_os_error() != Some(WIN_ERROR_ACCESS_DENIED) {
|
|
return Err(err.into());
|
|
};
|
|
|
|
Err(err).with_context(|| {
|
|
format!(
|
|
concat!(
|
|
"Could not replace the deno executable. This may be because an ",
|
|
"existing deno process is running. Please ensure there are no ",
|
|
"running deno processes (ex. Stop-Process -Name deno ; deno {}), ",
|
|
"close any editors before upgrading, and ensure you have ",
|
|
"sufficient permission to '{}'."
|
|
),
|
|
// skip the first argument, which is the executable path
|
|
std::env::args().skip(1).collect::<Vec<_>>().join(" "),
|
|
output_exe_path.display(),
|
|
)
|
|
})
|
|
}
|
|
|
|
#[cfg(windows)]
|
|
fn kill_running_deno_lsp_processes() {
|
|
// limit this to `deno lsp` invocations to avoid killing important programs someone might be running
|
|
let is_debug = log::log_enabled!(log::Level::Debug);
|
|
let get_pipe = || {
|
|
if is_debug {
|
|
std::process::Stdio::inherit()
|
|
} else {
|
|
std::process::Stdio::null()
|
|
}
|
|
};
|
|
let _ = Command::new("powershell.exe")
|
|
.args([
|
|
"-Command",
|
|
r#"Get-WmiObject Win32_Process | Where-Object {
|
|
$_.Name -eq 'deno.exe' -and
|
|
$_.CommandLine -match '^(?:\"[^\"]+\"|\S+)\s+lsp\b'
|
|
} | ForEach-Object {
|
|
if ($_.Terminate()) {
|
|
Write-Host 'Terminated:' $_.ProcessId
|
|
}
|
|
}"#,
|
|
])
|
|
.stdout(get_pipe())
|
|
.stderr(get_pipe())
|
|
.output();
|
|
}
|
|
|
|
fn set_exe_permissions(
|
|
current_exe_path: &Path,
|
|
output_exe_path: &Path,
|
|
) -> Result<std::fs::Permissions, AnyError> {
|
|
let Ok(metadata) = fs::metadata(output_exe_path) else {
|
|
let metadata = fs::metadata(current_exe_path)?;
|
|
return Ok(metadata.permissions());
|
|
};
|
|
|
|
let permissions = metadata.permissions();
|
|
if permissions.readonly() {
|
|
bail!(
|
|
"You do not have write permission to {}",
|
|
output_exe_path.display()
|
|
);
|
|
}
|
|
#[cfg(unix)]
|
|
if std::os::unix::fs::MetadataExt::uid(&metadata) == 0
|
|
&& !nix::unistd::Uid::effective().is_root()
|
|
{
|
|
bail!(concat!(
|
|
"You don't have write permission to {} because it's owned by root.\n",
|
|
"Consider updating deno through your package manager if its installed from it.\n",
|
|
"Otherwise run `deno upgrade` as root.",
|
|
), output_exe_path.display());
|
|
}
|
|
Ok(permissions)
|
|
}
|
|
|
|
fn check_exe(exe_path: &Path) -> Result<(), AnyError> {
|
|
let output = Command::new(exe_path)
|
|
.arg("-V")
|
|
.stderr(std::process::Stdio::inherit())
|
|
.output()?;
|
|
if !output.status.success() {
|
|
bail!(
|
|
"Failed to validate Deno executable. This may be because your OS is unsupported or the executable is corrupted"
|
|
)
|
|
} else {
|
|
Ok(())
|
|
}
|
|
}
|
|
|
|
#[derive(Debug)]
|
|
struct CheckVersionFile {
|
|
pub last_prompt: chrono::DateTime<chrono::Utc>,
|
|
pub last_checked: chrono::DateTime<chrono::Utc>,
|
|
pub current_version: String,
|
|
pub latest_version: String,
|
|
pub current_release_channel: ReleaseChannel,
|
|
}
|
|
|
|
impl CheckVersionFile {
|
|
pub fn parse(content: String) -> Option<Self> {
|
|
let split_content = content.split('!').collect::<Vec<_>>();
|
|
|
|
if split_content.len() != 5 {
|
|
return None;
|
|
}
|
|
|
|
let latest_version = split_content[2].trim().to_owned();
|
|
if latest_version.is_empty() {
|
|
return None;
|
|
}
|
|
let current_version = split_content[3].trim().to_owned();
|
|
if current_version.is_empty() {
|
|
return None;
|
|
}
|
|
let current_release_channel = split_content[4].trim().to_owned();
|
|
if current_release_channel.is_empty() {
|
|
return None;
|
|
}
|
|
let Ok(current_release_channel) =
|
|
ReleaseChannel::deserialize(¤t_release_channel)
|
|
else {
|
|
return None;
|
|
};
|
|
|
|
let last_prompt = chrono::DateTime::parse_from_rfc3339(split_content[0])
|
|
.map(|dt| dt.with_timezone(&chrono::Utc))
|
|
.ok()?;
|
|
let last_checked = chrono::DateTime::parse_from_rfc3339(split_content[1])
|
|
.map(|dt| dt.with_timezone(&chrono::Utc))
|
|
.ok()?;
|
|
|
|
Some(CheckVersionFile {
|
|
last_prompt,
|
|
last_checked,
|
|
current_version,
|
|
latest_version,
|
|
current_release_channel,
|
|
})
|
|
}
|
|
|
|
fn serialize(&self) -> String {
|
|
format!(
|
|
"{}!{}!{}!{}!{}",
|
|
self.last_prompt.to_rfc3339(),
|
|
self.last_checked.to_rfc3339(),
|
|
self.latest_version,
|
|
self.current_version,
|
|
self.current_release_channel.serialize()
|
|
)
|
|
}
|
|
|
|
fn with_last_prompt(self, dt: chrono::DateTime<chrono::Utc>) -> Self {
|
|
Self {
|
|
last_prompt: dt,
|
|
..self
|
|
}
|
|
}
|
|
}
|
|
|
|
#[cfg(test)]
|
|
mod test {
|
|
use std::cell::RefCell;
|
|
use std::rc::Rc;
|
|
|
|
use test_util::assert_contains;
|
|
|
|
use super::*;
|
|
|
|
#[test]
|
|
fn test_requested_version() {
|
|
let mut upgrade_flags = UpgradeFlags {
|
|
dry_run: false,
|
|
force: false,
|
|
release_candidate: false,
|
|
canary: false,
|
|
version: None,
|
|
output: None,
|
|
version_or_hash_or_channel: None,
|
|
};
|
|
|
|
let req_ver =
|
|
RequestedVersion::from_upgrade_flags(upgrade_flags.clone()).unwrap();
|
|
assert_eq!(req_ver, RequestedVersion::Latest(ReleaseChannel::Stable));
|
|
|
|
upgrade_flags.version = Some("1.46.0".to_string());
|
|
let req_ver =
|
|
RequestedVersion::from_upgrade_flags(upgrade_flags.clone()).unwrap();
|
|
assert_eq!(
|
|
req_ver,
|
|
RequestedVersion::SpecificVersion(
|
|
ReleaseChannel::Stable,
|
|
"1.46.0".to_string()
|
|
)
|
|
);
|
|
|
|
upgrade_flags.version = None;
|
|
upgrade_flags.canary = true;
|
|
let req_ver =
|
|
RequestedVersion::from_upgrade_flags(upgrade_flags.clone()).unwrap();
|
|
assert_eq!(req_ver, RequestedVersion::Latest(ReleaseChannel::Canary));
|
|
|
|
upgrade_flags.version =
|
|
Some("5c69b4861b52ab406e73b9cd85c254f0505cb20f".to_string());
|
|
let req_ver =
|
|
RequestedVersion::from_upgrade_flags(upgrade_flags.clone()).unwrap();
|
|
assert_eq!(
|
|
req_ver,
|
|
RequestedVersion::SpecificVersion(
|
|
ReleaseChannel::Canary,
|
|
"5c69b4861b52ab406e73b9cd85c254f0505cb20f".to_string()
|
|
)
|
|
);
|
|
|
|
upgrade_flags.version = None;
|
|
upgrade_flags.canary = false;
|
|
upgrade_flags.release_candidate = true;
|
|
let req_ver =
|
|
RequestedVersion::from_upgrade_flags(upgrade_flags.clone()).unwrap();
|
|
assert_eq!(req_ver, RequestedVersion::Latest(ReleaseChannel::Rc));
|
|
|
|
upgrade_flags.release_candidate = false;
|
|
upgrade_flags.version_or_hash_or_channel = Some("v1.46.5".to_string());
|
|
let req_ver =
|
|
RequestedVersion::from_upgrade_flags(upgrade_flags.clone()).unwrap();
|
|
assert_eq!(
|
|
req_ver,
|
|
RequestedVersion::SpecificVersion(
|
|
ReleaseChannel::Stable,
|
|
"1.46.5".to_string()
|
|
)
|
|
);
|
|
|
|
upgrade_flags.version_or_hash_or_channel = Some("2.0.0-rc.0".to_string());
|
|
let req_ver =
|
|
RequestedVersion::from_upgrade_flags(upgrade_flags.clone()).unwrap();
|
|
assert_eq!(
|
|
req_ver,
|
|
RequestedVersion::SpecificVersion(
|
|
ReleaseChannel::Rc,
|
|
"2.0.0-rc.0".to_string()
|
|
)
|
|
);
|
|
|
|
upgrade_flags.version_or_hash_or_channel = Some("canary".to_string());
|
|
let req_ver =
|
|
RequestedVersion::from_upgrade_flags(upgrade_flags.clone()).unwrap();
|
|
assert_eq!(req_ver, RequestedVersion::Latest(ReleaseChannel::Canary,));
|
|
|
|
upgrade_flags.version_or_hash_or_channel = Some("rc".to_string());
|
|
let req_ver =
|
|
RequestedVersion::from_upgrade_flags(upgrade_flags.clone()).unwrap();
|
|
assert_eq!(req_ver, RequestedVersion::Latest(ReleaseChannel::Rc,));
|
|
|
|
upgrade_flags.version_or_hash_or_channel =
|
|
Some("5c69b4861b52ab406e73b9cd85c254f0505cb20f".to_string());
|
|
let req_ver =
|
|
RequestedVersion::from_upgrade_flags(upgrade_flags.clone()).unwrap();
|
|
assert_eq!(
|
|
req_ver,
|
|
RequestedVersion::SpecificVersion(
|
|
ReleaseChannel::Canary,
|
|
"5c69b4861b52ab406e73b9cd85c254f0505cb20f".to_string()
|
|
)
|
|
);
|
|
|
|
upgrade_flags.version_or_hash_or_channel =
|
|
Some("5c69b4861b52a".to_string());
|
|
let err = RequestedVersion::from_upgrade_flags(upgrade_flags.clone())
|
|
.unwrap_err()
|
|
.to_string();
|
|
assert_contains!(err, "Invalid version passed");
|
|
assert_contains!(
|
|
err,
|
|
"Pass a semver, or a full 40 character git commit hash, or a release channel name."
|
|
);
|
|
|
|
upgrade_flags.version_or_hash_or_channel = Some("11.asd.1324".to_string());
|
|
let err = RequestedVersion::from_upgrade_flags(upgrade_flags.clone())
|
|
.unwrap_err()
|
|
.to_string();
|
|
assert_contains!(err, "Invalid version passed");
|
|
assert_contains!(
|
|
err,
|
|
"Pass a semver, or a full 40 character git commit hash, or a release channel name."
|
|
);
|
|
}
|
|
|
|
#[test]
|
|
fn test_parse_upgrade_check_file() {
|
|
// NOTE(bartlomieju): pre-1.46 format
|
|
let maybe_file = CheckVersionFile::parse(
|
|
"2020-01-01T00:00:00+00:00!2020-01-01T00:00:00+00:00!1.2.3!1.2.2"
|
|
.to_string(),
|
|
);
|
|
assert!(maybe_file.is_none());
|
|
// NOTE(bartlomieju): post-1.46 format
|
|
let file = CheckVersionFile::parse(
|
|
"2020-01-01T00:00:00+00:00!2020-01-01T00:00:00+00:00!1.2.3!1.2.2!stable"
|
|
.to_string(),
|
|
)
|
|
.unwrap();
|
|
assert_eq!(
|
|
file.last_prompt.to_rfc3339(),
|
|
"2020-01-01T00:00:00+00:00".to_string()
|
|
);
|
|
assert_eq!(
|
|
file.last_checked.to_rfc3339(),
|
|
"2020-01-01T00:00:00+00:00".to_string()
|
|
);
|
|
assert_eq!(file.latest_version, "1.2.3".to_string());
|
|
assert_eq!(file.current_version, "1.2.2".to_string());
|
|
assert_eq!(file.current_release_channel, ReleaseChannel::Stable);
|
|
|
|
let result =
|
|
CheckVersionFile::parse("2020-01-01T00:00:00+00:00!".to_string());
|
|
assert!(result.is_none());
|
|
|
|
let result = CheckVersionFile::parse("garbage!test".to_string());
|
|
assert!(result.is_none());
|
|
|
|
let result = CheckVersionFile::parse("test".to_string());
|
|
assert!(result.is_none());
|
|
}
|
|
|
|
#[test]
|
|
fn test_serialize_upgrade_check_file() {
|
|
let mut file = CheckVersionFile {
|
|
last_prompt: chrono::DateTime::parse_from_rfc3339("2020-01-01T00:00:00Z")
|
|
.unwrap()
|
|
.with_timezone(&chrono::Utc),
|
|
last_checked: chrono::DateTime::parse_from_rfc3339(
|
|
"2020-01-01T00:00:00Z",
|
|
)
|
|
.unwrap()
|
|
.with_timezone(&chrono::Utc),
|
|
latest_version: "1.2.3".to_string(),
|
|
current_version: "1.2.2".to_string(),
|
|
current_release_channel: ReleaseChannel::Stable,
|
|
};
|
|
assert_eq!(
|
|
file.serialize(),
|
|
"2020-01-01T00:00:00+00:00!2020-01-01T00:00:00+00:00!1.2.3!1.2.2!stable"
|
|
);
|
|
file.current_release_channel = ReleaseChannel::Canary;
|
|
assert_eq!(
|
|
file.serialize(),
|
|
"2020-01-01T00:00:00+00:00!2020-01-01T00:00:00+00:00!1.2.3!1.2.2!canary"
|
|
);
|
|
file.current_release_channel = ReleaseChannel::Rc;
|
|
assert_eq!(
|
|
file.serialize(),
|
|
"2020-01-01T00:00:00+00:00!2020-01-01T00:00:00+00:00!1.2.3!1.2.2!rc"
|
|
);
|
|
file.current_release_channel = ReleaseChannel::Lts;
|
|
assert_eq!(
|
|
file.serialize(),
|
|
"2020-01-01T00:00:00+00:00!2020-01-01T00:00:00+00:00!1.2.3!1.2.2!lts"
|
|
);
|
|
}
|
|
|
|
#[derive(Clone)]
|
|
struct TestUpdateCheckerEnvironment {
|
|
file_text: Rc<RefCell<String>>,
|
|
release_channel: Rc<RefCell<ReleaseChannel>>,
|
|
current_version: Rc<RefCell<String>>,
|
|
latest_version: Rc<RefCell<Result<AvailableVersion, String>>>,
|
|
time: Rc<RefCell<chrono::DateTime<chrono::Utc>>>,
|
|
}
|
|
|
|
impl TestUpdateCheckerEnvironment {
|
|
pub fn new() -> Self {
|
|
Self {
|
|
file_text: Default::default(),
|
|
current_version: Default::default(),
|
|
release_channel: Rc::new(RefCell::new(ReleaseChannel::Stable)),
|
|
latest_version: Rc::new(RefCell::new(Ok(AvailableVersion {
|
|
version_or_hash: "".to_string(),
|
|
release_channel: ReleaseChannel::Stable,
|
|
}))),
|
|
time: Rc::new(RefCell::new(chrono::Utc::now())),
|
|
}
|
|
}
|
|
|
|
pub fn add_hours(&self, hours: i64) {
|
|
let mut time = self.time.borrow_mut();
|
|
*time = time
|
|
.checked_add_signed(chrono::Duration::hours(hours))
|
|
.unwrap();
|
|
}
|
|
|
|
pub fn set_file_text(&self, text: &str) {
|
|
*self.file_text.borrow_mut() = text.to_string();
|
|
}
|
|
|
|
pub fn set_current_version(&self, version: &str) {
|
|
*self.current_version.borrow_mut() = version.to_string();
|
|
}
|
|
|
|
pub fn set_latest_version(
|
|
&self,
|
|
version: &str,
|
|
release_channel: ReleaseChannel,
|
|
) {
|
|
*self.latest_version.borrow_mut() = Ok(AvailableVersion {
|
|
version_or_hash: version.to_string(),
|
|
release_channel,
|
|
});
|
|
}
|
|
|
|
pub fn set_latest_version_err(&self, err: &str) {
|
|
*self.latest_version.borrow_mut() = Err(err.to_string());
|
|
}
|
|
|
|
pub fn set_release_channel(&self, channel: ReleaseChannel) {
|
|
*self.release_channel.borrow_mut() = channel;
|
|
}
|
|
}
|
|
|
|
#[async_trait(?Send)]
|
|
impl VersionProvider for TestUpdateCheckerEnvironment {
|
|
// TODO(bartlomieju): update to handle `Lts` and `Rc` channels
|
|
async fn latest_version(
|
|
&self,
|
|
_release_channel: ReleaseChannel,
|
|
) -> Result<AvailableVersion, AnyError> {
|
|
match self.latest_version.borrow().clone() {
|
|
Ok(result) => Ok(result),
|
|
Err(err) => bail!("{}", err),
|
|
}
|
|
}
|
|
|
|
fn current_version(&self) -> Cow<str> {
|
|
Cow::Owned(self.current_version.borrow().clone())
|
|
}
|
|
|
|
fn get_current_exe_release_channel(&self) -> ReleaseChannel {
|
|
*self.release_channel.borrow()
|
|
}
|
|
}
|
|
|
|
impl UpdateCheckerEnvironment for TestUpdateCheckerEnvironment {
|
|
fn read_check_file(&self) -> String {
|
|
self.file_text.borrow().clone()
|
|
}
|
|
|
|
fn write_check_file(&self, text: &str) {
|
|
self.set_file_text(text);
|
|
}
|
|
|
|
fn current_time(&self) -> chrono::DateTime<chrono::Utc> {
|
|
*self.time.borrow()
|
|
}
|
|
}
|
|
|
|
#[tokio::test]
|
|
async fn test_update_checker() {
|
|
let env = TestUpdateCheckerEnvironment::new();
|
|
env.set_current_version("1.0.0");
|
|
env.set_latest_version("1.1.0", ReleaseChannel::Stable);
|
|
let checker = UpdateChecker::new(env.clone(), env.clone());
|
|
|
|
// no version, so we should check, but not prompt
|
|
assert!(checker.should_check_for_new_version());
|
|
assert_eq!(checker.should_prompt(), None);
|
|
|
|
// store the latest version
|
|
fetch_and_store_latest_version(&env, &env).await;
|
|
|
|
// reload
|
|
let checker = UpdateChecker::new(env.clone(), env.clone());
|
|
|
|
// should not check for latest version because we just did
|
|
assert!(!checker.should_check_for_new_version());
|
|
// but should prompt
|
|
assert_eq!(
|
|
checker.should_prompt(),
|
|
Some((ReleaseChannel::Stable, "1.1.0".to_string()))
|
|
);
|
|
|
|
// fast forward an hour and bump the latest version
|
|
env.add_hours(1);
|
|
env.set_latest_version("1.2.0", ReleaseChannel::Stable);
|
|
assert!(!checker.should_check_for_new_version());
|
|
assert_eq!(
|
|
checker.should_prompt(),
|
|
Some((ReleaseChannel::Stable, "1.1.0".to_string()))
|
|
);
|
|
|
|
// fast forward again and it should check for a newer version
|
|
env.add_hours(UPGRADE_CHECK_INTERVAL);
|
|
assert!(checker.should_check_for_new_version());
|
|
assert_eq!(
|
|
checker.should_prompt(),
|
|
Some((ReleaseChannel::Stable, "1.1.0".to_string()))
|
|
);
|
|
|
|
fetch_and_store_latest_version(&env, &env).await;
|
|
|
|
// reload and store that we prompted
|
|
let checker = UpdateChecker::new(env.clone(), env.clone());
|
|
assert!(!checker.should_check_for_new_version());
|
|
assert_eq!(
|
|
checker.should_prompt(),
|
|
Some((ReleaseChannel::Stable, "1.2.0".to_string()))
|
|
);
|
|
checker.store_prompted();
|
|
|
|
// reload and it should now say not to prompt
|
|
let checker = UpdateChecker::new(env.clone(), env.clone());
|
|
assert!(!checker.should_check_for_new_version());
|
|
assert_eq!(checker.should_prompt(), None);
|
|
|
|
// but if we fast forward past the upgrade interval it should prompt again
|
|
env.add_hours(UPGRADE_CHECK_INTERVAL + 1);
|
|
assert!(checker.should_check_for_new_version());
|
|
assert_eq!(
|
|
checker.should_prompt(),
|
|
Some((ReleaseChannel::Stable, "1.2.0".to_string()))
|
|
);
|
|
|
|
// upgrade the version and it should stop prompting
|
|
env.set_current_version("1.2.0");
|
|
assert!(checker.should_check_for_new_version());
|
|
assert_eq!(checker.should_prompt(), None);
|
|
|
|
// now try failing when fetching the latest version
|
|
env.add_hours(UPGRADE_CHECK_INTERVAL + 1);
|
|
env.set_latest_version_err("Failed");
|
|
env.set_latest_version("1.3.0", ReleaseChannel::Stable);
|
|
|
|
// this will silently fail
|
|
fetch_and_store_latest_version(&env, &env).await;
|
|
assert!(checker.should_check_for_new_version());
|
|
assert_eq!(checker.should_prompt(), None);
|
|
|
|
// now switch to RC release
|
|
env.set_release_channel(ReleaseChannel::Rc);
|
|
env.set_current_version("1.46.0-rc.0");
|
|
env.set_latest_version("1.46.0-rc.1", ReleaseChannel::Rc);
|
|
fetch_and_store_latest_version(&env, &env).await;
|
|
env.add_hours(UPGRADE_CHECK_INTERVAL + 1);
|
|
|
|
// We should check for new version and prompt
|
|
let checker = UpdateChecker::new(env.clone(), env.clone());
|
|
assert!(checker.should_check_for_new_version());
|
|
assert_eq!(
|
|
checker.should_prompt(),
|
|
Some((ReleaseChannel::Rc, "1.46.0-rc.1".to_string()))
|
|
);
|
|
}
|
|
|
|
#[tokio::test]
|
|
async fn test_update_checker_current_newer_than_latest() {
|
|
let env = TestUpdateCheckerEnvironment::new();
|
|
let file_content = CheckVersionFile {
|
|
last_prompt: env
|
|
.current_time()
|
|
.sub(chrono::Duration::hours(UPGRADE_CHECK_INTERVAL + 1)),
|
|
last_checked: env.current_time(),
|
|
latest_version: "1.26.2".to_string(),
|
|
current_version: "1.27.0".to_string(),
|
|
current_release_channel: ReleaseChannel::Stable,
|
|
}
|
|
.serialize();
|
|
env.write_check_file(&file_content);
|
|
env.set_current_version("1.27.0");
|
|
env.set_latest_version("1.26.2", ReleaseChannel::Stable);
|
|
let checker = UpdateChecker::new(env.clone(), env);
|
|
|
|
// since currently running version is newer than latest available (eg. CDN
|
|
// propagation might be delated) we should not prompt
|
|
assert_eq!(checker.should_prompt(), None);
|
|
}
|
|
|
|
#[tokio::test]
|
|
async fn test_should_not_prompt_if_current_cli_version_has_changed() {
|
|
let env = TestUpdateCheckerEnvironment::new();
|
|
let file_content = CheckVersionFile {
|
|
last_prompt: env
|
|
.current_time()
|
|
.sub(chrono::Duration::hours(UPGRADE_CHECK_INTERVAL + 1)),
|
|
last_checked: env.current_time(),
|
|
latest_version: "1.26.2".to_string(),
|
|
current_version: "1.25.0".to_string(),
|
|
current_release_channel: ReleaseChannel::Stable,
|
|
}
|
|
.serialize();
|
|
env.write_check_file(&file_content);
|
|
// simulate an upgrade done to a canary version
|
|
env.set_current_version("61fbfabe440f1cfffa7b8d17426ffdece4d430d0");
|
|
let checker = UpdateChecker::new(env.clone(), env);
|
|
assert_eq!(checker.should_prompt(), None);
|
|
}
|
|
|
|
#[test]
|
|
fn test_get_latest_version_url() {
|
|
assert_eq!(
|
|
get_latest_version_url(
|
|
ReleaseChannel::Canary,
|
|
"aarch64-apple-darwin",
|
|
UpgradeCheckKind::Execution
|
|
),
|
|
"https://dl.deno.land/canary-aarch64-apple-darwin-latest.txt"
|
|
);
|
|
assert_eq!(
|
|
get_latest_version_url(
|
|
ReleaseChannel::Canary,
|
|
"aarch64-apple-darwin",
|
|
UpgradeCheckKind::Lsp
|
|
),
|
|
"https://dl.deno.land/canary-aarch64-apple-darwin-latest.txt?lsp"
|
|
);
|
|
assert_eq!(
|
|
get_latest_version_url(
|
|
ReleaseChannel::Canary,
|
|
"x86_64-pc-windows-msvc",
|
|
UpgradeCheckKind::Execution
|
|
),
|
|
"https://dl.deno.land/canary-x86_64-pc-windows-msvc-latest.txt"
|
|
);
|
|
assert_eq!(
|
|
get_latest_version_url(
|
|
ReleaseChannel::Canary,
|
|
"x86_64-pc-windows-msvc",
|
|
UpgradeCheckKind::Lsp
|
|
),
|
|
"https://dl.deno.land/canary-x86_64-pc-windows-msvc-latest.txt?lsp"
|
|
);
|
|
assert_eq!(
|
|
get_latest_version_url(
|
|
ReleaseChannel::Stable,
|
|
"aarch64-apple-darwin",
|
|
UpgradeCheckKind::Execution
|
|
),
|
|
"https://dl.deno.land/release-latest.txt"
|
|
);
|
|
assert_eq!(
|
|
get_latest_version_url(
|
|
ReleaseChannel::Stable,
|
|
"aarch64-apple-darwin",
|
|
UpgradeCheckKind::Lsp
|
|
),
|
|
"https://dl.deno.land/release-latest.txt?lsp"
|
|
);
|
|
assert_eq!(
|
|
get_latest_version_url(
|
|
ReleaseChannel::Stable,
|
|
"x86_64-pc-windows-msvc",
|
|
UpgradeCheckKind::Execution
|
|
),
|
|
"https://dl.deno.land/release-latest.txt"
|
|
);
|
|
assert_eq!(
|
|
get_latest_version_url(
|
|
ReleaseChannel::Rc,
|
|
"x86_64-pc-windows-msvc",
|
|
UpgradeCheckKind::Lsp
|
|
),
|
|
"https://dl.deno.land/release-rc-latest.txt?lsp"
|
|
);
|
|
assert_eq!(
|
|
get_latest_version_url(
|
|
ReleaseChannel::Rc,
|
|
"aarch64-apple-darwin",
|
|
UpgradeCheckKind::Execution
|
|
),
|
|
"https://dl.deno.land/release-rc-latest.txt"
|
|
);
|
|
assert_eq!(
|
|
get_latest_version_url(
|
|
ReleaseChannel::Rc,
|
|
"aarch64-apple-darwin",
|
|
UpgradeCheckKind::Lsp
|
|
),
|
|
"https://dl.deno.land/release-rc-latest.txt?lsp"
|
|
);
|
|
assert_eq!(
|
|
get_latest_version_url(
|
|
ReleaseChannel::Rc,
|
|
"x86_64-pc-windows-msvc",
|
|
UpgradeCheckKind::Execution
|
|
),
|
|
"https://dl.deno.land/release-rc-latest.txt"
|
|
);
|
|
assert_eq!(
|
|
get_latest_version_url(
|
|
ReleaseChannel::Rc,
|
|
"x86_64-pc-windows-msvc",
|
|
UpgradeCheckKind::Lsp
|
|
),
|
|
"https://dl.deno.land/release-rc-latest.txt?lsp"
|
|
);
|
|
assert_eq!(
|
|
get_latest_version_url(
|
|
ReleaseChannel::Lts,
|
|
"x86_64-pc-windows-msvc",
|
|
UpgradeCheckKind::Lsp
|
|
),
|
|
"https://dl.deno.land/release-lts-latest.txt?lsp"
|
|
);
|
|
assert_eq!(
|
|
get_latest_version_url(
|
|
ReleaseChannel::Lts,
|
|
"aarch64-apple-darwin",
|
|
UpgradeCheckKind::Execution
|
|
),
|
|
"https://dl.deno.land/release-lts-latest.txt"
|
|
);
|
|
assert_eq!(
|
|
get_latest_version_url(
|
|
ReleaseChannel::Lts,
|
|
"aarch64-apple-darwin",
|
|
UpgradeCheckKind::Lsp
|
|
),
|
|
"https://dl.deno.land/release-lts-latest.txt?lsp"
|
|
);
|
|
assert_eq!(
|
|
get_latest_version_url(
|
|
ReleaseChannel::Lts,
|
|
"x86_64-pc-windows-msvc",
|
|
UpgradeCheckKind::Execution
|
|
),
|
|
"https://dl.deno.land/release-lts-latest.txt"
|
|
);
|
|
assert_eq!(
|
|
get_latest_version_url(
|
|
ReleaseChannel::Lts,
|
|
"x86_64-pc-windows-msvc",
|
|
UpgradeCheckKind::Lsp
|
|
),
|
|
"https://dl.deno.land/release-lts-latest.txt?lsp"
|
|
);
|
|
}
|
|
|
|
#[test]
|
|
fn test_normalize_version_server() {
|
|
// should strip v for stable
|
|
assert_eq!(
|
|
normalize_version_from_server(ReleaseChannel::Stable, "v1.0.0").unwrap(),
|
|
AvailableVersion {
|
|
version_or_hash: "1.0.0".to_string(),
|
|
release_channel: ReleaseChannel::Stable,
|
|
},
|
|
);
|
|
// should not replace v after start
|
|
assert_eq!(
|
|
normalize_version_from_server(
|
|
ReleaseChannel::Stable,
|
|
" v1.0.0-test-v\n\n "
|
|
)
|
|
.unwrap(),
|
|
AvailableVersion {
|
|
version_or_hash: "1.0.0-test-v".to_string(),
|
|
release_channel: ReleaseChannel::Stable,
|
|
}
|
|
);
|
|
// should not strip v for canary
|
|
assert_eq!(
|
|
normalize_version_from_server(
|
|
ReleaseChannel::Canary,
|
|
" v1452345asdf \n\n "
|
|
)
|
|
.unwrap(),
|
|
AvailableVersion {
|
|
version_or_hash: "v1452345asdf".to_string(),
|
|
release_channel: ReleaseChannel::Canary,
|
|
}
|
|
);
|
|
assert_eq!(
|
|
normalize_version_from_server(ReleaseChannel::Rc, "v1.46.0-rc.0\n\n")
|
|
.unwrap(),
|
|
AvailableVersion {
|
|
version_or_hash: "1.46.0-rc.0".to_string(),
|
|
release_channel: ReleaseChannel::Rc,
|
|
},
|
|
);
|
|
}
|
|
|
|
#[tokio::test]
|
|
async fn test_upgrades_lsp() {
|
|
let env = TestUpdateCheckerEnvironment::new();
|
|
env.set_current_version("1.0.0");
|
|
env.set_latest_version("2.0.0", ReleaseChannel::Stable);
|
|
|
|
// greater
|
|
{
|
|
let maybe_info = check_for_upgrades_for_lsp_with_provider(&env)
|
|
.await
|
|
.unwrap();
|
|
assert_eq!(
|
|
maybe_info,
|
|
Some(LspVersionUpgradeInfo {
|
|
latest_version: "2.0.0".to_string(),
|
|
is_canary: false,
|
|
})
|
|
);
|
|
}
|
|
// equal
|
|
{
|
|
env.set_latest_version("1.0.0", ReleaseChannel::Stable);
|
|
let maybe_info = check_for_upgrades_for_lsp_with_provider(&env)
|
|
.await
|
|
.unwrap();
|
|
assert_eq!(maybe_info, None);
|
|
}
|
|
// less
|
|
{
|
|
env.set_latest_version("0.9.0", ReleaseChannel::Stable);
|
|
let maybe_info = check_for_upgrades_for_lsp_with_provider(&env)
|
|
.await
|
|
.unwrap();
|
|
assert_eq!(maybe_info, None);
|
|
}
|
|
// canary equal
|
|
{
|
|
env.set_current_version("123");
|
|
env.set_latest_version("123", ReleaseChannel::Stable);
|
|
env.set_release_channel(ReleaseChannel::Canary);
|
|
let maybe_info = check_for_upgrades_for_lsp_with_provider(&env)
|
|
.await
|
|
.unwrap();
|
|
assert_eq!(maybe_info, None);
|
|
}
|
|
// canary different
|
|
{
|
|
env.set_latest_version("1234", ReleaseChannel::Stable);
|
|
let maybe_info = check_for_upgrades_for_lsp_with_provider(&env)
|
|
.await
|
|
.unwrap();
|
|
assert_eq!(
|
|
maybe_info,
|
|
Some(LspVersionUpgradeInfo {
|
|
latest_version: "1234".to_string(),
|
|
is_canary: true,
|
|
})
|
|
);
|
|
}
|
|
// rc equal
|
|
{
|
|
env.set_release_channel(ReleaseChannel::Rc);
|
|
env.set_current_version("1.2.3-rc.0");
|
|
env.set_latest_version("1.2.3-rc.0", ReleaseChannel::Rc);
|
|
let maybe_info = check_for_upgrades_for_lsp_with_provider(&env)
|
|
.await
|
|
.unwrap();
|
|
assert_eq!(maybe_info, None);
|
|
}
|
|
// canary different
|
|
{
|
|
env.set_latest_version("1.2.3-rc.0", ReleaseChannel::Rc);
|
|
env.set_latest_version("1.2.3-rc.1", ReleaseChannel::Rc);
|
|
let maybe_info = check_for_upgrades_for_lsp_with_provider(&env)
|
|
.await
|
|
.unwrap();
|
|
assert_eq!(
|
|
maybe_info,
|
|
Some(LspVersionUpgradeInfo {
|
|
latest_version: "1.2.3-rc.1".to_string(),
|
|
is_canary: false,
|
|
})
|
|
);
|
|
}
|
|
}
|
|
|
|
#[test]
|
|
fn blog_post_links() {
|
|
let version = Version::parse_standard("1.46.0").unwrap();
|
|
assert_eq!(
|
|
get_minor_version_blog_post_url(&version),
|
|
"https://deno.com/blog/v1.46"
|
|
);
|
|
|
|
let version = Version::parse_standard("2.1.1").unwrap();
|
|
assert_eq!(
|
|
get_minor_version_blog_post_url(&version),
|
|
"https://deno.com/blog/v2.1"
|
|
);
|
|
|
|
let version = Version::parse_standard("2.0.0-rc.0").unwrap();
|
|
assert_eq!(
|
|
get_rc_version_blog_post_url(&version),
|
|
"https://deno.com/blog/v2.0-rc-0"
|
|
);
|
|
|
|
let version = Version::parse_standard("2.0.0-rc.2").unwrap();
|
|
assert_eq!(
|
|
get_rc_version_blog_post_url(&version),
|
|
"https://deno.com/blog/v2.0-rc-2"
|
|
);
|
|
}
|
|
}
|