1
0
Fork 0
mirror of https://github.com/denoland/deno.git synced 2025-01-05 13:59:01 -05:00
denoland-deno/ext
Marvin Hagemeister 08813ea25e
fix(node): map stdio [0, 1, 2] to "inherit" (#19352)
<!--
Before submitting a PR, please read https://deno.com/manual/contributing

1. Give the PR a descriptive title.

  Examples of good title:
    - fix(std/http): Fix race condition in server
    - docs(console): Update docstrings
    - feat(doc): Handle nested reexports

  Examples of bad title:
    - fix #7123
    - update docs
    - fix bugs

2. Ensure there is a related issue and it is referenced in the PR text.
3. Ensure there are tests that cover the changes.
4. Ensure `cargo test` passes.
5. Ensure `./tools/format.js` passes without changing files.
6. Ensure `./tools/lint.js` passes.
7. Open as a draft PR if your work is still in progress. The CI won't
run
   all steps, but you can add '[ci]' to a commit message to force it to.
8. If you would like to run the benchmarks on the CI, add the 'ci-bench'
label.
-->
Internally, `node-tap` spawns a child process with `stdio: [0, 1, 2]`.
Whilst we don't support passing fd numbers as an argument so far, it
turns out that `[0, 1, 2]` is equivalent to `"inherit"` which we already
support. See: https://nodejs.org/api/child_process.html#optionsstdio

Mapping it to `"inherit"` is fine for us and gets us one step closer in
getting `node-tap` working. I'm now at the stage where already the
coverage table is shown 🎉
2023-06-09 01:13:20 +02:00
..
broadcast_channel 1.34.1 (#19310) 2023-05-30 01:30:46 +02:00
cache 1.34.1 (#19310) 2023-05-30 01:30:46 +02:00
console 1.34.1 (#19310) 2023-05-30 01:30:46 +02:00
crypto 1.34.1 (#19310) 2023-05-30 01:30:46 +02:00
fetch 1.34.1 (#19310) 2023-05-30 01:30:46 +02:00
ffi 1.34.1 (#19310) 2023-05-30 01:30:46 +02:00
fs 1.34.1 (#19310) 2023-05-30 01:30:46 +02:00
http chore(ext/http): add env var to disable writev syscall (#19338) 2023-06-09 01:13:19 +02:00
io 1.34.1 (#19310) 2023-05-30 01:30:46 +02:00
kv 1.34.1 (#19310) 2023-05-30 01:30:46 +02:00
napi 1.34.1 (#19310) 2023-05-30 01:30:46 +02:00
net pin enum-as-inner dependency 2023-05-30 02:10:33 +02:00
node fix(node): map stdio [0, 1, 2] to "inherit" (#19352) 2023-06-09 01:13:20 +02:00
tls 1.34.1 (#19310) 2023-05-30 01:30:46 +02:00
url 1.34.1 (#19310) 2023-05-30 01:30:46 +02:00
web refactor: further work on node http client (#19327) 2023-06-09 01:13:18 +02:00
webidl 1.34.1 (#19310) 2023-05-30 01:30:46 +02:00
websocket 1.34.1 (#19310) 2023-05-30 01:30:46 +02:00
webstorage 1.34.1 (#19310) 2023-05-30 01:30:46 +02:00