mirror of
https://github.com/denoland/deno.git
synced 2024-12-26 17:19:06 -05:00
25fdc7bf6c
<!-- Before submitting a PR, please read https://deno.com/manual/contributing 1. Give the PR a descriptive title. Examples of good title: - fix(std/http): Fix race condition in server - docs(console): Update docstrings - feat(doc): Handle nested reexports Examples of bad title: - fix #7123 - update docs - fix bugs 2. Ensure there is a related issue and it is referenced in the PR text. 3. Ensure there are tests that cover the changes. 4. Ensure `cargo test` passes. 5. Ensure `./tools/format.js` passes without changing files. 6. Ensure `./tools/lint.js` passes. 7. Open as a draft PR if your work is still in progress. The CI won't run all steps, but you can add '[ci]' to a commit message to force it to. 8. If you would like to run the benchmarks on the CI, add the 'ci-bench' label. --> ## WHY ref: https://github.com/denoland/deno/issues/19165 Node's fs/promises includes a FileHandle class, but deno does not. The open function in Node's fs/promises returns a FileHandle, which provides an IO interface to the file. However, deno's open function returns a resource id. ### deno ```js > const fs = await import("node:fs/promises"); undefined > const file3 = await fs.open("./README.md"); undefined > file3 3 > file3.read undefined Node: ``` ### Node ```js > const fs = await import("fs/promises"); undefined > const file3 = await fs.open("./tests/e2e_unit/testdata/file.txt"); undefined > file3 FileHandle { _events: [Object: null prototype] {}, _eventsCount: 0, _maxListeners: undefined, close: [Function: close], [Symbol(kCapture)]: false, [Symbol(kHandle)]: FileHandle {}, [Symbol(kFd)]: 24, [Symbol(kRefs)]: 1, [Symbol(kClosePromise)]: null } > file3.read [Function: read] ``` To be compatible with Node, deno's open function should also return a FileHandle. ## WHAT I have implemented the first step in adding a FileHandle. - Changed the return value of the open function to a FileHandle object - Implemented the readFile method in FileHandle - Add test code ## What to do next This PR is the first step in adding a FileHandle, and there are things that should be done next. - Add functionality equivalent to Node's FileHandle to FileHandle (currently there is only readFile) --------- Co-authored-by: Matt Mastracci <matthew@mastracci.com>
179 lines
5.4 KiB
Rust
179 lines
5.4 KiB
Rust
// Copyright 2018-2023 the Deno authors. All rights reserved. MIT license.
|
|
use std::io::BufRead;
|
|
use std::io::BufReader;
|
|
use std::process::Stdio;
|
|
use std::time::Duration;
|
|
use std::time::Instant;
|
|
use test_util as util;
|
|
use util::env_vars_for_npm_tests;
|
|
|
|
util::unit_test_factory!(
|
|
node_unit_test,
|
|
"tests/unit_node",
|
|
"**/*_test.ts",
|
|
[
|
|
_fs_access_test = _fs / _fs_access_test,
|
|
_fs_appendFile_test = _fs / _fs_appendFile_test,
|
|
_fs_chmod_test = _fs / _fs_chmod_test,
|
|
_fs_chown_test = _fs / _fs_chown_test,
|
|
_fs_close_test = _fs / _fs_close_test,
|
|
_fs_copy_test = _fs / _fs_copy_test,
|
|
_fs_dir_test = _fs / _fs_dir_test,
|
|
_fs_exists_test = _fs / _fs_exists_test,
|
|
_fs_fdatasync_test = _fs / _fs_fdatasync_test,
|
|
_fs_fstat_test = _fs / _fs_fstat_test,
|
|
_fs_fsync_test = _fs / _fs_fsync_test,
|
|
_fs_ftruncate_test = _fs / _fs_ftruncate_test,
|
|
_fs_futimes_test = _fs / _fs_futimes_test,
|
|
_fs_handle_test = _fs / _fs_handle_test,
|
|
_fs_link_test = _fs / _fs_link_test,
|
|
_fs_lstat_test = _fs / _fs_lstat_test,
|
|
_fs_mkdir_test = _fs / _fs_mkdir_test,
|
|
_fs_mkdtemp_test = _fs / _fs_mkdtemp_test,
|
|
_fs_opendir_test = _fs / _fs_opendir_test,
|
|
_fs_readFile_test = _fs / _fs_readFile_test,
|
|
_fs_readdir_test = _fs / _fs_readdir_test,
|
|
_fs_readlink_test = _fs / _fs_readlink_test,
|
|
_fs_realpath_test = _fs / _fs_realpath_test,
|
|
_fs_rename_test = _fs / _fs_rename_test,
|
|
_fs_rm_test = _fs / _fs_rm_test,
|
|
_fs_rmdir_test = _fs / _fs_rmdir_test,
|
|
_fs_stat_test = _fs / _fs_stat_test,
|
|
_fs_symlink_test = _fs / _fs_symlink_test,
|
|
_fs_truncate_test = _fs / _fs_truncate_test,
|
|
_fs_unlink_test = _fs / _fs_unlink_test,
|
|
_fs_utimes_test = _fs / _fs_utimes_test,
|
|
_fs_watch_test = _fs / _fs_watch_test,
|
|
_fs_write_test = _fs / _fs_write_test,
|
|
async_hooks_test,
|
|
child_process_test,
|
|
crypto_cipher_test = crypto / crypto_cipher_test,
|
|
crypto_hash_test = crypto / crypto_hash_test,
|
|
crypto_key_test = crypto / crypto_key_test,
|
|
crypto_sign_test = crypto / crypto_sign_test,
|
|
fs_test,
|
|
http_test,
|
|
_randomBytes_test = internal / _randomBytes_test,
|
|
_randomFill_test = internal / _randomFill_test,
|
|
_randomInt_test = internal / _randomInt_test,
|
|
pbkdf2_test = internal / pbkdf2_test,
|
|
scrypt_test = internal / scrypt_test,
|
|
module_test,
|
|
os_test,
|
|
process_test,
|
|
querystring_test,
|
|
readline_test,
|
|
string_decoder_test,
|
|
timers_test,
|
|
tls_test,
|
|
tty_test,
|
|
util_test,
|
|
v8_test,
|
|
worker_threads_test
|
|
]
|
|
);
|
|
|
|
fn node_unit_test(test: String) {
|
|
let _g = util::http_server();
|
|
|
|
let mut deno = util::deno_cmd();
|
|
let mut deno = deno
|
|
.current_dir(util::root_path())
|
|
.arg("test")
|
|
.arg("--unstable")
|
|
// TODO(kt3k): This option is required to pass tls_test.ts,
|
|
// but this shouldn't be necessary. tls.connect currently doesn't
|
|
// pass hostname option correctly and it causes cert errors.
|
|
.arg("--unsafely-ignore-certificate-errors")
|
|
.arg("-A");
|
|
// Parallel tests for crypto
|
|
if test.starts_with("crypto/") {
|
|
deno = deno.arg("--parallel");
|
|
}
|
|
let mut deno = deno
|
|
.arg(
|
|
util::tests_path()
|
|
.join("unit_node")
|
|
.join(format!("{test}.ts")),
|
|
)
|
|
.stderr(Stdio::piped())
|
|
.stdout(Stdio::piped())
|
|
.spawn()
|
|
.expect("failed to spawn script");
|
|
|
|
let now = Instant::now();
|
|
let stdout = deno.stdout.take().unwrap();
|
|
let test_name = test.clone();
|
|
let stdout = std::thread::spawn(move || {
|
|
let reader = BufReader::new(stdout);
|
|
for line in reader.lines() {
|
|
if let Ok(line) = line {
|
|
println!("[{test_name} {:0>6.2}] {line}", now.elapsed().as_secs_f32());
|
|
} else {
|
|
break;
|
|
}
|
|
}
|
|
});
|
|
|
|
let now = Instant::now();
|
|
let stderr = deno.stderr.take().unwrap();
|
|
let test_name = test.clone();
|
|
let stderr = std::thread::spawn(move || {
|
|
let reader = BufReader::new(stderr);
|
|
for line in reader.lines() {
|
|
if let Ok(line) = line {
|
|
eprintln!("[{test_name} {:0>6.2}] {line}", now.elapsed().as_secs_f32());
|
|
} else {
|
|
break;
|
|
}
|
|
}
|
|
});
|
|
|
|
const PER_TEST_TIMEOUT: Duration = Duration::from_secs(5 * 60);
|
|
|
|
let now = Instant::now();
|
|
let status = loop {
|
|
if now.elapsed() > PER_TEST_TIMEOUT {
|
|
// Last-ditch kill
|
|
_ = deno.kill();
|
|
panic!("Test {test} failed to complete in time");
|
|
}
|
|
if let Some(status) = deno
|
|
.try_wait()
|
|
.expect("failed to wait for the child process")
|
|
{
|
|
break status;
|
|
}
|
|
std::thread::sleep(Duration::from_millis(100));
|
|
};
|
|
|
|
#[cfg(unix)]
|
|
assert_eq!(
|
|
std::os::unix::process::ExitStatusExt::signal(&status),
|
|
None,
|
|
"Deno should not have died with a signal"
|
|
);
|
|
assert_eq!(Some(0), status.code(), "Deno should have exited cleanly");
|
|
|
|
stdout.join().unwrap();
|
|
stderr.join().unwrap();
|
|
|
|
assert!(status.success());
|
|
}
|
|
|
|
// Regression test for https://github.com/denoland/deno/issues/16928
|
|
itest!(unhandled_rejection_web {
|
|
args: "run -A node/unhandled_rejection_web.ts",
|
|
output: "node/unhandled_rejection_web.ts.out",
|
|
envs: env_vars_for_npm_tests(),
|
|
http_server: true,
|
|
});
|
|
|
|
// Ensure that Web `onunhandledrejection` is fired before
|
|
// Node's `process.on('unhandledRejection')`.
|
|
itest!(unhandled_rejection_web_process {
|
|
args: "run -A node/unhandled_rejection_web_process.ts",
|
|
output: "node/unhandled_rejection_web_process.ts.out",
|
|
envs: env_vars_for_npm_tests(),
|
|
http_server: true,
|
|
});
|