mirror of
https://github.com/denoland/deno.git
synced 2024-11-24 15:19:26 -05:00
ce7dc2be92
Adds support for running npm package lifecycle scripts, opted into via a new `--allow-scripts` flag. With this PR, when running `deno cache` (or `DENO_FUTURE=1 deno install`) you can specify the `--allow-scripts=pkg1,pkg2` flag to run lifecycle scripts attached to the given packages. Note at the moment this only works when `nodeModulesDir` is true (using the local resolver). When a package with un-run lifecycle scripts is encountered, we emit a warning suggesting things may not work and to try running lifecycle scripts. Additionally, if a package script implicitly requires `node-gyp` and it's not found on the system, we emit a warning. Extra things in this PR: - Extracted out bits of `task.rs` into a separate module for reuse - Added a couple fields to `process.config` in order to support `node-gyp` (it relies on a few variables being there) - Drive by fix to downloading new npm packages to test registry --- TODO: - [x] validation for allow-scripts args (make sure it looks like an npm package) - [x] make allow-scripts matching smarter - [ ] figure out what issues this closes --- Review notes: - This adds a bunch of deps to our test registry due to using `node-gyp`, so it's pretty noisy
12 lines
No EOL
381 B
JSON
12 lines
No EOL
381 B
JSON
{
|
|
"name": "@denotest/node-lifecycle-scripts",
|
|
"version": "1.0.0",
|
|
"scripts": {
|
|
"preinstall": "echo preinstall && node preinstall.js && node --require ./helper.js preinstall.js",
|
|
"install": "echo install && cli-esm 'hello from install script'",
|
|
"postinstall": "echo postinstall && npx cowsay postinstall"
|
|
},
|
|
"dependencies": {
|
|
"@denotest/bin": "1.0.0"
|
|
}
|
|
} |