1
0
Fork 0
mirror of https://github.com/denoland/deno.git synced 2024-11-25 15:29:32 -05:00
denoland-deno/serde_v8
Divy Srivastava 9be8f61f52
chore: use rustfmt imports_granularity option (#17421)
Closes https://github.com/denoland/deno/issues/2699
Closes https://github.com/denoland/deno/issues/2347

Uses unstable rustfmt features. Since dprint invokes `rustfmt` we do not
need to switch the cargo toolchain to nightly. Do we care about
formatting stability of our codebase across Rust versions? (I don't)
2023-01-16 21:35:00 +01:00
..
benches chore: use rustfmt imports_granularity option (#17421) 2023-01-16 21:35:00 +01:00
examples chore: update copyright year to 2023 (#17247) 2023-01-05 13:05:49 +01:00
magic chore: use rustfmt imports_granularity option (#17421) 2023-01-16 21:35:00 +01:00
tests chore: use rustfmt imports_granularity option (#17421) 2023-01-16 21:35:00 +01:00
Cargo.toml 1.29.3 (#17395) 2023-01-13 12:17:13 -05:00
de.rs chore: use rustfmt imports_granularity option (#17421) 2023-01-16 21:35:00 +01:00
error.rs chore: use rustfmt imports_granularity option (#17421) 2023-01-16 21:35:00 +01:00
keys.rs chore: update copyright year to 2023 (#17247) 2023-01-05 13:05:49 +01:00
lib.rs chore: use rustfmt imports_granularity option (#17421) 2023-01-16 21:35:00 +01:00
payload.rs chore: update copyright year to 2023 (#17247) 2023-01-05 13:05:49 +01:00
README.md chore: upgrade deno_ast to 0.5.0 (#12595) 2021-11-01 16:22:27 -04:00
ser.rs chore: use rustfmt imports_granularity option (#17421) 2023-01-16 21:35:00 +01:00
serializable.rs chore: update copyright year to 2023 (#17247) 2023-01-05 13:05:49 +01:00
utils.rs chore: update copyright year to 2023 (#17247) 2023-01-05 13:05:49 +01:00

serde_v8

Author: Aaron O'Mullan aaron.omullan@gmail.com

Serde support for encoding/decoding (rusty_)v8 values.

Broadly serde_v8 aims to provide an expressive but ~maximally efficient encoding layer to biject rust & v8/js values. It's a core component of deno's op-layer and is used to encode/decode all non-buffer values.

Original issue: denoland/deno#9540

Quickstart

serde_v8 fits naturally into the serde ecosystem, so if you've already used serde or serde_json, serde_v8's API should be very familiar.

serde_v8 exposes two key-functions:

  • to_v8: maps rust->v8, similar to serde_json::to_string, ...
  • from_v8: maps v8->rust, similar to serde_json::from_str, ...

Best practices

Whilst serde_v8 is compatible with serde_json::Value it's important to keep in mind that serde_json::Value is essentially a loosely-typed value (think nested HashMaps), so when writing ops we recommend directly using rust structs/tuples or primitives, since mapping to serde_json::Value will add extra overhead and result in slower ops.

I also recommend avoiding unecessary "wrappers", if your op takes a single-keyed struct, consider unwrapping that as a plain value unless you plan to add fields in the near-future.

Instead of returning "nothing" via Ok(json!({})), change your return type to rust's unit type () and returning Ok(()), serde_v8 will efficiently encode that as a JS null.

Advanced features

If you need to mix rust & v8 values in structs/tuples, you can use the special serde_v8::Value type, which will passthrough the original v8 value untouched when encoding/decoding.

TODO

  • Experiment with KeyCache to optimize struct keys
  • Experiment with external v8 strings
  • Explore using json-stringifier.cc's fast-paths for arrays
  • Improve tests to test parity with serde_json (should be mostly interchangeable)
  • Consider a Payload type that's deserializable by itself (holds scope & value)
  • Ensure we return errors instead of panicking on .unwrap()s