mirror of
https://github.com/denoland/deno.git
synced 2024-12-26 00:59:24 -05:00
25fdc7bf6c
<!-- Before submitting a PR, please read https://deno.com/manual/contributing 1. Give the PR a descriptive title. Examples of good title: - fix(std/http): Fix race condition in server - docs(console): Update docstrings - feat(doc): Handle nested reexports Examples of bad title: - fix #7123 - update docs - fix bugs 2. Ensure there is a related issue and it is referenced in the PR text. 3. Ensure there are tests that cover the changes. 4. Ensure `cargo test` passes. 5. Ensure `./tools/format.js` passes without changing files. 6. Ensure `./tools/lint.js` passes. 7. Open as a draft PR if your work is still in progress. The CI won't run all steps, but you can add '[ci]' to a commit message to force it to. 8. If you would like to run the benchmarks on the CI, add the 'ci-bench' label. --> ## WHY ref: https://github.com/denoland/deno/issues/19165 Node's fs/promises includes a FileHandle class, but deno does not. The open function in Node's fs/promises returns a FileHandle, which provides an IO interface to the file. However, deno's open function returns a resource id. ### deno ```js > const fs = await import("node:fs/promises"); undefined > const file3 = await fs.open("./README.md"); undefined > file3 3 > file3.read undefined Node: ``` ### Node ```js > const fs = await import("fs/promises"); undefined > const file3 = await fs.open("./tests/e2e_unit/testdata/file.txt"); undefined > file3 FileHandle { _events: [Object: null prototype] {}, _eventsCount: 0, _maxListeners: undefined, close: [Function: close], [Symbol(kCapture)]: false, [Symbol(kHandle)]: FileHandle {}, [Symbol(kFd)]: 24, [Symbol(kRefs)]: 1, [Symbol(kClosePromise)]: null } > file3.read [Function: read] ``` To be compatible with Node, deno's open function should also return a FileHandle. ## WHAT I have implemented the first step in adding a FileHandle. - Changed the return value of the open function to a FileHandle object - Implemented the readFile method in FileHandle - Add test code ## What to do next This PR is the first step in adding a FileHandle, and there are things that should be done next. - Add functionality equivalent to Node's FileHandle to FileHandle (currently there is only readFile) --------- Co-authored-by: Matt Mastracci <matthew@mastracci.com> |
||
|---|---|---|
| .. | ||
| bench_tests.rs | ||
| bundle_tests.rs | ||
| cache_tests.rs | ||
| cert_tests.rs | ||
| check_tests.rs | ||
| compile_tests.rs | ||
| coverage_tests.rs | ||
| doc_tests.rs | ||
| eval_tests.rs | ||
| flags_tests.rs | ||
| fmt_tests.rs | ||
| info_tests.rs | ||
| init_tests.rs | ||
| inspector_tests.rs | ||
| install_tests.rs | ||
| js_unit_tests.rs | ||
| lint_tests.rs | ||
| lsp_tests.rs | ||
| mod.rs | ||
| node_compat_tests.rs | ||
| node_unit_tests.rs | ||
| npm_tests.rs | ||
| repl_tests.rs | ||
| run_tests.rs | ||
| shared_library_tests.rs | ||
| task_tests.rs | ||
| test_tests.rs | ||
| upgrade_tests.rs | ||
| vendor_tests.rs | ||
| watcher_tests.rs | ||
| worker_tests.rs | ||